cppquickfix.cpp 32.7 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
/**************************************************************************
**
** This file is part of Qt Creator
**
** Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
**
** Contact: Nokia Corporation (qt-info@nokia.com)
**
** Commercial Usage
**
** Licensees holding valid Qt Commercial licenses may use this file in
** accordance with the Qt Commercial License Agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Nokia.
**
** GNU Lesser General Public License Usage
**
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** If you are unsure which license is appropriate for your use, please
** contact the sales department at http://qt.nokia.com/contact.
**
**************************************************************************/

#include "cppquickfix.h"
#include "cppeditor.h"
32
33

#include <cplusplus/CppDocument.h>
34
#include <cplusplus/ResolveExpression.h>
35

36
#include <TranslationUnit.h>
37
38
#include <ASTVisitor.h>
#include <AST.h>
39
40
#include <ASTPatternBuilder.h>
#include <ASTMatcher.h>
41
42
43
44
45
46
47
48
#include <Token.h>

#include <cpptools/cppmodelmanagerinterface.h>
#include <QtDebug>

using namespace CppEditor::Internal;
using namespace CPlusPlus;

49
50
namespace {

51
52
53
54
55
56
57
58
59
class ASTPath: public ASTVisitor
{
    Document::Ptr _doc;
    unsigned _line;
    unsigned _column;
    QList<AST *> _nodes;

public:
    ASTPath(Document::Ptr doc)
Roberto Raggi's avatar
Roberto Raggi committed
60
61
62
        : ASTVisitor(doc->translationUnit()),
          _doc(doc), _line(0), _column(0)
    {}
63
64
65
66
67
68
69
70
71
72

    QList<AST *> operator()(const QTextCursor &cursor)
    {
        _nodes.clear();
        _line = cursor.blockNumber() + 1;
        _column = cursor.columnNumber() + 1;
        accept(_doc->translationUnit()->ast());
        return _nodes;
    }

73
74
#if 0
    // Useful for debugging:
75
76
77
78
79
80
    static void dump(const QList<AST *> nodes)
    {
        qDebug() << "ASTPath dump," << nodes.size() << "nodes:";
        for (int i = 0; i < nodes.size(); ++i)
            qDebug() << qPrintable(QString(i + 1, QLatin1Char('-'))) << typeid(*nodes.at(i)).name();
    }
81
#endif
82

83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
protected:
    virtual bool preVisit(AST *ast)
    {
        unsigned firstToken = ast->firstToken();
        unsigned lastToken = ast->lastToken();

        if (firstToken > 0 && lastToken > firstToken) {
            unsigned startLine, startColumn;
            getTokenStartPosition(firstToken, &startLine, &startColumn);

            if (_line > startLine || (_line == startLine && _column >= startColumn)) {

                unsigned endLine, endColumn;
                getTokenEndPosition(lastToken - 1, &endLine, &endColumn);

98
                if (_line < endLine || (_line == endLine && _column <= endColumn)) {
99
100
101
102
103
104
105
106
107
108
                    _nodes.append(ast);
                    return true;
                }
            }
        }

        return false;
    }
};

109
110
/*
    Rewrite
111
112
113
    a op b -> !(a invop b)
    (a op b) -> !(a invop b)
    !(a op b) -> (a invob b)
114
115
116
117
118
*/
class UseInverseOp: public QuickFixOperation
{
public:
    UseInverseOp()
119
        : binary(0), nested(0), negation(0)
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
    {}

    virtual QString description() const
    {
        return QLatin1String("Rewrite using ") + replacement; // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        int index = path.size() - 1;
        binary = path.at(index)->asBinaryExpression();
        if (! binary)
            return -1;
        if (! isCursorOn(binary->binary_op_token))
            return -1;

        CPlusPlus::Kind invertToken;
        switch (tokenAt(binary->binary_op_token).kind()) {
        case T_LESS_EQUAL:
            invertToken = T_GREATER;
            break;
        case T_LESS:
            invertToken = T_GREATER_EQUAL;
            break;
        case T_GREATER:
            invertToken = T_LESS_EQUAL;
            break;
        case T_GREATER_EQUAL:
            invertToken = T_LESS;
            break;
        case T_EQUAL_EQUAL:
            invertToken = T_EXCLAIM_EQUAL;
            break;
        case T_EXCLAIM_EQUAL:
            invertToken = T_EQUAL_EQUAL;
            break;
        default:
            return -1;
        }

        CPlusPlus::Token tok;
        tok.f.kind = invertToken;
        replacement = QLatin1String(tok.spell());
163
164
165
166
167
168
169
170
171
172
173
174

        // check for enclosing nested expression
        if (index - 1 >= 0)
            nested = path[index - 1]->asNestedExpression();

        // check for ! before parentheses
        if (nested && index - 2 >= 0) {
            negation = path[index - 2]->asUnaryExpression();
            if (negation && ! tokenAt(negation->unary_op_token).is(T_EXCLAIM))
                negation = 0;
        }

175
176
177
178
179
        return index;
    }

    virtual void createChangeSet()
    {
180
181
182
183
184
185
186
187
188
        if (negation) {
            // can't remove parentheses since that might break precedence
            remove(negation->unary_op_token);
        } else if (nested) {
            insert(startOf(nested), "!");
        } else {
            insert(startOf(binary), "!(");
            insert(endOf(binary), ")");
        }
189
190
191
192
193
        replace(binary->binary_op_token, replacement);
    }

private:
    BinaryExpressionAST *binary;
194
195
196
    NestedExpressionAST *nested;
    UnaryExpressionAST *negation;

197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
    QString replacement;
};

/*
    Rewrite
    a op b

    As
    b flipop a
*/
class FlipBinaryOp: public QuickFixOperation
{
public:
    FlipBinaryOp()
        : binary(0)
    {}


    virtual QString description() const
    {
        if (replacement.isEmpty())
            return QLatin1String("Flip");
        else
            return QLatin1String("Flip to use ") + replacement; // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        int index = path.size() - 1;
        binary = path.at(index)->asBinaryExpression();
        if (! binary)
            return -1;
        if (! isCursorOn(binary->binary_op_token))
            return -1;

        CPlusPlus::Kind flipToken;
        switch (tokenAt(binary->binary_op_token).kind()) {
        case T_LESS_EQUAL:
            flipToken = T_GREATER_EQUAL;
            break;
        case T_LESS:
            flipToken = T_GREATER;
            break;
        case T_GREATER:
            flipToken = T_LESS;
            break;
        case T_GREATER_EQUAL:
            flipToken = T_LESS_EQUAL;
            break;
        case T_EQUAL_EQUAL:
        case T_EXCLAIM_EQUAL:
        case T_AMPER_AMPER:
        case T_PIPE_PIPE:
            flipToken = T_EOF_SYMBOL;
            break;
        default:
            return -1;
        }

        if (flipToken != T_EOF_SYMBOL) {
            CPlusPlus::Token tok;
            tok.f.kind = flipToken;
            replacement = QLatin1String(tok.spell());
        }
        return index;
    }

    virtual void createChangeSet()
    {
        flip(binary->left_expression, binary->right_expression);
        if (! replacement.isEmpty())
            replace(binary->binary_op_token, replacement);
    }

private:
    BinaryExpressionAST *binary;
    QString replacement;
};

/*
    Rewrite
    !a && !b

    As
    !(a || b)
*/
283
284
285
class RewriteLogicalAndOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
286
287
    RewriteLogicalAndOp()
        : left(0), right(0), pattern(0)
288
289
290
291
292
293
294
    {}

    virtual QString description() const
    {
        return QLatin1String("Rewrite condition using ||"); // ### tr?
    }

295
    virtual int match(const QList<AST *> &path)
296
    {
297
298
299
300
301
302
303
304
305
306
307
308
        BinaryExpressionAST *expression = 0;

        int index = path.size() - 1;
        for (; index != -1; --index) {
            expression = path.at(index)->asBinaryExpression();
            if (expression)
                break;
        }

        if (! expression)
            return -1;

309
        if (! isCursorOn(expression->binary_op_token))
310
311
            return -1;

312
313
314
315
316
317
318
319
        left = mk.UnaryExpression();
        right = mk.UnaryExpression();
        pattern = mk.BinaryExpression(left, right);

        if (expression->match(pattern, &matcher) &&
                tokenAt(pattern->binary_op_token).is(T_AMPER_AMPER) &&
                tokenAt(left->unary_op_token).is(T_EXCLAIM) &&
                tokenAt(right->unary_op_token).is(T_EXCLAIM)) {
320
            return index;
321
322
        }

323
        return -1;
324
325
    }

Roberto Raggi's avatar
Roberto Raggi committed
326
    virtual void createChangeSet()
327
    {
Roberto Raggi's avatar
Roberto Raggi committed
328
        setTopLevelNode(pattern);
329
        replace(pattern->binary_op_token, QLatin1String("||"));
330
331
332
        remove(left->unary_op_token);
        remove(right->unary_op_token);
        insert(startOf(pattern), QLatin1String("!("));
333
        insert(endOf(pattern), QLatin1String(")"));
334
335
336
337
338
339
340
341
342
343
    }

private:
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    UnaryExpressionAST *left;
    UnaryExpressionAST *right;
    BinaryExpressionAST *pattern;
};

344
345
346
class SplitSimpleDeclarationOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
347
348
    SplitSimpleDeclarationOp()
        : declaration(0)
349
350
351
352
353
354
355
356
357
    {}

    virtual QString description() const
    {
        return QLatin1String("Split declaration"); // ### tr?
    }

    bool checkDeclaration(SimpleDeclarationAST *declaration) const
    {
358
359
360
        if (! declaration->semicolon_token)
            return false;

361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
        if (! declaration->decl_specifier_list)
            return false;

        for (SpecifierListAST *it = declaration->decl_specifier_list; it; it = it->next) {
            SpecifierAST *specifier = it->value;

            if (specifier->asEnumSpecifier() != 0)
                return false;

            else if (specifier->asClassSpecifier() != 0)
                return false;
        }

        if (! declaration->declarator_list)
            return false;

        else if (! declaration->declarator_list->next)
            return false;

        return true;
    }

383
    virtual int match(const QList<AST *> &path)
384
385
386
387
388
389
390
391
392
393
394
395
396
397
    {
        CoreDeclaratorAST *core_declarator = 0;

        int index = path.size() - 1;
        for (; index != -1; --index) {
            AST *node = path.at(index);

            if (CoreDeclaratorAST *coreDecl = node->asCoreDeclarator())
                core_declarator = coreDecl;

            else if (SimpleDeclarationAST *simpleDecl = node->asSimpleDeclaration()) {
                if (checkDeclaration(simpleDecl)) {
                    declaration = simpleDecl;

398
                    const int cursorPosition = selectionStart();
399
400
401
402
403
404
405

                    const int startOfDeclSpecifier = startOf(declaration->decl_specifier_list->firstToken());
                    const int endOfDeclSpecifier = endOf(declaration->decl_specifier_list->lastToken() - 1);

                    if (cursorPosition >= startOfDeclSpecifier && cursorPosition <= endOfDeclSpecifier)
                        return index; // the AST node under cursor is a specifier.

406
                    if (core_declarator && isCursorOn(core_declarator))
407
                        return index; // got a core-declarator under the text cursor.
408
409
410
411
412
413
414
415
416
                }

                break;
            }
        }

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
417
    virtual void createChangeSet()
418
    {
Roberto Raggi's avatar
Roberto Raggi committed
419
        setTopLevelNode(declaration);
420
        SpecifierListAST *specifiers = declaration->decl_specifier_list;
421
422
423
        int declSpecifiersStart = startOf(specifiers->firstToken());
        int declSpecifiersEnd = endOf(specifiers->lastToken() - 1);
        int insertPos = endOf(declaration->semicolon_token);
424

425
        DeclaratorAST *prevDeclarator = declaration->declarator_list->value;
426
427
428
429

        for (DeclaratorListAST *it = declaration->declarator_list->next; it; it = it->next) {
            DeclaratorAST *declarator = it->value;

430
431
432
433
434
435
436
            insert(insertPos, QLatin1String("\n"));
            copy(declSpecifiersStart, declSpecifiersEnd, insertPos);
            insert(insertPos, QLatin1String(" "));
            move(declarator, insertPos);
            insert(insertPos, QLatin1String(";"));

            remove(endOf(prevDeclarator), startOf(declarator));
437

438
439
            prevDeclarator = declarator;
        }
440
441
442
443
444
445
    }

private:
    SimpleDeclarationAST *declaration;
};

446
447
448
449
450
451
452
/*
    Add curly braces to a if statement that doesn't already contain a
    compound statement.
*/
class AddBracesToIfOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
453
454
    AddBracesToIfOp()
        : _statement(0)
455
456
457
458
459
460
461
    {}

    virtual QString description() const
    {
        return QLatin1String("Add curly braces"); // ### tr?
    }

462
    virtual int match(const QList<AST *> &path)
463
464
465
466
    {
        // show when we're on the 'if' of an if statement
        int index = path.size() - 1;
        IfStatementAST *ifStatement = path.at(index)->asIfStatement();
467
        if (ifStatement && isCursorOn(ifStatement->if_token)
468
469
470
471
472
473
474
475
476
            && ! ifStatement->statement->asCompoundStatement()) {
            _statement = ifStatement->statement;
            return index;
        }

        // or if we're on the statement contained in the if
        // ### This may not be such a good idea, consider nested ifs...
        for (; index != -1; --index) {
            IfStatementAST *ifStatement = path.at(index)->asIfStatement();
477
478
            if (ifStatement && ifStatement->statement
                && isCursorOn(ifStatement->statement)
479
480
481
482
483
484
485
486
487
488
489
490
                && ! ifStatement->statement->asCompoundStatement()) {
                _statement = ifStatement->statement;
                return index;
            }
        }

        // ### This could very well be extended to the else branch
        // and other nodes entirely.

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
491
    virtual void createChangeSet()
492
    {
Roberto Raggi's avatar
Roberto Raggi committed
493
        setTopLevelNode(_statement);
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
        insert(endOf(_statement->firstToken() - 1), QLatin1String(" {"));
        insert(endOf(_statement->lastToken() - 1), "\n}");
    }

private:
    StatementAST *_statement;
};

/*
    Replace
    if (Type name = foo()) {...}

    With
    Type name = foo;
    if (name) {...}
*/
510
class MoveDeclarationOutOfIfOp: public QuickFixOperation
511
512
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
513
514
    MoveDeclarationOutOfIfOp()
        : condition(0), pattern(0), core(0)
515
516
517
518
    {}

    virtual QString description() const
    {
519
        return QLatin1String("Move declaration out of condition"); // ### tr?
520
521
    }

522
    virtual int match(const QList<AST *> &path)
523
524
525
526
527
528
529
530
531
532
533
534
535
    {
        condition = mk.Condition();
        pattern = mk.IfStatement(condition);

        int index = path.size() - 1;
        for (; index != -1; --index) {
            if (IfStatementAST *statement = path.at(index)->asIfStatement()) {
                if (statement->match(pattern, &matcher) && condition->declarator) {
                    DeclaratorAST *declarator = condition->declarator;
                    core = declarator->core_declarator;
                    if (! core)
                        return -1;

536
                    if (isCursorOn(core))
537
538
539
540
541
542
543
544
                        return index;
                }
            }
        }

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
545
    virtual void createChangeSet()
546
    {
Roberto Raggi's avatar
Roberto Raggi committed
547
        setTopLevelNode(pattern);
548

549
550
551
552
553
        copy(core, startOf(condition));

        int insertPos = startOf(pattern);
        move(condition, insertPos);
        insert(insertPos, QLatin1String(";\n"));
554
555
556
557
558
559
560
561
562
563
564
    }

private:
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    CPPEditor *editor;
    ConditionAST *condition;
    IfStatementAST *pattern;
    CoreDeclaratorAST *core;
};

565
566
567
568
569
570
571
572
573
574
575
/*
    Replace
    while (Type name = foo()) {...}

    With
    Type name;
    while ((name = foo()) != 0) {...}
*/
class MoveDeclarationOutOfWhileOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
576
577
    MoveDeclarationOutOfWhileOp()
        : condition(0), pattern(0), core(0)
578
579
580
581
582
583
584
    {}

    virtual QString description() const
    {
        return QLatin1String("Move declaration out of condition"); // ### tr?
    }

585
    virtual int match(const QList<AST *> &path)
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
    {
        condition = mk.Condition();
        pattern = mk.WhileStatement(condition);

        int index = path.size() - 1;
        for (; index != -1; --index) {
            if (WhileStatementAST *statement = path.at(index)->asWhileStatement()) {
                if (statement->match(pattern, &matcher) && condition->declarator) {
                    DeclaratorAST *declarator = condition->declarator;
                    core = declarator->core_declarator;

                    if (! core)
                        return -1;

                    else if (! declarator->equals_token)
                        return -1;

                    else if (! declarator->initializer)
                        return -1;

606
                    if (isCursorOn(core))
607
608
609
610
611
612
613
614
                        return index;
                }
            }
        }

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
615
    virtual void createChangeSet()
616
    {
Roberto Raggi's avatar
Roberto Raggi committed
617
        setTopLevelNode(pattern);
618
619
620
621
622
623
624
625

        insert(startOf(condition), QLatin1String("("));
        insert(endOf(condition), QLatin1String(") != 0"));

        int insertPos = startOf(pattern);
        move(startOf(condition), startOf(core), insertPos);
        copy(core, insertPos);
        insert(insertPos, QLatin1String(";\n"));
626
627
628
629
630
631
632
633
634
635
636
    }

private:
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    CPPEditor *editor;
    ConditionAST *condition;
    WhileStatementAST *pattern;
    CoreDeclaratorAST *core;
};

Roberto Raggi's avatar
Roberto Raggi committed
637
638
639
640
641
642
643
644
645
646
/*
  Replace
     if (something && something_else) {
     }

  with
     if (something) {
        if (something_else) {
        }
     }
Roberto Raggi's avatar
Roberto Raggi committed
647
648
649
650
651
652
653
654
655
656

  and
    if (something || something_else)
      x;

  with
    if (something)
      x;
    else if (something_else)
      x;
Roberto Raggi's avatar
Roberto Raggi committed
657
658
659
660
*/
class SplitIfStatementOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
661
662
    SplitIfStatementOp()
        : condition(0), pattern(0)
Roberto Raggi's avatar
Roberto Raggi committed
663
664
665
666
667
668
669
    {}

    virtual QString description() const
    {
        return QLatin1String("Split if statement"); // ### tr?
    }

670
    virtual int match(const QList<AST *> &path)
Roberto Raggi's avatar
Roberto Raggi committed
671
    {
672
        pattern = 0;
Roberto Raggi's avatar
Roberto Raggi committed
673

674
675
676
677
678
679
680
681
682
        int index = path.size() - 1;
        for (; index != -1; --index) {
            AST *node = path.at(index);
            if (IfStatementAST *stmt = node->asIfStatement()) {
                pattern = stmt;
                break;
            }
        }

683
        if (! pattern || ! pattern->statement)
684
685
            return -1;

686
        unsigned splitKind = 0;
687
688
689
690
691
692
693
        for (++index; index < path.size(); ++index) {
            AST *node = path.at(index);
            condition = node->asBinaryExpression();
            if (! condition)
                return -1;

            Token binaryToken = tokenAt(condition->binary_op_token);
694
695
696
697
698
699
700
701
702
703

            // only accept a chain of ||s or &&s - no mixing
            if (! splitKind) {
                splitKind = binaryToken.kind();
                if (splitKind != T_AMPER_AMPER && splitKind != T_PIPE_PIPE)
                    return -1;
                // we can't reliably split &&s in ifs with an else branch
                if (splitKind == T_AMPER_AMPER && pattern->else_statement)
                    return -1;
            } else if (splitKind != binaryToken.kind()) {
704
705
                return -1;
            }
706
707
708

            if (isCursorOn(condition->binary_op_token))
                return index;
709
710
711
        }

        return -1;
Roberto Raggi's avatar
Roberto Raggi committed
712
713
    }

Roberto Raggi's avatar
Roberto Raggi committed
714
    virtual void createChangeSet()
Roberto Raggi's avatar
Roberto Raggi committed
715
    {
716
        Token binaryToken = tokenAt(condition->binary_op_token);
Roberto Raggi's avatar
Roberto Raggi committed
717

718
        if (binaryToken.is(T_AMPER_AMPER))
Roberto Raggi's avatar
Roberto Raggi committed
719
720
721
722
723
724
725
            splitAndCondition();
        else
            splitOrCondition();
    }

    void splitAndCondition()
    {
Roberto Raggi's avatar
Roberto Raggi committed
726
        setTopLevelNode(pattern);
Roberto Raggi's avatar
Roberto Raggi committed
727

728
729
730
731
732
733
734
        int startPos = startOf(pattern);
        insert(startPos, QLatin1String("if ("));
        move(condition->left_expression, startPos);
        insert(startPos, QLatin1String(") {\n"));

        remove(endOf(condition->left_expression), startOf(condition->right_expression));
        insert(endOf(pattern), QLatin1String("\n}"));
Roberto Raggi's avatar
Roberto Raggi committed
735
736
    }

Roberto Raggi's avatar
Roberto Raggi committed
737
738
739
740
741
    void splitOrCondition()
    {
        StatementAST *ifTrueStatement = pattern->statement;
        CompoundStatementAST *compoundStatement = ifTrueStatement->asCompoundStatement();

742
        setTopLevelNode(pattern);
Roberto Raggi's avatar
Roberto Raggi committed
743

744
        int insertPos = endOf(ifTrueStatement);
Roberto Raggi's avatar
Roberto Raggi committed
745
        if (compoundStatement)
746
            insert(insertPos, QLatin1String(" "));
Roberto Raggi's avatar
Roberto Raggi committed
747
        else
748
749
750
751
752
753
754
            insert(insertPos, QLatin1String("\n"));
        insert(insertPos, QLatin1String("else if ("));
        move(startOf(condition->right_expression), startOf(pattern->rparen_token), insertPos);
        insert(insertPos, QLatin1String(")"));
        copy(endOf(pattern->rparen_token), endOf(pattern->statement), insertPos);
        
        remove(endOf(condition->left_expression), startOf(condition->right_expression));
Roberto Raggi's avatar
Roberto Raggi committed
755
756
    }

Roberto Raggi's avatar
Roberto Raggi committed
757
758
759
760
private:
    BinaryExpressionAST *condition;
    IfStatementAST *pattern;
};
761

762
763
764
765
766
767
768
769
770
771
/*
  Replace
    "abcd"
  With
    QLatin1String("abcd")
*/
class WrapStringLiteral: public QuickFixOperation
{
public:
    WrapStringLiteral()
772
        : stringLiteral(0), isObjCStringLiteral(false)
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
    {}

    virtual QString description() const
    {
        return QLatin1String("Enclose in QLatin1String(...)"); // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        if (path.isEmpty())
            return -1;

        int index = path.size() - 1;
        stringLiteral = path[index]->asStringLiteral();

        if (!stringLiteral)
            return -1;

791
792
        isObjCStringLiteral = charAt(startOf(stringLiteral)) == QLatin1Char('@');

793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
        // check if it is already wrapped in QLatin1String or -Literal
        if (index-2 < 0)
            return index;

        CallAST *call = path[index-1]->asCall();
        PostfixExpressionAST *postfixExp = path[index-2]->asPostfixExpression();
        if (call && postfixExp
            && postfixExp->base_expression
            && postfixExp->postfix_expression_list
            && postfixExp->postfix_expression_list->value == call)
        {
            NameAST *callName = postfixExp->base_expression->asName();
            if (!callName)
                return index;

            QByteArray callNameString(tokenAt(callName->firstToken()).spell());
            if (callNameString == "QLatin1String"
                || callNameString == "QLatin1Literal"
                )
                return -1;
        }

        return index;
    }

    virtual void createChangeSet()
    {
820
821
822
823
824
825
826
827
        const int startPos = startOf(stringLiteral);
        const QLatin1String replacement("QLatin1String(");

        if (isObjCStringLiteral)
            replace(startPos, startPos + 1, replacement);
        else
            insert(startPos, replacement);

828
829
830
831
832
        insert(endOf(stringLiteral), ")");
    }

private:
    StringLiteralAST *stringLiteral;
833
    bool isObjCStringLiteral;
834
835
};

836
837
838
} // end of anonymous namespace


Roberto Raggi's avatar
Roberto Raggi committed
839
840
QuickFixOperation::QuickFixOperation()
    : _editor(0), _topLevelNode(0)
841
842
843
844
845
{ }

QuickFixOperation::~QuickFixOperation()
{ }

Roberto Raggi's avatar
Roberto Raggi committed
846
847
848
849
850
851
CPlusPlus::AST *QuickFixOperation::topLevelNode() const
{ return _topLevelNode; }

void QuickFixOperation::setTopLevelNode(CPlusPlus::AST *topLevelNode)
{ _topLevelNode = topLevelNode; }

Roberto Raggi's avatar
Roberto Raggi committed
852
853
854
const Utils::ChangeSet &QuickFixOperation::changeSet() const
{ return _changeSet; }

Roberto Raggi's avatar
Roberto Raggi committed
855
856
857
858
859
860
861
862
863
864
Document::Ptr QuickFixOperation::document() const
{ return _document; }

void QuickFixOperation::setDocument(CPlusPlus::Document::Ptr document)
{ _document = document; }

Snapshot QuickFixOperation::snapshot() const
{ return _snapshot; }

void QuickFixOperation::setSnapshot(const CPlusPlus::Snapshot &snapshot)
865
866
867
{
    _snapshot = snapshot;
}
Roberto Raggi's avatar
Roberto Raggi committed
868
869
870
871
872
873
874

CPPEditor *QuickFixOperation::editor() const
{ return _editor; }

void QuickFixOperation::setEditor(CPPEditor *editor)
{ _editor = editor; }

875
876
877
QTextCursor QuickFixOperation::textCursor() const
{ return _textCursor; }

878
879
880
void QuickFixOperation::setTextCursor(const QTextCursor &cursor)
{ _textCursor = cursor; }

881
882
883
884
885
886
int QuickFixOperation::selectionStart() const
{ return _textCursor.selectionStart(); }

int QuickFixOperation::selectionEnd() const
{ return _textCursor.selectionEnd(); }

887
const CPlusPlus::Token &QuickFixOperation::tokenAt(unsigned index) const
Roberto Raggi's avatar
Roberto Raggi committed
888
{ return _document->translationUnit()->tokenAt(index); }
889

890
int QuickFixOperation::startOf(unsigned index) const
891
{
892
    unsigned line, column;
Roberto Raggi's avatar
Roberto Raggi committed
893
    _document->translationUnit()->getPosition(tokenAt(index).begin(), &line, &column);
894
895
    return _textCursor.document()->findBlockByNumber(line - 1).position() + column - 1;
}
896

897
898
899
900
901
902
int QuickFixOperation::startOf(const CPlusPlus::AST *ast) const
{
    return startOf(ast->firstToken());
}

int QuickFixOperation::endOf(unsigned index) const
903
904
{
    unsigned line, column;
Roberto Raggi's avatar
Roberto Raggi committed
905
    _document->translationUnit()->getPosition(tokenAt(index).end(), &line, &column);
906
    return _textCursor.document()->findBlockByNumber(line - 1).position() + column - 1;
907
908
}

909
910
911
912
913
int QuickFixOperation::endOf(const CPlusPlus::AST *ast) const
{
    return endOf(ast->lastToken() - 1);
}

914
915
916
917
918
919
920
921
922
void QuickFixOperation::startAndEndOf(unsigned index, int *start, int *end) const
{
    unsigned line, column;
    CPlusPlus::Token token(tokenAt(index));
    _document->translationUnit()->getPosition(token.begin(), &line, &column);
    *start = _textCursor.document()->findBlockByNumber(line - 1).position() + column - 1;
    *end = *start + token.length();
}

923
bool QuickFixOperation::isCursorOn(unsigned tokenIndex) const
924
925
926
927
928
929
930
931
932
933
934
935
936
{
    QTextCursor tc = textCursor();
    int cursorBegin = tc.selectionStart();

    int start = startOf(tokenIndex);
    int end = endOf(tokenIndex);

    if (cursorBegin >= start && cursorBegin <= end)
        return true;

    return false;
}

937
bool QuickFixOperation::isCursorOn(const CPlusPlus::AST *ast) const
938
939
940
941
942
943
944
945
946
947
948
949
950
{
    QTextCursor tc = textCursor();
    int cursorBegin = tc.selectionStart();

    int start = startOf(ast);
    int end = endOf(ast);

    if (cursorBegin >= start && cursorBegin <= end)
        return true;

    return false;
}

Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
951
952
953
954
955
956
957
958
959
960
QuickFixOperation::Range QuickFixOperation::createRange(AST *ast) const
{    
    QTextCursor tc = _textCursor;
    Range r(tc);
    r.begin.setPosition(startOf(ast));
    r.end.setPosition(endOf(ast));
    return r;
}

void QuickFixOperation::reindent(const Range &range)
961
{
Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
962
963
964
    QTextCursor tc = range.begin;
    tc.setPosition(range.end.position(), QTextCursor::KeepAnchor);
    _editor->indentInsertedText(tc);
965
966
}

967
968
void QuickFixOperation::move(int start, int end, int to)
{
969
    _changeSet.move(start, end-start, to);
970
971
972
973
}

void QuickFixOperation::move(unsigned tokenIndex, int to)
{
974
975
976
    int start, end;
    startAndEndOf(tokenIndex, &start, &end);
    move(start, end, to);
977
978
979
980
981
982
983
984
985
}

void QuickFixOperation::move(const CPlusPlus::AST *ast, int to)
{
    move(startOf(ast), endOf(ast), to);
}

void QuickFixOperation::replace(int start, int end, const QString &replacement)
{
986
    _changeSet.replace(start, end-start, replacement);
987
988
989
990
}

void QuickFixOperation::replace(unsigned tokenIndex, const QString &replacement)
{
991
992
993
    int start, end;
    startAndEndOf(tokenIndex, &start, &end);
    replace(start, end, replacement);
994
995
996
997
998
999
1000
}

void QuickFixOperation::replace(const CPlusPlus::AST *ast, const QString &replacement)
{
    replace(startOf(ast), endOf(ast), replacement);
}

For faster browsing, not all history is shown. View entire blame