gdbengine.cpp 153 KB
Newer Older
1
/**************************************************************************
con's avatar
con committed
2 3 4
**
** This file is part of Qt Creator
**
5
** Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
con's avatar
con committed
6
**
7
** Contact: Nokia Corporation (qt-info@nokia.com)
con's avatar
con committed
8
**
9
** Commercial Usage
10
**
11 12 13 14
** Licensees holding valid Qt Commercial licenses may use this file in
** accordance with the Qt Commercial License Agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Nokia.
15
**
16
** GNU Lesser General Public License Usage
17
**
18 19 20 21 22 23
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
24
**
25
** If you are unsure which license is appropriate for your use, please
hjk's avatar
hjk committed
26
** contact the sales department at http://qt.nokia.com/contact.
con's avatar
con committed
27
**
28
**************************************************************************/
con's avatar
con committed
29

30 31
#define QT_NO_CAST_FROM_ASCII

con's avatar
con committed
32
#include "gdbengine.h"
33
#include "gdboptionspage.h"
34 35
#include "trkoptions.h"
#include "trkoptionspage.h"
hjk's avatar
hjk committed
36
#include "plaingdbadapter.h"
hjk's avatar
hjk committed
37
#include "trkgdbadapter.h"
38
#include "remotegdbadapter.h"
con's avatar
con committed
39

40
#include "watchutils.h"
41
#include "debuggeractions.h"
42
#include "debuggeragents.h"
con's avatar
con committed
43 44
#include "debuggerconstants.h"
#include "debuggermanager.h"
45
#include "debuggertooltip.h"
con's avatar
con committed
46 47 48 49 50 51 52 53
#include "gdbmi.h"
#include "procinterrupt.h"

#include "breakhandler.h"
#include "moduleshandler.h"
#include "registerhandler.h"
#include "stackhandler.h"
#include "watchhandler.h"
54
#include "sourcefileswindow.h"
con's avatar
con committed
55

56
#include "debuggerdialogs.h"
con's avatar
con committed
57

hjk's avatar
hjk committed
58
#include <utils/qtcassert.h>
59
#include <texteditor/itexteditor.h>
60
#include <coreplugin/icore.h>
hjk's avatar
hjk committed
61

con's avatar
con committed
62 63 64
#include <QtCore/QDebug>
#include <QtCore/QDir>
#include <QtCore/QFileInfo>
65
#include <QtCore/QMetaObject>
con's avatar
con committed
66 67
#include <QtCore/QTime>
#include <QtCore/QTimer>
68
#include <QtCore/QTextStream>
con's avatar
con committed
69 70

#include <QtGui/QAction>
71
#include <QtCore/QCoreApplication>
con's avatar
con committed
72 73 74
#include <QtGui/QLabel>
#include <QtGui/QMainWindow>
#include <QtGui/QMessageBox>
75 76
#include <QtGui/QDialogButtonBox>
#include <QtGui/QPushButton>
77
#ifdef Q_OS_WIN
78
#    include "shared/sharedlibraryinjector.h"
79
#endif
con's avatar
con committed
80

Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
81
#ifdef Q_OS_UNIX
con's avatar
con committed
82 83 84
#include <unistd.h>
#include <dlfcn.h>
#endif
hjk's avatar
hjk committed
85
#include <ctype.h>
con's avatar
con committed
86

hjk's avatar
hjk committed
87
// FIXME: temporary hack to evalute tbreak based step-over behaviour
hjk's avatar
hjk committed
88 89 90
static QString lastFile;
static int lastLine;

91 92
namespace Debugger {
namespace Internal {
con's avatar
con committed
93 94

//#define DEBUG_PENDING  1
95
//#define DEBUG_SUBITEM  1
con's avatar
con committed
96 97 98 99

#if DEBUG_PENDING
#   define PENDING_DEBUG(s) qDebug() << s
#else
Roberto Raggi's avatar
Roberto Raggi committed
100
#   define PENDING_DEBUG(s)
con's avatar
con committed
101 102
#endif

Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
103 104
#define STRINGIFY_INTERNAL(x) #x
#define STRINGIFY(x) STRINGIFY_INTERNAL(x)
105 106
#define CB(callback) &GdbEngine::callback, STRINGIFY(callback)

hjk's avatar
hjk committed
107 108 109 110 111 112 113 114 115 116 117 118
static bool stateAcceptsGdbCommands(GdbAdapterState state)
{
    return state == AdapterStarted
        || state == InferiorPreparing
        || state == InferiorPrepared
        || state == InferiorStarting
        || state == InferiorStarted
        || state == InferiorShuttingDown
        || state == InferiorShutDown
        || state == AdapterShuttingDown;
};

con's avatar
con committed
119 120 121 122 123 124
static int &currentToken()
{
    static int token = 0;
    return token;
}

125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
// reads a MI-encoded item frome the consolestream
static bool parseConsoleStream(const GdbResultRecord &record, GdbMi *contents)
{
    GdbMi output = record.data.findChild("consolestreamoutput");
    QByteArray out = output.data();

    int markerPos = out.indexOf('"') + 1; // position of 'success marker'
    if (markerPos == 0 || out.at(markerPos) == 'f') {  // 't' or 'f'
        // custom dumper produced no output
        return false;
    }

    out = out.mid(markerPos +  1);
    out = out.left(out.lastIndexOf('"'));
    // optimization: dumper output never needs real C unquoting
    out.replace('\\', "");
    out = "dummy={" + out + "}";

    contents->fromString(out);
    //qDebug() << "CONTENTS" << contents->toString(true);
    return contents->isValid();
}

static QByteArray parsePlainConsoleStream(const GdbResultRecord &record)
{
    GdbMi output = record.data.findChild("consolestreamoutput");
    QByteArray out = output.data();
    // FIXME: proper decoding needed
    if (out.endsWith("\\n"))
        out.chop(2);
    while (out.endsWith('\n') || out.endsWith(' '))
        out.chop(1);
    int pos = out.indexOf(" = ");
    return out.mid(pos + 3);
}

con's avatar
con committed
161 162 163 164 165 166
///////////////////////////////////////////////////////////////////////
//
// GdbEngine
//
///////////////////////////////////////////////////////////////////////

hjk's avatar
hjk committed
167
GdbEngine::GdbEngine(DebuggerManager *parent) :
168
#ifdef Q_OS_WIN // Do injection loading with MinGW (call loading does not work with 64bit)
169
    m_dumperInjectionLoad(true),
170
#else
171
    m_dumperInjectionLoad(false),
172
#endif
hjk's avatar
hjk committed
173
    m_manager(parent),
174
    qq(parent->engineInterface())
con's avatar
con committed
175
{
hjk's avatar
hjk committed
176
    m_gdbAdapter = 0;
177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
    QSharedPointer<TrkOptions> options(new TrkOptions);
    options->fromSettings(Core::ICore::instance()->settings());
    m_plainAdapter = new PlainGdbAdapter(this);
    m_trkAdapter = new TrkGdbAdapter(this, options);
    m_remoteAdapter = 0; // FIXME

    // Output
    connect(&m_outputCollector, SIGNAL(byteDelivery(QByteArray)),
        this, SLOT(readDebugeeOutput(QByteArray)));

    connect(this, SIGNAL(gdbOutputAvailable(int,QString)),
        m_manager, SLOT(showDebuggerOutput(int,QString)),
        Qt::QueuedConnection);
    connect(this, SIGNAL(gdbInputAvailable(int,QString)),
        m_manager, SLOT(showDebuggerInput(int,QString)),
        Qt::QueuedConnection);
    connect(this, SIGNAL(applicationOutputAvailable(QString)),
        m_manager, SLOT(showApplicationOutput(QString)),
        Qt::QueuedConnection);

    // FIXME: These trigger even if the engine is not active
    connect(theDebuggerAction(UseDebuggingHelpers), SIGNAL(valueChanged(QVariant)),
        this, SLOT(setUseDebuggingHelpers(QVariant)));
    connect(theDebuggerAction(DebugDebuggingHelpers), SIGNAL(valueChanged(QVariant)),
        this, SLOT(setDebugDebuggingHelpers(QVariant)));
    connect(theDebuggerAction(RecheckDebuggingHelpers), SIGNAL(triggered()),
        this, SLOT(recheckDebuggingHelperAvailability()));
con's avatar
con committed
204 205 206 207
}

GdbEngine::~GdbEngine()
{
hjk's avatar
hjk committed
208
    // prevent sending error messages afterwards
hjk's avatar
hjk committed
209 210
    if (m_gdbAdapter) {
        m_gdbAdapter->disconnect(this);
211
        //delete m_gdbAdapter;
hjk's avatar
hjk committed
212 213
        m_gdbAdapter = 0;
    }
214 215 216
    delete m_plainAdapter;
    delete m_trkAdapter;
    delete m_remoteAdapter;
hjk's avatar
hjk committed
217 218
}

219
void GdbEngine::connectAdapter()
con's avatar
con committed
220 221
{
    // Gdb Process interaction
hjk's avatar
hjk committed
222
    connect(m_gdbAdapter, SIGNAL(error(QProcess::ProcessError)),
223
        this, SLOT(gdbProcError(QProcess::ProcessError)));
hjk's avatar
hjk committed
224
    connect(m_gdbAdapter, SIGNAL(readyReadStandardOutput()),
225
        this, SLOT(readGdbStandardOutput()));
hjk's avatar
hjk committed
226
    connect(m_gdbAdapter, SIGNAL(readyReadStandardError()),
227
        this, SLOT(readGdbStandardError()));
hjk's avatar
hjk committed
228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252

    connect(m_gdbAdapter, SIGNAL(adapterStarted()),
        this, SLOT(handleAdapterStarted()));
    connect(m_gdbAdapter, SIGNAL(adapterStartFailed(QString)),
        this, SLOT(handleAdapterStartFailed(QString)));
    connect(m_gdbAdapter, SIGNAL(adapterShutDown()),
        this, SLOT(handleAdapterShutDown()));
    connect(m_gdbAdapter, SIGNAL(adapterShutdownFailed(QString)),
        this, SLOT(handleAdapterShutdownFailed(QString)));

    connect(m_gdbAdapter, SIGNAL(inferiorPrepared()),
        this, SLOT(handleInferiorPrepared()));
    connect(m_gdbAdapter, SIGNAL(inferiorPreparationFailed(QString)),
        this, SLOT(handleInferiorPreparationFailed(QString)));

    connect(m_gdbAdapter, SIGNAL(inferiorStarted()),
        this, SLOT(handleInferiorStarted()));
    connect(m_gdbAdapter, SIGNAL(inferiorStartFailed(QString)),
        this, SLOT(handleInferiorStartFailed(QString)));
    connect(m_gdbAdapter, SIGNAL(inferiorShutDown()),
        this, SLOT(handleInferiorShutDown()));
    connect(m_gdbAdapter, SIGNAL(inferiorShutdownFailed(QString)),
        this, SLOT(handleInferiorShutdownFailed(QString)));

    connect(m_gdbAdapter, SIGNAL(adapterCrashed()),
hjk's avatar
hjk committed
253
        m_manager, SLOT(exitDebugger()));
254
}
255

con's avatar
con committed
256

257 258 259 260 261 262 263 264 265
void GdbEngine::disconnectAdapter()
{
    // Gdb Process interaction
    disconnect(m_gdbAdapter, SIGNAL(error(QProcess::ProcessError)),
        this, SLOT(gdbProcError(QProcess::ProcessError)));
    disconnect(m_gdbAdapter, SIGNAL(readyReadStandardOutput()),
        this, SLOT(readGdbStandardOutput()));
    disconnect(m_gdbAdapter, SIGNAL(readyReadStandardError()),
        this, SLOT(readGdbStandardError()));
266

267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291
    disconnect(m_gdbAdapter, SIGNAL(adapterStarted()),
        this, SLOT(handleAdapterStarted()));
    disconnect(m_gdbAdapter, SIGNAL(adapterStartFailed(QString)),
        this, SLOT(handleAdapterStartFailed(QString)));
    disconnect(m_gdbAdapter, SIGNAL(adapterShutDown()),
        this, SLOT(handleAdapterShutDown()));
    disconnect(m_gdbAdapter, SIGNAL(adapterShutdownFailed(QString)),
        this, SLOT(handleAdapterShutdownFailed(QString)));

    disconnect(m_gdbAdapter, SIGNAL(inferiorPrepared()),
        this, SLOT(handleInferiorPrepared()));
    disconnect(m_gdbAdapter, SIGNAL(inferiorPreparationFailed(QString)),
        this, SLOT(handleInferiorPreparationFailed(QString)));

    disconnect(m_gdbAdapter, SIGNAL(inferiorStarted()),
        this, SLOT(handleInferiorStarted()));
    disconnect(m_gdbAdapter, SIGNAL(inferiorStartFailed(QString)),
        this, SLOT(handleInferiorStartFailed(QString)));
    disconnect(m_gdbAdapter, SIGNAL(inferiorShutDown()),
        this, SLOT(handleInferiorShutDown()));
    disconnect(m_gdbAdapter, SIGNAL(inferiorShutdownFailed(QString)),
        this, SLOT(handleInferiorShutdownFailed(QString)));

    disconnect(m_gdbAdapter, SIGNAL(adapterCrashed()),
        m_manager, SLOT(exitDebugger()));
con's avatar
con committed
292 293
}

294 295
void GdbEngine::initializeVariables()
{
296
    m_debuggingHelperState = DebuggingHelperUninitialized;
297
    m_gdbVersion = 100;
hjk's avatar
hjk committed
298
    m_gdbBuildVersion = -1;
299 300 301 302 303 304 305 306 307

    m_fullToShortName.clear();
    m_shortToFullName.clear();
    m_varToType.clear();

    m_modulesListOutdated = true;
    m_oldestAcceptableToken = -1;
    m_outputCodec = QTextCodec::codecForLocale();
    m_pendingRequests = 0;
hjk's avatar
hjk committed
308
    m_continuationAfterDone = 0;
309
    m_waitingForFirstBreakpointToBeHit = false;
hjk's avatar
hjk committed
310
    m_commandsToRunOnTemporaryBreak.clear();
311
    m_cookieForToken.clear();
312 313 314 315 316 317 318 319 320 321
    m_customOutputForToken.clear();

    m_pendingConsoleStreamOutput.clear();
    m_pendingTargetStreamOutput.clear();
    m_pendingLogStreamOutput.clear();

    m_inbuffer.clear();

    m_currentFunctionArgs.clear();
    m_currentFrame.clear();
322
    m_dumperHelper.clear();
323 324 325

    // FIXME: unhandled:
    //m_outputCodecState = QTextCodec::ConverterState();
326
    //m_gdbAdapter;
327 328
}

con's avatar
con committed
329 330 331
void GdbEngine::gdbProcError(QProcess::ProcessError error)
{
    QString msg;
332
    bool kill = true;
con's avatar
con committed
333 334
    switch (error) {
        case QProcess::FailedToStart:
335
            //kill = false;
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
336
            msg = tr("The Gdb process failed to start. Either the "
con's avatar
con committed
337
                "invoked program '%1' is missing, or you may have insufficient "
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
338
                "permissions to invoke the program.")
hjk's avatar
hjk committed
339
                .arg(theDebuggerStringSetting(GdbLocation));
340 341
            //emit startFailed();
            //shutdown();
con's avatar
con committed
342 343
            break;
        case QProcess::Crashed:
344
            kill = false;
con's avatar
con committed
345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366
            msg = tr("The Gdb process crashed some time after starting "
                "successfully.");
            break;
        case QProcess::Timedout:
            msg = tr("The last waitFor...() function timed out. "
                "The state of QProcess is unchanged, and you can try calling "
                "waitFor...() again.");
            break;
        case QProcess::WriteError:
            msg = tr("An error occurred when attempting to write "
                "to the Gdb process. For example, the process may not be running, "
                "or it may have closed its input channel.");
            break;
        case QProcess::ReadError:
            msg = tr("An error occurred when attempting to read from "
                "the Gdb process. For example, the process may not be running.");
            break;
        default:
            msg = tr("An unknown error in the Gdb process occurred. "
                "This is the default return value of error().");
    }

hjk's avatar
hjk committed
367
    showStatusMessage(msg);
368
    showMessageBox(QMessageBox::Critical, tr("Error"), msg);
con's avatar
con committed
369
    // act as if it was closed by the core
370
    //if (kill)
hjk's avatar
hjk committed
371
        m_manager->exitDebugger();
con's avatar
con committed
372 373 374 375 376 377
}

#if 0
static void dump(const char *first, const char *middle, const QString & to)
{
    QByteArray ba(first, middle - first);
378
    Q_UNUSED(to)
con's avatar
con committed
379 380 381 382 383 384 385 386 387 388 389
    // note that qDebug cuts off output after a certain size... (bug?)
    qDebug("\n>>>>> %s\n%s\n====\n%s\n<<<<<\n",
        qPrintable(currentTime()),
        qPrintable(QString(ba).trimmed()),
        qPrintable(to.trimmed()));
    //qDebug() << "";
    //qDebug() << qPrintable(currentTime())
    //    << " Reading response:  " << QString(ba).trimmed() << "\n";
}
#endif

390 391 392 393 394 395
void GdbEngine::readDebugeeOutput(const QByteArray &data)
{
    emit applicationOutputAvailable(m_outputCodec->toUnicode(
            data.constData(), data.length(), &m_outputCodecState));
}

hjk's avatar
hjk committed
396 397
void GdbEngine::debugMessage(const QString &msg)
{
398
    emit gdbOutputAvailable(LogDebug, msg);
hjk's avatar
hjk committed
399 400
}

401
void GdbEngine::handleResponse(const QByteArray &buff)
con's avatar
con committed
402 403 404
{
    static QTime lastTime;

405
    if (theDebuggerBoolSetting(LogTimeStamps))
406
        emit gdbOutputAvailable(LogTime, currentTime());
407
    emit gdbOutputAvailable(LogOutput, QString::fromLocal8Bit(buff, buff.length()));
con's avatar
con committed
408 409 410 411 412

#if 0
    qDebug() // << "#### start response handling #### "
        << currentTime()
        << lastTime.msecsTo(QTime::currentTime()) << "ms,"
413 414
        << "buf:" << buff.left(1500) << "..."
        //<< "buf:" << buff
415
        << "size:" << buff.size();
con's avatar
con committed
416
#else
417
    //qDebug() << "buf:" << buff;
con's avatar
con committed
418 419 420 421
#endif

    lastTime = QTime::currentTime();

422 423
    if (buff.isEmpty() || buff == "(gdb) ")
        return;
con's avatar
con committed
424

425 426 427
    const char *from = buff.constData();
    const char *to = from + buff.size();
    const char *inner;
con's avatar
con committed
428

429 430 431 432
    int token = -1;
    // token is a sequence of numbers
    for (inner = from; inner != to; ++inner)
        if (*inner < '0' || *inner > '9')
con's avatar
con committed
433
            break;
434 435 436
    if (from != inner) {
        token = QByteArray(from, inner - from).toInt();
        from = inner;
437
        //qDebug() << "found token" << token;
438
    }
con's avatar
con committed
439

440 441 442 443 444 445 446 447 448 449 450 451 452 453 454
    // next char decides kind of record
    const char c = *from++;
    //qDebug() << "CODE:" << c;
    switch (c) {
        case '*':
        case '+':
        case '=': {
            QByteArray asyncClass;
            for (; from != to; ++from) {
                const char c = *from;
                if (!isNameChar(c))
                    break;
                asyncClass += *from;
            }
            //qDebug() << "ASYNCCLASS" << asyncClass;
con's avatar
con committed
455

456 457 458
            GdbMi record;
            while (from != to) {
                GdbMi data;
hjk's avatar
hjk committed
459
                if (*from != ',') {
hjk's avatar
hjk committed
460 461
                    // happens on archer where we get 
                    // 23^running <NL> *running,thread-id="all" <NL> (gdb) 
462
                    record.m_type = GdbMi::Tuple;
hjk's avatar
hjk committed
463 464 465 466 467
                    break;
                }
                ++from; // skip ','
                data.parseResultOrValue(from, to);
                if (data.isValid()) {
468
                    //qDebug() << "parsed response:" << data.toString();
hjk's avatar
hjk committed
469 470
                    record.m_children += data;
                    record.m_type = GdbMi::Tuple;
con's avatar
con committed
471 472
                }
            }
473 474 475 476
            if (asyncClass == "stopped") {
                handleAsyncOutput(record);
            } else if (asyncClass == "running") {
                // Archer has 'thread-id="all"' here
477 478 479 480
            } else if (asyncClass == "library-loaded") {
                // Archer has 'id="/usr/lib/libdrm.so.2",
                // target-name="/usr/lib/libdrm.so.2",
                // host-name="/usr/lib/libdrm.so.2",
481
                // symbols-loaded="0"
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
482
                QByteArray id = record.findChild("id").data();
483
                if (!id.isEmpty())
hjk's avatar
hjk committed
484
                    showStatusMessage(tr("Library %1 loaded.").arg(_(id)));
hjk's avatar
hjk committed
485 486 487 488
            } else if (asyncClass == "library-unloaded") {
                // Archer has 'id="/usr/lib/libdrm.so.2",
                // target-name="/usr/lib/libdrm.so.2",
                // host-name="/usr/lib/libdrm.so.2"
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
489
                QByteArray id = record.findChild("id").data();
hjk's avatar
hjk committed
490
                showStatusMessage(tr("Library %1 unloaded.").arg(_(id)));
491 492
            } else if (asyncClass == "thread-group-created") {
                // Archer has "{id="28902"}" 
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
493
                QByteArray id = record.findChild("id").data();
hjk's avatar
hjk committed
494
                showStatusMessage(tr("Thread group %1 created.").arg(_(id)));
495 496
            } else if (asyncClass == "thread-created") {
                //"{id="1",group-id="28902"}" 
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
497
                QByteArray id = record.findChild("id").data();
hjk's avatar
hjk committed
498
                showStatusMessage(tr("Thread %1 created.").arg(_(id)));
499 500
            } else if (asyncClass == "thread-group-exited") {
                // Archer has "{id="28902"}" 
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
501
                QByteArray id = record.findChild("id").data();
hjk's avatar
hjk committed
502
                showStatusMessage(tr("Thread group %1 exited.").arg(_(id)));
503 504
            } else if (asyncClass == "thread-exited") {
                //"{id="1",group-id="28902"}" 
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
505 506
                QByteArray id = record.findChild("id").data();
                QByteArray groupid = record.findChild("group-id").data();
hjk's avatar
hjk committed
507
                showStatusMessage(tr("Thread %1 in group %2 exited.")
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
508
                    .arg(_(id)).arg(_(groupid)));
hjk's avatar
hjk committed
509
            } else if (asyncClass == "thread-selected") {
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
510
                QByteArray id = record.findChild("id").data();
hjk's avatar
hjk committed
511
                showStatusMessage(tr("Thread %1 selected.").arg(_(id)));
hjk's avatar
hjk committed
512
                //"{id="2"}" 
513
            #if defined(Q_OS_MAC)
514 515 516 517 518 519 520 521 522 523 524
            } else if (asyncClass == "shlibs-updated") {
                // MAC announces updated libs
            } else if (asyncClass == "shlibs-added") {
                // MAC announces added libs
                // {shlib-info={num="2", name="libmathCommon.A_debug.dylib",
                // kind="-", dyld-addr="0x7f000", reason="dyld", requested-state="Y",
                // state="Y", path="/usr/lib/system/libmathCommon.A_debug.dylib",
                // description="/usr/lib/system/libmathCommon.A_debug.dylib",
                // loaded_addr="0x7f000", slide="0x7f000", prefix=""}}
            #endif
            } else {
525
                qDebug() << "IGNORED ASYNC OUTPUT"
526
                    << asyncClass << record.toString();
527
            }
528 529
            break;
        }
530

531
        case '~': {
hjk's avatar
hjk committed
532
            static QRegExp re(_("New .hread 0x[0-9a-f]* \\(LWP ([0-9]*)\\)"));
533 534
            QByteArray data = GdbMi::parseCString(from, to);
            m_pendingConsoleStreamOutput += data;
hjk's avatar
hjk committed
535 536 537
            if (re.indexIn(_(data)) != -1)
                maybeHandleInferiorPidChanged(re.cap(1));
            if (data.startsWith("Reading symbols from "))
hjk's avatar
hjk committed
538
                showStatusMessage(tr("Reading %1...").arg(_(data.mid(21))));
539 540
            break;
        }
541

542
        case '@': {
543 544
            QByteArray data = GdbMi::parseCString(from, to);
            m_pendingTargetStreamOutput += data;
545
            break;
con's avatar
con committed
546 547
        }

548 549 550 551 552 553
        case '&': {
            QByteArray data = GdbMi::parseCString(from, to);
            m_pendingLogStreamOutput += data;
            // On Windows, the contents seem to depend on the debugger
            // version and/or OS version used.
            if (data.startsWith("warning:"))
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
554
                qq->showApplicationOutput(_(data.mid(9))); // cut "warning: "
con's avatar
con committed
555 556 557
            break;
        }

558 559
        case '^': {
            GdbResultRecord record;
con's avatar
con committed
560

561
            record.token = token;
con's avatar
con committed
562

563 564 565
            for (inner = from; inner != to; ++inner)
                if (*inner < 'a' || *inner > 'z')
                    break;
con's avatar
con committed
566

Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
567
            QByteArray resultClass = QByteArray::fromRawData(from, inner - from);
568 569 570 571 572 573 574 575 576 577 578 579
            if (resultClass == "done")
                record.resultClass = GdbResultDone;
            else if (resultClass == "running")
                record.resultClass = GdbResultRunning;
            else if (resultClass == "connected")
                record.resultClass = GdbResultConnected;
            else if (resultClass == "error")
                record.resultClass = GdbResultError;
            else if (resultClass == "exit")
                record.resultClass = GdbResultExit;
            else
                record.resultClass = GdbResultUnknown;
con's avatar
con committed
580

581 582
            from = inner;
            if (from != to) {
hjk's avatar
hjk committed
583 584 585 586 587 588 589 590 591
                if (*from == ',') {
                    ++from;
                    record.data.parseTuple_helper(from, to);
                    record.data.m_type = GdbMi::Tuple;
                    record.data.m_name = "data";
                } else {
                    // Archer has this
                    record.data.m_type = GdbMi::Tuple;
                    record.data.m_name = "data";
con's avatar
con committed
592 593
                }
            }
594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618

            //qDebug() << "\nLOG STREAM:" + m_pendingLogStreamOutput;
            //qDebug() << "\nTARGET STREAM:" + m_pendingTargetStreamOutput;
            //qDebug() << "\nCONSOLE STREAM:" + m_pendingConsoleStreamOutput;
            record.data.setStreamOutput("logstreamoutput",
                m_pendingLogStreamOutput);
            record.data.setStreamOutput("targetstreamoutput",
                m_pendingTargetStreamOutput);
            record.data.setStreamOutput("consolestreamoutput",
                m_pendingConsoleStreamOutput);
            QByteArray custom = m_customOutputForToken[token];
            if (!custom.isEmpty())
                record.data.setStreamOutput("customvaluecontents",
                    '{' + custom + '}');
            //m_customOutputForToken.remove(token);
            m_pendingLogStreamOutput.clear();
            m_pendingTargetStreamOutput.clear();
            m_pendingConsoleStreamOutput.clear();

            handleResultRecord(record);
            break;
        }
        default: {
            qDebug() << "UNKNOWN RESPONSE TYPE" << c;
            break;
con's avatar
con committed
619 620 621 622 623 624
        }
    }
}

void GdbEngine::readGdbStandardError()
{
hjk's avatar
hjk committed
625
    qWarning() << "Unexpected gdb stderr:" << m_gdbAdapter->readAllStandardError();
con's avatar
con committed
626 627 628 629
}

void GdbEngine::readGdbStandardOutput()
{
630 631
    int newstart = 0;
    int scan = m_inbuffer.size();
con's avatar
con committed
632

hjk's avatar
hjk committed
633
    m_inbuffer.append(m_gdbAdapter->readAllStandardOutput());
con's avatar
con committed
634

635 636
    while (newstart < m_inbuffer.size()) {
        int start = newstart;
637
        int end = m_inbuffer.indexOf('\n', scan);
638 639 640 641 642
        if (end < 0) {
            m_inbuffer.remove(0, start);
            return;
        }
        newstart = end + 1;
643
        scan = newstart;
644 645
        if (end == start)
            continue;
646
        #if defined(Q_OS_WIN)
647 648 649 650 651
        if (m_inbuffer.at(end - 1) == '\r') {
            --end;
            if (end == start)
                continue;
        }
652
        #endif
653
        handleResponse(QByteArray::fromRawData(m_inbuffer.constData() + start, end - start));
con's avatar
con committed
654
    }
655
    m_inbuffer.clear();
con's avatar
con committed
656 657 658 659
}

void GdbEngine::interruptInferior()
{
660
//    debugMessage(_("GDBENGINE INTERRUPT INFERIOR: %1").arg(m_gdbAdapter->state()));
hjk's avatar
hjk committed
661
    qq->notifyInferiorStopRequested();
662

663
    if (m_gdbAdapter->state() == AdapterNotRunning) {
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
664
        debugMessage(_("TRYING TO INTERRUPT INFERIOR WITHOUT RUNNING GDB"));
hjk's avatar
hjk committed
665
        qq->notifyInferiorExited();
con's avatar
con committed
666
        return;
hjk's avatar
hjk committed
667
    }
con's avatar
con committed
668

hjk's avatar
hjk committed
669
    m_gdbAdapter->interruptInferior();
con's avatar
con committed
670 671 672 673
}

void GdbEngine::maybeHandleInferiorPidChanged(const QString &pid0)
{
674
    const qint64 pid = pid0.toLongLong();
con's avatar
con committed
675
    if (pid == 0) {
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
676
        debugMessage(_("Cannot parse PID from %1").arg(pid0));
con's avatar
con committed
677 678
        return;
    }
hjk's avatar
hjk committed
679
    if (pid == inferiorPid())
con's avatar
con committed
680
        return;
681 682
    debugMessage(_("FOUND PID %1").arg(pid));    

Roberto Raggi's avatar
Roberto Raggi committed
683
    qq->notifyInferiorPidChanged(pid);
684 685
    if (m_dumperInjectionLoad)
        tryLoadDebuggingHelpers();
con's avatar
con committed
686 687
}

hjk's avatar
hjk committed
688 689
void GdbEngine::postCommand(const QString &command, AdapterCallback callback,
                            const char *callbackName, const QVariant &cookie)
690 691 692 693 694 695 696
{
    postCommand(command, NoFlags, callback, callbackName, cookie);
}

void GdbEngine::postCommand(const QString &command, GdbCommandFlags flags,
                            AdapterCallback callback,
                            const char *callbackName, const QVariant &cookie)
hjk's avatar
hjk committed
697 698 699
{
    GdbCommand cmd;
    cmd.command = command;
700
    cmd.flags = flags;
hjk's avatar
hjk committed
701 702 703 704 705 706
    cmd.adapterCallback = callback;
    cmd.callbackName = callbackName;
    cmd.cookie = cookie;
    postCommandHelper(cmd);
}

707
void GdbEngine::postCommand(const QString &command, GdbCommandCallback callback,
708 709
                            const char *callbackName, const QVariant &cookie)
{
710
    postCommand(command, NoFlags, callback, callbackName, cookie);
711 712
}

713
void GdbEngine::postCommand(const QString &command, GdbCommandFlags flags,
714 715
                            GdbCommandCallback callback, const char *callbackName,
                            const QVariant &cookie)
hjk's avatar
hjk committed
716 717 718 719 720 721 722 723 724 725 726
{
    GdbCommand cmd;
    cmd.command = command;
    cmd.flags = flags;
    cmd.callback = callback;
    cmd.callbackName = callbackName;
    cmd.cookie = cookie;
    postCommandHelper(cmd);
}

void GdbEngine::postCommandHelper(const GdbCommand &cmd)
con's avatar
con committed
727
{
hjk's avatar
hjk committed
728 729
    if (!stateAcceptsGdbCommands(m_gdbAdapter->state())) {
        PENDING_DEBUG(_("NO GDB PROCESS RUNNING, CMD IGNORED: ") + cmd.command);
hjk's avatar
hjk committed
730
        debugMessage(_("NO GDB PROCESS RUNNING, CMD IGNORED: ") + cmd.command);
con's avatar
con committed
731 732 733
        return;
    }

hjk's avatar
hjk committed
734
    if (cmd.flags & RebuildModel) {
con's avatar
con committed
735
        ++m_pendingRequests;
hjk's avatar
hjk committed
736
        PENDING_DEBUG("   CALLBACK" << cmd.callbackName
hjk's avatar
hjk committed
737 738
            << "INCREMENTS PENDING TO:" << m_pendingRequests << cmd.command
            << m_gdbAdapter->state());
con's avatar
con committed
739
    } else {
hjk's avatar
hjk committed
740
        PENDING_DEBUG("   UNKNOWN CALLBACK" << cmd.callbackName
hjk's avatar
hjk committed
741 742
            << "LEAVES PENDING AT:" << m_pendingRequests << cmd.command
            << m_gdbAdapter->state());
con's avatar
con committed
743 744
    }

hjk's avatar
hjk committed
745
    if ((cmd.flags & NeedsStop) && status() != DebuggerInferiorStopped
hjk's avatar
hjk committed
746
            && status() != DebuggerProcessStartingUp) {
hjk's avatar
hjk committed
747
        // queue the commands that we cannot send at once
hjk's avatar
hjk committed
748 749 750
        QTC_ASSERT(status() == DebuggerInferiorRunning,
            qDebug() << "STATUS:" << status());
        showStatusMessage(tr("Stopping temporarily."));
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
751
        debugMessage(_("QUEUING COMMAND ") + cmd.command);
hjk's avatar
hjk committed
752 753
        m_commandsToRunOnTemporaryBreak.append(cmd);
        interruptInferior();
hjk's avatar
hjk committed
754
    } else if (!cmd.command.isEmpty()) {
755
        flushCommand(cmd);
con's avatar
con committed
756 757 758
    }
}

hjk's avatar
hjk committed
759
void GdbEngine::flushCommand(const GdbCommand &cmd0)
760
{
hjk's avatar
hjk committed
761
    GdbCommand cmd = cmd0;
762
    if (m_gdbAdapter->state() == AdapterNotRunning) {
763 764 765 766 767
        emit gdbInputAvailable(LogInput, cmd.command);
        debugMessage(_("GDB PROCESS NOT RUNNING, PLAIN CMD IGNORED: ") + cmd.command);
        return;
    }

768
    ++currentToken();
769
    cmd.postTime = QTime::currentTime();
770 771
    m_cookieForToken[currentToken()] = cmd;
    cmd.command = QString::number(currentToken()) + cmd.command;
772
    if (cmd.flags & EmbedToken)
773
        cmd.command = cmd.command.arg(currentToken());
774
    emit gdbInputAvailable(LogInput, cmd.command);
775 776

    m_gdbAdapter->write(cmd.command.toLatin1() + "\r\n");
777 778
}

con's avatar
con committed
779 780
void GdbEngine::handleResultRecord(const GdbResultRecord &record)
{
781 782
    //qDebug() << "TOKEN:" << record.token
    //    << " ACCEPTABLE:" << m_oldestAcceptableToken;
con's avatar
con committed
783 784 785 786 787 788 789
    //qDebug() << "";
    //qDebug() << "\nRESULT" << record.token << record.toString();

    int token = record.token;
    if (token == -1)
        return;

790 791 792 793 794 795 796 797 798
    if (!m_cookieForToken.contains(token)) {
        // In theory this should not happen, in practice it does.
        debugMessage(_("COOKIE FOR TOKEN %1 ALREADY EATEN. "
            "TWO RESPONSES FOR ONE COMMAND?").arg(token));
        // handle a case known to occur on Linux/gdb 6.8 when debugging moc
        // with helpers enabled. In this case we get a second response with
        // msg="Cannot find new threads: generic error"
        if (record.resultClass == GdbResultError) {
            QByteArray msg = record.data.findChild("msg").data();
799 800
            showMessageBox(QMessageBox::Critical,
                tr("Executable failed"), QString::fromLocal8Bit(msg));
hjk's avatar
hjk committed
801
            showStatusMessage(tr("Process failed to start."));
802 803 804 805 806 807 808
            exitDebugger();
            //qq->notifyInferiorStopped();
            //qq->notifyInferiorExited();
        }
        return;
    }

809
    GdbCommand cmd = m_cookieForToken.take(token);
810 811 812 813 814
    if (theDebuggerBoolSetting(LogTimeStamps)) {
        emit gdbOutputAvailable(LogTime, _("Response time: %1: %2 s")
            .arg(cmd.command)
            .arg(cmd.postTime.msecsTo(QTime::currentTime()) / 1000.));
    }
con's avatar
con committed
815

816
    if (record.token < m_oldestAcceptableToken && (cmd.flags & Discardable)) {
817
        //qDebug() << "### SKIPPING OLD RESULT" << record.toString();
818
        //showMessageBox(QMessageBox::Information(tr("Skipped"), "xxx"));
con's avatar
con committed
819 820 821 822
        return;
    }

#if 0
823
    qDebug() << "# handleOutput,"
hjk's avatar
hjk committed
824
        << "cmd name:" << cmd.callbackName
825
        << " cmd synchronized:" << cmd.synchronized
con's avatar
con committed
826 827 828 829 830
        << "\n record: " << record.toString();
#endif

    // << "\n data: " << record.data.toString(true);

831
    if (cmd.callback)
hjk's avatar
hjk committed
832 833 834
        (this->*cmd.callback)(record, cmd.cookie);
    if (cmd.adapterCallback)
        (m_gdbAdapter->*cmd.adapterCallback)(record, cmd.cookie);
con's avatar
con committed
835

836
    if (cmd.flags & RebuildModel) {
con's avatar
con committed
837
        --m_pendingRequests;
hjk's avatar
hjk committed
838
        PENDING_DEBUG("   TYPE " << cmd.callbackName << " DECREMENTS PENDING TO: "
con's avatar
con committed
839
            << m_pendingRequests << cmd.command);
840
        if (m_pendingRequests <= 0) {
hjk's avatar
hjk committed
841 842
            PENDING_DEBUG("\n\n ....  AND TRIGGERS MODEL UPDATE\n");
            rebuildModel();
843
        }
con's avatar
con committed
844
    } else {
hjk's avatar
hjk committed
845
        PENDING_DEBUG("   UNKNOWN TYPE " << cmd.callbackName << " LEAVES PENDING AT: "
con's avatar
con committed
846 847
            << m_pendingRequests << cmd.command);
    }
848

849 850
    // Continue only if there are no commands wire anymore, so this will
    // be fully synchroneous.
851 852 853 854
    // This is somewhat inefficient, as it makes the last command synchronous.
    // An optimization would be requesting the continue immediately when the
    // event loop is entered, and let individual commands have a flag to suppress
    // that behavior.
hjk's avatar
hjk committed
855 856 857 858 859 860 861
    if (m_continuationAfterDone && m_cookieForToken.isEmpty()) {
        Continuation cont = m_continuationAfterDone;
        m_continuationAfterDone = 0;
        (this->*cont)();
        //showStatusMessage(tr("Continuing after temporary stop."));
    } else {
        PENDING_DEBUG("MISSING TOKENS: " << m_cookieForToken.keys());
862
    }
con's avatar
con committed
863 864 865 866
}

void GdbEngine::executeDebuggerCommand(const QString &command)
{
867
    if (m_gdbAdapter->state() == AdapterNotRunning) {
868
        debugMessage(_("GDB PROCESS NOT RUNNING, PLAIN CMD IGNORED: ") + command);
con's avatar
con committed
869 870 871
        return;
    }

hjk's avatar
hjk committed
872
    m_gdbAdapter->write(command.toLatin1() + "\r\n");
con's avatar
con committed
873 874
}

875
void GdbEngine::handleTargetCore(const GdbResultRecord &, const QVariant &)
876 877
{
    qq->notifyInferiorStopped();
hjk's avatar
hjk committed
878 879
    showStatusMessage(tr("Core file loaded."));
    m_manager->resetLocation();
880
    tryLoadDebuggingHelpers();
881 882
    qq->stackHandler()->setCurrentIndex(0);
    updateLocals(); // Quick shot
883
    reloadStack();
884
    if (supportsThreads())
885
        postCommand(_("-thread-list-ids"), WatchUpdate, CB(handleStackListThreads), 0);
886
    qq->reloadRegisters();
887 888
}

889
void GdbEngine::handleQuerySources(const GdbResultRecord &record, const QVariant &)
con's avatar
con committed
890 891
{
    if (record.resultClass == GdbResultDone) {
892
        QMap<QString, QString> oldShortToFull = m_shortToFullName;
con's avatar
con committed
893 894 895 896 897 898
        m_shortToFullName.clear();
        m_fullToShortName.clear();
        // "^done,files=[{file="../../../../bin/gdbmacros/gdbmacros.cpp",
        // fullname="/data5/dev/ide/main/bin/gdbmacros/gdbmacros.cpp"},
        GdbMi files = record.data.findChild("files");
        foreach (const GdbMi &item, files.children()) {
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
899
            QString fileName = QString::fromLocal8Bit(item.findChild("file").data());
con's avatar
con committed
900
            GdbMi fullName = item.findChild("fullname");
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
901
            QString full = QString::fromLocal8Bit(fullName.data());
con's avatar
con committed
902 903 904 905
            #ifdef Q_OS_WIN
            full = QDir::cleanPath(full);
            #endif
            if (fullName.isValid() && QFileInfo(full).isReadable()) {
906
                //qDebug() << "STORING 2:" << fileName << full;
con's avatar
con committed
907 908 909 910
                m_shortToFullName[fileName] = full;
                m_fullToShortName[full] = fileName;
            }
        }
911 912
        if (m_shortToFullName != oldShortToFull)
            qq->sourceFileWindow()->setSourceFiles(m_shortToFullName);
con's avatar
con committed
913 914 915
    }
}

916
void GdbEngine::handleInfoThreads(const GdbResultRecord &record, const QVariant &)
917
{
918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934
    if (record.resultClass != GdbResultDone)
        return;
    // FIXME: use something more robust
    // WIN:     [New thread 3380.0x2bc]
    //          * 3 Thread 2312.0x4d0  0x7c91120f in ?? ()
    // LINUX:   * 1 Thread 0x7f466273c6f0 (LWP 21455)  0x0000000000404542 in ...
    const QString data = _(record.data.findChild("consolestreamoutput").data());
    if (data.isEmpty())
        return;
    // check "[New thread 3380.0x2bc]"
    if (data.startsWith(QLatin1Char('['))) {
        QRegExp ren(_("^\\[New thread (\\d+)\\.0x.*"));
        Q_ASSERT(ren.isValid());
        if (ren.indexIn(data) != -1) {
            maybeHandleInferiorPidChanged(ren.cap(1));
            return;
        }
935
    }
936 937 938 939 940
    // check "* 3 Thread ..."
    QRegExp re(_("^\\*? +\\d+ +[Tt]hread (\\d+)\\.0x.* in"));
    Q_ASSERT(re.isValid());
    if (re.indexIn(data) != -1)
        maybeHandleInferiorPidChanged(re.cap(1));
941 942
}

943
void GdbEngine::handleInfoProc(const GdbResultRecord &record, const QVariant &)
con's avatar
con committed
944 945
{
    if (record.resultClass == GdbResultDone) {
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
946
        #ifdef Q_OS_MAC
con's avatar
con committed
947
        //^done,process-id="85075"
Oswald Buddenhagen's avatar
nicer  
Oswald Buddenhagen committed
948
        maybeHandleInferiorPidChanged(_(record.data.findChild("process-id").data()));
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
949
        #else
con's avatar
con committed
950
        // FIXME: use something more robust
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
951 952
        QRegExp re(__("process (\\d+)"));
        QString data = __(record.data.findChild("consolestreamoutput").data());
con's avatar
con committed
953 954 955 956 957 958
        if (re.indexIn(data) != -1)
            maybeHandleInferiorPidChanged(re.cap(1));
        #endif
    }
}

959
void GdbEngine::handleInfoShared(const GdbResultRecord &record, const QVariant &cookie)
con's avatar
con committed
960 961 962
{
    if (record.resultClass == GdbResultDone) {
        // let the modules handler do the parsing
963
        handleModulesList(record, cookie);
con's avatar
con committed
964 965 966
    }
}

967
#if 0
con's avatar
con committed
968 969 970 971 972 973 974 975 976 977
void GdbEngine::handleExecJumpToLine(const GdbResultRecord &record)
{
    // FIXME: remove this special case as soon as 'jump'
    // is supported by MI
    // "&"jump /home/apoenitz/dev/work/test1/test1.cpp:242"
    // ~"Continuing at 0x4058f3."
    // ~"run1 (argc=1, argv=0x7fffb213a478) at test1.cpp:242"
    // ~"242\t x *= 2;"
    //109^done"
    qq->notifyInferiorStopped();
hjk's avatar
hjk committed
978
    showStatusMessage(tr("Jumped. Stopped."));
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
979
    QByteArray output = record.data.findChild("logstreamoutput").data();
980
    if (output.isEmpty())
con's avatar
con committed
981
        return;
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
982 983 984 985 986 987
    int idx1 = output.indexOf(' ') + 1;
    if (idx1 > 0) {
        int idx2 = output.indexOf(':', idx1);
        if (idx2 > 0) {
            QString file = QString::fromLocal8Bit(output.mid(idx1, idx2 - idx1));
            int line = output.mid(idx2 + 1).toInt();
hjk's avatar
hjk committed
988
            gotoLocation(file, line, true);
Oswald Buddenhagen's avatar
Oswald Buddenhagen committed
989 990
        }
    }
con's avatar
con committed
991
}
992
#endif
con's avatar
con committed
993

994
void GdbEngine::handleExecRunToFunction(const GdbResultRecord &record, const QVariant &)
con's avatar
con committed
995 996 997 998 999 1000 1001 1002
{
    // FIXME: remove this special case as soon as there's a real
    // reason given when the temporary breakpoint is hit.
    // reight now we get:
    // 14*stopped,thread-id="1",frame={addr="0x0000000000403ce4",
    // func="foo",args=[{name="str",value="@0x7fff0f450460"}],
    // file="main.cpp",fullname="/tmp/g/main.cpp",line="37"}
    qq->notifyInferiorStopped();
hjk's avatar
hjk committed
1003
    showStatusMessage(tr("Run to Function finished. Stopped."));
con's avatar
con committed
1004
    GdbMi frame = record.data.findChild("frame");
1005 1006 1007 1008
    StackFrame f;
    f.file = QString::fromLocal8Bit(frame.findChild("fullname").data());
    f.line = frame.findChild("line").data().toInt();
    f.address = _(frame.findChild("addr").data());
hjk's avatar
hjk committed