cppquickfix.cpp 40.4 KB
Newer Older
1
2
3
4
/**************************************************************************
**
** This file is part of Qt Creator
**
hjk's avatar
hjk committed
5
** Copyright (c) 2010 Nokia Corporation and/or its subsidiary(-ies).
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
**
** Contact: Nokia Corporation (qt-info@nokia.com)
**
** Commercial Usage
**
** Licensees holding valid Qt Commercial licenses may use this file in
** accordance with the Qt Commercial License Agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Nokia.
**
** GNU Lesser General Public License Usage
**
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file.  Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** If you are unsure which license is appropriate for your use, please
** contact the sales department at http://qt.nokia.com/contact.
**
**************************************************************************/

#include "cppquickfix.h"
#include "cppeditor.h"
32
33

#include <cplusplus/CppDocument.h>
34
#include <cplusplus/ResolveExpression.h>
35

36
#include <TranslationUnit.h>
37
38
#include <ASTVisitor.h>
#include <AST.h>
39
40
#include <ASTPatternBuilder.h>
#include <ASTMatcher.h>
41
#include <Token.h>
42
43
44
45
46
47
#include <Type.h>
#include <CoreTypes.h>
#include <Symbol.h>
#include <Symbols.h>
#include <Name.h>
#include <Literals.h>
48

49
#include <cpptools/cpptoolsconstants.h>
50
#include <cpptools/cppmodelmanagerinterface.h>
51
52

#include <QtGui/QTextBlock>
53
54
55
56

using namespace CppEditor::Internal;
using namespace CPlusPlus;

57
58
namespace {

59
60
61
62
63
64
65
66
67
class ASTPath: public ASTVisitor
{
    Document::Ptr _doc;
    unsigned _line;
    unsigned _column;
    QList<AST *> _nodes;

public:
    ASTPath(Document::Ptr doc)
Roberto Raggi's avatar
Roberto Raggi committed
68
69
70
        : ASTVisitor(doc->translationUnit()),
          _doc(doc), _line(0), _column(0)
    {}
71
72
73
74
75
76
77
78
79
80

    QList<AST *> operator()(const QTextCursor &cursor)
    {
        _nodes.clear();
        _line = cursor.blockNumber() + 1;
        _column = cursor.columnNumber() + 1;
        accept(_doc->translationUnit()->ast());
        return _nodes;
    }

81
82
#if 0
    // Useful for debugging:
83
84
85
86
87
88
    static void dump(const QList<AST *> nodes)
    {
        qDebug() << "ASTPath dump," << nodes.size() << "nodes:";
        for (int i = 0; i < nodes.size(); ++i)
            qDebug() << qPrintable(QString(i + 1, QLatin1Char('-'))) << typeid(*nodes.at(i)).name();
    }
89
#endif
90

91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
protected:
    virtual bool preVisit(AST *ast)
    {
        unsigned firstToken = ast->firstToken();
        unsigned lastToken = ast->lastToken();

        if (firstToken > 0 && lastToken > firstToken) {
            unsigned startLine, startColumn;
            getTokenStartPosition(firstToken, &startLine, &startColumn);

            if (_line > startLine || (_line == startLine && _column >= startColumn)) {

                unsigned endLine, endColumn;
                getTokenEndPosition(lastToken - 1, &endLine, &endColumn);

106
                if (_line < endLine || (_line == endLine && _column <= endColumn)) {
107
108
109
110
111
112
113
114
115
116
                    _nodes.append(ast);
                    return true;
                }
            }
        }

        return false;
    }
};

117
118
/*
    Rewrite
119
120
121
    a op b -> !(a invop b)
    (a op b) -> !(a invop b)
    !(a op b) -> (a invob b)
122
123
124
125
126
*/
class UseInverseOp: public QuickFixOperation
{
public:
    UseInverseOp()
127
        : binary(0), nested(0), negation(0)
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
    {}

    virtual QString description() const
    {
        return QLatin1String("Rewrite using ") + replacement; // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        int index = path.size() - 1;
        binary = path.at(index)->asBinaryExpression();
        if (! binary)
            return -1;
        if (! isCursorOn(binary->binary_op_token))
            return -1;

        CPlusPlus::Kind invertToken;
        switch (tokenAt(binary->binary_op_token).kind()) {
        case T_LESS_EQUAL:
            invertToken = T_GREATER;
            break;
        case T_LESS:
            invertToken = T_GREATER_EQUAL;
            break;
        case T_GREATER:
            invertToken = T_LESS_EQUAL;
            break;
        case T_GREATER_EQUAL:
            invertToken = T_LESS;
            break;
        case T_EQUAL_EQUAL:
            invertToken = T_EXCLAIM_EQUAL;
            break;
        case T_EXCLAIM_EQUAL:
            invertToken = T_EQUAL_EQUAL;
            break;
        default:
            return -1;
        }

        CPlusPlus::Token tok;
        tok.f.kind = invertToken;
        replacement = QLatin1String(tok.spell());
171
172
173
174
175
176
177
178
179
180
181
182

        // check for enclosing nested expression
        if (index - 1 >= 0)
            nested = path[index - 1]->asNestedExpression();

        // check for ! before parentheses
        if (nested && index - 2 >= 0) {
            negation = path[index - 2]->asUnaryExpression();
            if (negation && ! tokenAt(negation->unary_op_token).is(T_EXCLAIM))
                negation = 0;
        }

183
184
185
186
187
        return index;
    }

    virtual void createChangeSet()
    {
188
189
190
191
192
193
194
195
196
        if (negation) {
            // can't remove parentheses since that might break precedence
            remove(negation->unary_op_token);
        } else if (nested) {
            insert(startOf(nested), "!");
        } else {
            insert(startOf(binary), "!(");
            insert(endOf(binary), ")");
        }
197
198
199
200
201
        replace(binary->binary_op_token, replacement);
    }

private:
    BinaryExpressionAST *binary;
202
203
204
    NestedExpressionAST *nested;
    UnaryExpressionAST *negation;

205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
    QString replacement;
};

/*
    Rewrite
    a op b

    As
    b flipop a
*/
class FlipBinaryOp: public QuickFixOperation
{
public:
    FlipBinaryOp()
        : binary(0)
    {}


    virtual QString description() const
    {
        if (replacement.isEmpty())
            return QLatin1String("Flip");
        else
            return QLatin1String("Flip to use ") + replacement; // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        int index = path.size() - 1;
        binary = path.at(index)->asBinaryExpression();
        if (! binary)
            return -1;
        if (! isCursorOn(binary->binary_op_token))
            return -1;

        CPlusPlus::Kind flipToken;
        switch (tokenAt(binary->binary_op_token).kind()) {
        case T_LESS_EQUAL:
            flipToken = T_GREATER_EQUAL;
            break;
        case T_LESS:
            flipToken = T_GREATER;
            break;
        case T_GREATER:
            flipToken = T_LESS;
            break;
        case T_GREATER_EQUAL:
            flipToken = T_LESS_EQUAL;
            break;
        case T_EQUAL_EQUAL:
        case T_EXCLAIM_EQUAL:
        case T_AMPER_AMPER:
        case T_PIPE_PIPE:
            flipToken = T_EOF_SYMBOL;
            break;
        default:
            return -1;
        }

        if (flipToken != T_EOF_SYMBOL) {
            CPlusPlus::Token tok;
            tok.f.kind = flipToken;
            replacement = QLatin1String(tok.spell());
        }
        return index;
    }

    virtual void createChangeSet()
    {
        flip(binary->left_expression, binary->right_expression);
        if (! replacement.isEmpty())
            replace(binary->binary_op_token, replacement);
    }

private:
    BinaryExpressionAST *binary;
    QString replacement;
};

/*
    Rewrite
    !a && !b

    As
    !(a || b)
*/
291
292
293
class RewriteLogicalAndOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
294
295
    RewriteLogicalAndOp()
        : left(0), right(0), pattern(0)
296
297
298
299
300
301
302
    {}

    virtual QString description() const
    {
        return QLatin1String("Rewrite condition using ||"); // ### tr?
    }

303
    virtual int match(const QList<AST *> &path)
304
    {
305
306
307
308
309
310
311
312
313
314
315
316
        BinaryExpressionAST *expression = 0;

        int index = path.size() - 1;
        for (; index != -1; --index) {
            expression = path.at(index)->asBinaryExpression();
            if (expression)
                break;
        }

        if (! expression)
            return -1;

317
        if (! isCursorOn(expression->binary_op_token))
318
319
            return -1;

320
321
322
323
324
325
326
327
        left = mk.UnaryExpression();
        right = mk.UnaryExpression();
        pattern = mk.BinaryExpression(left, right);

        if (expression->match(pattern, &matcher) &&
                tokenAt(pattern->binary_op_token).is(T_AMPER_AMPER) &&
                tokenAt(left->unary_op_token).is(T_EXCLAIM) &&
                tokenAt(right->unary_op_token).is(T_EXCLAIM)) {
328
            return index;
329
330
        }

331
        return -1;
332
333
    }

Roberto Raggi's avatar
Roberto Raggi committed
334
    virtual void createChangeSet()
335
    {
Roberto Raggi's avatar
Roberto Raggi committed
336
        setTopLevelNode(pattern);
337
        replace(pattern->binary_op_token, QLatin1String("||"));
338
339
340
        remove(left->unary_op_token);
        remove(right->unary_op_token);
        insert(startOf(pattern), QLatin1String("!("));
341
        insert(endOf(pattern), QLatin1String(")"));
342
343
344
345
346
347
348
349
350
351
    }

private:
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    UnaryExpressionAST *left;
    UnaryExpressionAST *right;
    BinaryExpressionAST *pattern;
};

352
353
354
class SplitSimpleDeclarationOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
355
356
    SplitSimpleDeclarationOp()
        : declaration(0)
357
358
359
360
361
362
363
364
365
    {}

    virtual QString description() const
    {
        return QLatin1String("Split declaration"); // ### tr?
    }

    bool checkDeclaration(SimpleDeclarationAST *declaration) const
    {
366
367
368
        if (! declaration->semicolon_token)
            return false;

369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
        if (! declaration->decl_specifier_list)
            return false;

        for (SpecifierListAST *it = declaration->decl_specifier_list; it; it = it->next) {
            SpecifierAST *specifier = it->value;

            if (specifier->asEnumSpecifier() != 0)
                return false;

            else if (specifier->asClassSpecifier() != 0)
                return false;
        }

        if (! declaration->declarator_list)
            return false;

        else if (! declaration->declarator_list->next)
            return false;

        return true;
    }

391
    virtual int match(const QList<AST *> &path)
392
393
394
395
396
397
398
399
400
401
402
403
404
405
    {
        CoreDeclaratorAST *core_declarator = 0;

        int index = path.size() - 1;
        for (; index != -1; --index) {
            AST *node = path.at(index);

            if (CoreDeclaratorAST *coreDecl = node->asCoreDeclarator())
                core_declarator = coreDecl;

            else if (SimpleDeclarationAST *simpleDecl = node->asSimpleDeclaration()) {
                if (checkDeclaration(simpleDecl)) {
                    declaration = simpleDecl;

406
                    const int cursorPosition = selectionStart();
407
408
409
410
411
412
413

                    const int startOfDeclSpecifier = startOf(declaration->decl_specifier_list->firstToken());
                    const int endOfDeclSpecifier = endOf(declaration->decl_specifier_list->lastToken() - 1);

                    if (cursorPosition >= startOfDeclSpecifier && cursorPosition <= endOfDeclSpecifier)
                        return index; // the AST node under cursor is a specifier.

414
                    if (core_declarator && isCursorOn(core_declarator))
415
                        return index; // got a core-declarator under the text cursor.
416
417
418
419
420
421
422
423
424
                }

                break;
            }
        }

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
425
    virtual void createChangeSet()
426
    {
Roberto Raggi's avatar
Roberto Raggi committed
427
        setTopLevelNode(declaration);
428
        SpecifierListAST *specifiers = declaration->decl_specifier_list;
429
430
431
        int declSpecifiersStart = startOf(specifiers->firstToken());
        int declSpecifiersEnd = endOf(specifiers->lastToken() - 1);
        int insertPos = endOf(declaration->semicolon_token);
432

433
        DeclaratorAST *prevDeclarator = declaration->declarator_list->value;
434
435
436
437

        for (DeclaratorListAST *it = declaration->declarator_list->next; it; it = it->next) {
            DeclaratorAST *declarator = it->value;

438
439
440
441
442
443
444
            insert(insertPos, QLatin1String("\n"));
            copy(declSpecifiersStart, declSpecifiersEnd, insertPos);
            insert(insertPos, QLatin1String(" "));
            move(declarator, insertPos);
            insert(insertPos, QLatin1String(";"));

            remove(endOf(prevDeclarator), startOf(declarator));
445

446
447
            prevDeclarator = declarator;
        }
448
449
450
451
452
453
    }

private:
    SimpleDeclarationAST *declaration;
};

454
455
456
457
458
459
460
/*
    Add curly braces to a if statement that doesn't already contain a
    compound statement.
*/
class AddBracesToIfOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
461
462
    AddBracesToIfOp()
        : _statement(0)
463
464
465
466
467
468
469
    {}

    virtual QString description() const
    {
        return QLatin1String("Add curly braces"); // ### tr?
    }

470
    virtual int match(const QList<AST *> &path)
471
472
473
474
    {
        // show when we're on the 'if' of an if statement
        int index = path.size() - 1;
        IfStatementAST *ifStatement = path.at(index)->asIfStatement();
475
        if (ifStatement && isCursorOn(ifStatement->if_token)
476
477
478
479
480
481
482
483
484
            && ! ifStatement->statement->asCompoundStatement()) {
            _statement = ifStatement->statement;
            return index;
        }

        // or if we're on the statement contained in the if
        // ### This may not be such a good idea, consider nested ifs...
        for (; index != -1; --index) {
            IfStatementAST *ifStatement = path.at(index)->asIfStatement();
485
486
            if (ifStatement && ifStatement->statement
                && isCursorOn(ifStatement->statement)
487
488
489
490
491
492
493
494
495
496
497
498
                && ! ifStatement->statement->asCompoundStatement()) {
                _statement = ifStatement->statement;
                return index;
            }
        }

        // ### This could very well be extended to the else branch
        // and other nodes entirely.

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
499
    virtual void createChangeSet()
500
    {
Roberto Raggi's avatar
Roberto Raggi committed
501
        setTopLevelNode(_statement);
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
        insert(endOf(_statement->firstToken() - 1), QLatin1String(" {"));
        insert(endOf(_statement->lastToken() - 1), "\n}");
    }

private:
    StatementAST *_statement;
};

/*
    Replace
    if (Type name = foo()) {...}

    With
    Type name = foo;
    if (name) {...}
*/
518
class MoveDeclarationOutOfIfOp: public QuickFixOperation
519
520
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
521
522
    MoveDeclarationOutOfIfOp()
        : condition(0), pattern(0), core(0)
523
524
525
526
    {}

    virtual QString description() const
    {
527
        return QLatin1String("Move declaration out of condition"); // ### tr?
528
529
    }

530
    virtual int match(const QList<AST *> &path)
531
532
533
534
535
536
537
538
539
540
541
542
543
    {
        condition = mk.Condition();
        pattern = mk.IfStatement(condition);

        int index = path.size() - 1;
        for (; index != -1; --index) {
            if (IfStatementAST *statement = path.at(index)->asIfStatement()) {
                if (statement->match(pattern, &matcher) && condition->declarator) {
                    DeclaratorAST *declarator = condition->declarator;
                    core = declarator->core_declarator;
                    if (! core)
                        return -1;

544
                    if (isCursorOn(core))
545
546
547
548
549
550
551
552
                        return index;
                }
            }
        }

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
553
    virtual void createChangeSet()
554
    {
Roberto Raggi's avatar
Roberto Raggi committed
555
        setTopLevelNode(pattern);
556

557
558
559
560
561
        copy(core, startOf(condition));

        int insertPos = startOf(pattern);
        move(condition, insertPos);
        insert(insertPos, QLatin1String(";\n"));
562
563
564
565
566
567
568
569
570
571
572
    }

private:
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    CPPEditor *editor;
    ConditionAST *condition;
    IfStatementAST *pattern;
    CoreDeclaratorAST *core;
};

573
574
575
576
577
578
579
580
581
582
583
/*
    Replace
    while (Type name = foo()) {...}

    With
    Type name;
    while ((name = foo()) != 0) {...}
*/
class MoveDeclarationOutOfWhileOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
584
585
    MoveDeclarationOutOfWhileOp()
        : condition(0), pattern(0), core(0)
586
587
588
589
590
591
592
    {}

    virtual QString description() const
    {
        return QLatin1String("Move declaration out of condition"); // ### tr?
    }

593
    virtual int match(const QList<AST *> &path)
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
    {
        condition = mk.Condition();
        pattern = mk.WhileStatement(condition);

        int index = path.size() - 1;
        for (; index != -1; --index) {
            if (WhileStatementAST *statement = path.at(index)->asWhileStatement()) {
                if (statement->match(pattern, &matcher) && condition->declarator) {
                    DeclaratorAST *declarator = condition->declarator;
                    core = declarator->core_declarator;

                    if (! core)
                        return -1;

                    else if (! declarator->equals_token)
                        return -1;

                    else if (! declarator->initializer)
                        return -1;

614
                    if (isCursorOn(core))
615
616
617
618
619
620
621
622
                        return index;
                }
            }
        }

        return -1;
    }

Roberto Raggi's avatar
Roberto Raggi committed
623
    virtual void createChangeSet()
624
    {
Roberto Raggi's avatar
Roberto Raggi committed
625
        setTopLevelNode(pattern);
626
627
628
629
630
631
632
633

        insert(startOf(condition), QLatin1String("("));
        insert(endOf(condition), QLatin1String(") != 0"));

        int insertPos = startOf(pattern);
        move(startOf(condition), startOf(core), insertPos);
        copy(core, insertPos);
        insert(insertPos, QLatin1String(";\n"));
634
635
636
637
638
639
640
641
642
643
644
    }

private:
    ASTMatcher matcher;
    ASTPatternBuilder mk;
    CPPEditor *editor;
    ConditionAST *condition;
    WhileStatementAST *pattern;
    CoreDeclaratorAST *core;
};

Roberto Raggi's avatar
Roberto Raggi committed
645
646
647
648
649
650
651
652
653
654
/*
  Replace
     if (something && something_else) {
     }

  with
     if (something) {
        if (something_else) {
        }
     }
Roberto Raggi's avatar
Roberto Raggi committed
655
656
657
658
659
660
661
662
663
664

  and
    if (something || something_else)
      x;

  with
    if (something)
      x;
    else if (something_else)
      x;
Roberto Raggi's avatar
Roberto Raggi committed
665
666
667
668
*/
class SplitIfStatementOp: public QuickFixOperation
{
public:
Roberto Raggi's avatar
Roberto Raggi committed
669
670
    SplitIfStatementOp()
        : condition(0), pattern(0)
Roberto Raggi's avatar
Roberto Raggi committed
671
672
673
674
675
676
677
    {}

    virtual QString description() const
    {
        return QLatin1String("Split if statement"); // ### tr?
    }

678
    virtual int match(const QList<AST *> &path)
Roberto Raggi's avatar
Roberto Raggi committed
679
    {
680
        pattern = 0;
Roberto Raggi's avatar
Roberto Raggi committed
681

682
683
684
685
686
687
688
689
690
        int index = path.size() - 1;
        for (; index != -1; --index) {
            AST *node = path.at(index);
            if (IfStatementAST *stmt = node->asIfStatement()) {
                pattern = stmt;
                break;
            }
        }

691
        if (! pattern || ! pattern->statement)
692
693
            return -1;

694
        unsigned splitKind = 0;
695
696
697
698
699
700
701
        for (++index; index < path.size(); ++index) {
            AST *node = path.at(index);
            condition = node->asBinaryExpression();
            if (! condition)
                return -1;

            Token binaryToken = tokenAt(condition->binary_op_token);
702
703
704
705
706
707
708
709
710
711

            // only accept a chain of ||s or &&s - no mixing
            if (! splitKind) {
                splitKind = binaryToken.kind();
                if (splitKind != T_AMPER_AMPER && splitKind != T_PIPE_PIPE)
                    return -1;
                // we can't reliably split &&s in ifs with an else branch
                if (splitKind == T_AMPER_AMPER && pattern->else_statement)
                    return -1;
            } else if (splitKind != binaryToken.kind()) {
712
713
                return -1;
            }
714
715
716

            if (isCursorOn(condition->binary_op_token))
                return index;
717
718
719
        }

        return -1;
Roberto Raggi's avatar
Roberto Raggi committed
720
721
    }

Roberto Raggi's avatar
Roberto Raggi committed
722
    virtual void createChangeSet()
Roberto Raggi's avatar
Roberto Raggi committed
723
    {
724
        Token binaryToken = tokenAt(condition->binary_op_token);
Roberto Raggi's avatar
Roberto Raggi committed
725

726
        if (binaryToken.is(T_AMPER_AMPER))
Roberto Raggi's avatar
Roberto Raggi committed
727
728
729
730
731
732
733
            splitAndCondition();
        else
            splitOrCondition();
    }

    void splitAndCondition()
    {
Roberto Raggi's avatar
Roberto Raggi committed
734
        setTopLevelNode(pattern);
Roberto Raggi's avatar
Roberto Raggi committed
735

736
737
738
739
740
741
742
        int startPos = startOf(pattern);
        insert(startPos, QLatin1String("if ("));
        move(condition->left_expression, startPos);
        insert(startPos, QLatin1String(") {\n"));

        remove(endOf(condition->left_expression), startOf(condition->right_expression));
        insert(endOf(pattern), QLatin1String("\n}"));
Roberto Raggi's avatar
Roberto Raggi committed
743
744
    }

Roberto Raggi's avatar
Roberto Raggi committed
745
746
747
748
749
    void splitOrCondition()
    {
        StatementAST *ifTrueStatement = pattern->statement;
        CompoundStatementAST *compoundStatement = ifTrueStatement->asCompoundStatement();

750
        setTopLevelNode(pattern);
Roberto Raggi's avatar
Roberto Raggi committed
751

752
        int insertPos = endOf(ifTrueStatement);
Roberto Raggi's avatar
Roberto Raggi committed
753
        if (compoundStatement)
754
            insert(insertPos, QLatin1String(" "));
Roberto Raggi's avatar
Roberto Raggi committed
755
        else
756
757
758
759
760
            insert(insertPos, QLatin1String("\n"));
        insert(insertPos, QLatin1String("else if ("));
        move(startOf(condition->right_expression), startOf(pattern->rparen_token), insertPos);
        insert(insertPos, QLatin1String(")"));
        copy(endOf(pattern->rparen_token), endOf(pattern->statement), insertPos);
761

762
        remove(endOf(condition->left_expression), startOf(condition->right_expression));
Roberto Raggi's avatar
Roberto Raggi committed
763
764
    }

Roberto Raggi's avatar
Roberto Raggi committed
765
766
767
768
private:
    BinaryExpressionAST *condition;
    IfStatementAST *pattern;
};
769

770
771
772
773
774
775
776
777
778
779
/*
  Replace
    "abcd"
  With
    QLatin1String("abcd")
*/
class WrapStringLiteral: public QuickFixOperation
{
public:
    WrapStringLiteral()
780
        : stringLiteral(0), isObjCStringLiteral(false)
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
    {}

    virtual QString description() const
    {
        return QLatin1String("Enclose in QLatin1String(...)"); // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        if (path.isEmpty())
            return -1;

        int index = path.size() - 1;
        stringLiteral = path[index]->asStringLiteral();

        if (!stringLiteral)
            return -1;

799
800
        isObjCStringLiteral = charAt(startOf(stringLiteral)) == QLatin1Char('@');

801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
        // check if it is already wrapped in QLatin1String or -Literal
        if (index-2 < 0)
            return index;

        CallAST *call = path[index-1]->asCall();
        PostfixExpressionAST *postfixExp = path[index-2]->asPostfixExpression();
        if (call && postfixExp
            && postfixExp->base_expression
            && postfixExp->postfix_expression_list
            && postfixExp->postfix_expression_list->value == call)
        {
            NameAST *callName = postfixExp->base_expression->asName();
            if (!callName)
                return index;

            QByteArray callNameString(tokenAt(callName->firstToken()).spell());
            if (callNameString == "QLatin1String"
                || callNameString == "QLatin1Literal"
                )
                return -1;
        }

        return index;
    }

    virtual void createChangeSet()
    {
828
829
830
831
832
833
834
835
        const int startPos = startOf(stringLiteral);
        const QLatin1String replacement("QLatin1String(");

        if (isObjCStringLiteral)
            replace(startPos, startPos + 1, replacement);
        else
            insert(startPos, replacement);

836
837
838
839
840
        insert(endOf(stringLiteral), ")");
    }

private:
    StringLiteralAST *stringLiteral;
841
    bool isObjCStringLiteral;
842
843
};

844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
class CStringToNSString: public QuickFixOperation
{
public:
    CStringToNSString()
        : stringLiteral(0), qlatin1Call(0)
    {}

    virtual QString description() const
    { return QLatin1String("Convert to Objective-C string literal"); }// ### tr?

    virtual int match(const QList<AST *> &path)
    {
        if (path.isEmpty())
            return -1;

        int index = path.size() - 1;
        stringLiteral = path[index]->asStringLiteral();

        if (!stringLiteral)
            return -1;

        if (charAt(startOf(stringLiteral)) == QLatin1Char('@'))
            return -1;

        // check if it is already wrapped in QLatin1String or -Literal
        if (index-2 < 0)
            return index;

        CallAST *call = path[index-1]->asCall();
        PostfixExpressionAST *postfixExp = path[index-2]->asPostfixExpression();
        if (call && postfixExp
            && postfixExp->base_expression
            && postfixExp->postfix_expression_list
            && postfixExp->postfix_expression_list->value == call)
        {
            NameAST *callName = postfixExp->base_expression->asName();
            if (!callName)
                return index;

            if (!(postfixExp->postfix_expression_list->next)) {
                QByteArray callNameString(tokenAt(callName->firstToken()).spell());
                if (callNameString == "QLatin1String"
                    || callNameString == "QLatin1Literal"
                    )
                    qlatin1Call = postfixExp;
            }
        }

        return index;
    }

    virtual void createChangeSet()
    {
        if (qlatin1Call) {
            replace(startOf(qlatin1Call), startOf(stringLiteral), QLatin1String("@"));
            remove(endOf(stringLiteral), endOf(qlatin1Call));
        } else {
            insert(startOf(stringLiteral), "@");
        }
    }

private:
    StringLiteralAST *stringLiteral;
    PostfixExpressionAST *qlatin1Call;
};

910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
/*
  Replace
    a + b
  With
    a % b
  If a and b are of string type.
*/
class UseFastStringConcatenation: public QuickFixOperation
{
public:
    UseFastStringConcatenation()
    {}

    virtual QString description() const
    {
        return QLatin1String("Use fast string concatenation with %"); // ### tr?
    }

    virtual int match(const QList<AST *> &path)
    {
        if (path.isEmpty())
            return -1;

        // need to search 'up' too
        int index = path.size() - 1;
        if (BinaryExpressionAST *binary = asPlusNode(path[index])) {
            while (0 != (binary = asPlusNode(binary->left_expression)))
                _binaryExpressions.prepend(binary);
        }

        // search 'down'
        for (index = path.size() - 1; index != -1; --index) {
            AST *node = path.at(index);
            if (BinaryExpressionAST *binary = asPlusNode(node)) {
                _binaryExpressions.append(binary);
            } else if (! _binaryExpressions.isEmpty()) {
                break;
            }
        }

        if (_binaryExpressions.isEmpty())
            return -1;

        // verify types of arguments
        BinaryExpressionAST *prevBinary = 0;
        foreach (BinaryExpressionAST *binary, _binaryExpressions) {
            if (binary->left_expression != prevBinary) {
                if (!hasCorrectType(binary->left_expression))
                    return -1;
            }
            if (binary->right_expression != prevBinary) {
                if (!hasCorrectType(binary->right_expression))
                    return -1;
            }
            prevBinary = binary;
        }

        return index + _binaryExpressions.size();
    }

    virtual void createChangeSet()
    {
        // replace + -> %
        foreach (BinaryExpressionAST *binary, _binaryExpressions)
            replace(binary->binary_op_token, "%");

        // wrap literals in QLatin1Literal
        foreach (StringLiteralAST *literal, _stringLiterals) {
            insert(startOf(literal), "QLatin1Literal(");
            insert(endOf(literal), ")");
        }

        // replace QLatin1String/QString/QByteArray(literal) -> QLatin1Literal(literal)
        foreach (PostfixExpressionAST *postfix, _incorrectlyWrappedLiterals) {
            replace(postfix->base_expression, "QLatin1Literal");
        }
    }

    BinaryExpressionAST *asPlusNode(AST *ast)
    {
        BinaryExpressionAST *binary = ast->asBinaryExpression();
        if (binary && tokenAt(binary->binary_op_token).kind() == T_PLUS)
            return binary;
        return 0;
    }

    bool hasCorrectType(ExpressionAST *ast)
    {
        if (StringLiteralAST *literal = ast->asStringLiteral()) {
            _stringLiterals += literal;
            return true;
        }

        if (PostfixExpressionAST *postfix = ast->asPostfixExpression()) {
            if (postfix->base_expression && postfix->postfix_expression_list
                && postfix->postfix_expression_list->value
                && !postfix->postfix_expression_list->next)
            {
                NameAST *name = postfix->base_expression->asName();
                CallAST *call = postfix->postfix_expression_list->value->asCall();
                if (name && call) {
                    QByteArray nameStr(name->name->identifier()->chars());
                    if ((nameStr == "QLatin1String"
                         || nameStr == "QString"
                         || nameStr == "QByteArray")
                        && call->expression_list
                        && call->expression_list->value
                        && call->expression_list->value->asStringLiteral()
                        && !call->expression_list->next)
                    {
                        _incorrectlyWrappedLiterals += postfix;
                        return true;
                    }
                }
            }
        }

        const QList<LookupItem> &lookup = typeOf(ast);
        if (lookup.isEmpty())
            return false;
        return isQtStringType(lookup[0].type());
    }

    bool isBuiltinStringType(FullySpecifiedType type)
    {
        // char*
        if (PointerType *ptrTy = type->asPointerType())
            if (IntegerType *intTy = ptrTy->elementType()->asIntegerType())
                if (intTy->kind() == IntegerType::Char)
                    return true;
        return false;
    }

    bool isQtStringType(FullySpecifiedType type)
    {
        if (NamedType *nameTy = type->asNamedType()) {
            if (!nameTy->name() || !nameTy->name()->identifier())
                return false;

            QByteArray name(nameTy->name()->identifier()->chars());
            if (name == "QString"
                || name == "QByteArray"
                || name == "QLatin1String"
                || name == "QLatin1Literal"
                || name == "QStringRef"
                || name == "QChar"
                )
                return true;
        }

        return false;
    }

private:
    QList<BinaryExpressionAST *> _binaryExpressions;
    QList<StringLiteralAST *> _stringLiterals;
    QList<PostfixExpressionAST *> _incorrectlyWrappedLiterals;
};

1069
1070
1071
} // end of anonymous namespace


Roberto Raggi's avatar
Roberto Raggi committed
1072
1073
QuickFixOperation::QuickFixOperation()
    : _editor(0), _topLevelNode(0)
1074
1075
1076
1077
1078
{ }

QuickFixOperation::~QuickFixOperation()
{ }

Roberto Raggi's avatar
Roberto Raggi committed
1079
1080
1081
1082
1083
1084
CPlusPlus::AST *QuickFixOperation::topLevelNode() const
{ return _topLevelNode; }

void QuickFixOperation::setTopLevelNode(CPlusPlus::AST *topLevelNode)
{ _topLevelNode = topLevelNode; }

Roberto Raggi's avatar
Roberto Raggi committed
1085
1086
1087
const Utils::ChangeSet &QuickFixOperation::changeSet() const
{ return _changeSet; }

Roberto Raggi's avatar
Roberto Raggi committed
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
Document::Ptr QuickFixOperation::document() const
{ return _document; }

void QuickFixOperation::setDocument(CPlusPlus::Document::Ptr document)
{ _document = document; }

Snapshot QuickFixOperation::snapshot() const
{ return _snapshot; }

void QuickFixOperation::setSnapshot(const CPlusPlus::Snapshot &snapshot)
1098
1099
1100
{
    _snapshot = snapshot;
}
Roberto Raggi's avatar
Roberto Raggi committed
1101
1102
1103
1104
1105
1106
1107

CPPEditor *QuickFixOperation::editor() const
{ return _editor; }

void QuickFixOperation::setEditor(CPPEditor *editor)
{ _editor = editor; }

1108
1109
1110
QTextCursor QuickFixOperation::textCursor() const
{ return _textCursor; }

1111
1112
1113
void QuickFixOperation::setTextCursor(const QTextCursor &cursor)
{ _textCursor = cursor; }

1114
1115
1116
1117
1118
1119
int QuickFixOperation::selectionStart() const
{ return _textCursor.selectionStart(); }

int QuickFixOperation::selectionEnd() const
{ return _textCursor.selectionEnd(); }

1120
const CPlusPlus::Token &QuickFixOperation::tokenAt(unsigned index) const
Roberto Raggi's avatar
Roberto Raggi committed
1121
{ return _document->translationUnit()->tokenAt(index); }
1122

1123
int QuickFixOperation::startOf(unsigned index) const
1124
{
1125
    unsigned line, column;
Roberto Raggi's avatar
Roberto Raggi committed
1126
    _document->translationUnit()->getPosition(tokenAt(index).begin(), &line, &column);
1127
1128
    return _textCursor.document()->findBlockByNumber(line - 1).position() + column - 1;
}
1129

1130
1131
1132
1133
1134
1135
int QuickFixOperation::startOf(const CPlusPlus::AST *ast) const
{
    return startOf(ast->firstToken());
}

int QuickFixOperation::endOf(unsigned index) const
1136
1137
{
    unsigned line, column;
Roberto Raggi's avatar
Roberto Raggi committed
1138
    _document->translationUnit()->getPosition(tokenAt(index).end(), &line, &column);
1139
    return _textCursor.document()->findBlockByNumber(line - 1).position() + column - 1;
1140
1141
}

1142
1143
1144
1145
1146
int QuickFixOperation::endOf(const CPlusPlus::AST *ast) const
{
    return endOf(ast->lastToken() - 1);
}

1147
1148
1149
1150
1151
1152
1153
1154
1155
void QuickFixOperation::startAndEndOf(unsigned index, int *start, int *end) const
{
    unsigned line, column;
    CPlusPlus::Token token(tokenAt(index));
    _document->translationUnit()->getPosition(token.begin(), &line, &column);
    *start = _textCursor.document()->findBlockByNumber(line - 1).position() + column - 1;
    *end = *start + token.length();
}

1156
bool QuickFixOperation::isCursorOn(unsigned tokenIndex) const
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
{
    QTextCursor tc = textCursor();
    int cursorBegin = tc.selectionStart();

    int start = startOf(tokenIndex);
    int end = endOf(tokenIndex);

    if (cursorBegin >= start && cursorBegin <= end)
        return true;

    return false;
}

1170
bool QuickFixOperation::isCursorOn(const CPlusPlus::AST *ast) const
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
{
    QTextCursor tc = textCursor();
    int cursorBegin = tc.selectionStart();

    int start = startOf(ast);
    int end = endOf(ast);

    if (cursorBegin >= start && cursorBegin <= end)
        return true;

    return false;
}

Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1184
QuickFixOperation::Range QuickFixOperation::createRange(AST *ast) const
1185
{
Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1186
1187
1188
1189
1190
1191
1192
1193
    QTextCursor tc = _textCursor;
    Range r(tc);
    r.begin.setPosition(startOf(ast));
    r.end.setPosition(endOf(ast));
    return r;
}

void QuickFixOperation::reindent(const Range &range)
1194
{
Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1195
1196
1197
    QTextCursor tc = range.begin;
    tc.setPosition(range.end.position(), QTextCursor::KeepAnchor);
    _editor->indentInsertedText(tc);
1198
1199
}

1200
1201
void QuickFixOperation::move(int start, int end, int to)
{
1202
    _changeSet.move(start, end-start, to);
1203
1204
1205
1206
}

void QuickFixOperation::move(unsigned tokenIndex, int to)
{
1207
1208
1209
    int start, end;
    startAndEndOf(tokenIndex, &start, &end);
    move(start, end, to);
1210
1211
1212
1213
1214
1215
1216
1217
1218
}

void QuickFixOperation::move(const CPlusPlus::AST *ast, int to)
{
    move(startOf(ast), endOf(ast), to);
}

void QuickFixOperation::replace(int start, int end, const QString &replacement)
{
1219
    _changeSet.replace(start, end-start, replacement);
1220
1221
1222
1223
}

void QuickFixOperation::replace(unsigned tokenIndex, const QString &replacement)
{
1224
1225
1226
    int start, end;
    startAndEndOf(tokenIndex, &start, &end);
    replace(start, end, replacement);
1227
1228
1229
1230
1231
1232
1233
1234
1235
}

void QuickFixOperation::replace(const CPlusPlus::AST *ast, const QString &replacement)
{
    replace(startOf(ast), endOf(ast), replacement);
}

void QuickFixOperation::insert(int at, const QString &text)
{
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
    _changeSet.insert(at, text);
}

void QuickFixOperation::remove(int start, int end)
{
    _changeSet.remove(start, end-start);
}

void QuickFixOperation::remove(unsigned tokenIndex)
{
1246
1247
1248
    int start, end;
    startAndEndOf(tokenIndex, &start, &end);
    remove(start, end);
1249
1250
1251
1252
1253
1254
1255
}

void QuickFixOperation::remove(const CPlusPlus::AST *ast)
{
    remove(startOf(ast), endOf(ast));
}

Christian Kamm's avatar
Christian Kamm committed
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
void QuickFixOperation::flip(int start1, int end1, int start2, int end2)
{
    _changeSet.flip(start1, end1-start1, start2, end2-start2);
}

void QuickFixOperation::flip(const CPlusPlus::AST *ast1, const CPlusPlus::AST *ast2)
{
    flip(startOf(ast1), endOf(ast1), startOf(ast2), endOf(ast2));
}

1266
1267
1268
1269
1270
1271
1272
void QuickFixOperation::copy(int start, int end, int to)
{
    _changeSet.copy(start, end-start, to);
}

void QuickFixOperation::copy(unsigned tokenIndex, int to)
{
1273
1274
1275
    int start, end;
    startAndEndOf(tokenIndex, &start, &end);
    copy(start, end, to);
1276
1277
1278
1279
1280
}

void QuickFixOperation::copy(const CPlusPlus::AST *ast, int to)
{
    copy(startOf(ast), endOf(ast), to);
1281
1282
}

1283
1284
1285
1286
1287
1288
1289
1290
QString QuickFixOperation::textOf(int firstOffset, int lastOffset) const
{
    QTextCursor tc = _textCursor;
    tc.setPosition(firstOffset);
    tc.setPosition(lastOffset, QTextCursor::KeepAnchor);
    return tc.selectedText();
}

1291
QString QuickFixOperation::textOf(const AST *ast) const
1292
{
1293
    return textOf(startOf(ast), endOf(ast));
1294
1295
}

1296
1297
1298
1299
1300
QChar QuickFixOperation::charAt(int offset) const
{
    return textOf(offset, offset + 1).at(0);
}

1301
void QuickFixOperation::apply()
1302
{
Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1303
    Range range;
1304

Roberto Raggi's avatar
Roberto Raggi committed
1305
1306
    if (_topLevelNode)
        range = createRange(_topLevelNode);
Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1307
1308

    _textCursor.beginEditBlock();
1309

1310
    _changeSet.apply(&_textCursor);
1311

Roberto Raggi's avatar
Roberto Raggi committed
1312
    if (_topLevelNode)
Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1313
        reindent(range);
1314

Roberto Raggi's avatar
Cleanup    
Roberto Raggi committed
1315
    _textCursor.endEditBlock();
1316
1317
}

1318
1319
1320
1321
1322
1323
/**
 * Returns a list of possible fully specified types associated with the
 * given expression.
 *
 * NOTE: The fully specified types only stay valid until the next call to typeOf.
 */
1324
const QList<LookupItem> QuickFixOperation::typeOf(CPlusPlus::ExpressionAST *ast)
1325
{
1326
1327
1328
1329
1330
1331
1332
1333
#ifdef __GNUC__
#  warning port me
#endif

    qWarning() << Q_FUNC_INFO << __LINE__;
    return QList<LookupItem>();

#if 0
1334
1335
1336
1337
    unsigned line, column;
    document()->translationUnit()->getTokenStartPosition(ast->firstToken(), &line, &column);
    Symbol *lastVisibleSymbol = document()->findSymbolAt(line, column);

1338
    ResolveExpression resolveExpression(lastVisibleSymbol, _lookupContext);
1339
    return resolveExpression(ast);
1340
#endif
1341
1342
}

1343
CPPQuickFixCollector::CPPQuickFixCollector()
1344
    : _modelManager(CppTools::CppModelManagerInterface::instance()), _editable(0), _editor(0)
1345
1346
1347
1348
1349
{ }

CPPQuickFixCollector::~CPPQuickFixCollector()
{ }

1350
1351
1352
1353
1354
1355
TextEditor::ITextEditable *CPPQuickFixCollector::editor() const
{ return _editable; }

int CPPQuickFixCollector::startPosition() const
{ return _editable->position(); }

1356
1357
1358
1359
bool CPPQuickFixCollector::supportsEditor(TextEditor::ITextEditable *editor)
{ return qobject_cast<CPPEditorEditable *>(editor) != 0; }

bool CPPQuickFixCollector::triggersCompletion(TextEditor::ITextEditable *)
1360
{ return false; }
1361
1362
1363
1364

int CPPQuickFixCollector::startCompletion(TextEditor::ITextEditable *editable)
{
    Q_ASSERT(editable != 0);
1365

1366
    _editable = editable;
1367
    _editor = qobject_cast<CPPEditor *>(editable->widget());
1368
1369
1370
1371
    Q_ASSERT(_editor != 0);

    const SemanticInfo info = _editor->semanticInfo();

1372
    if (info.revision != _editor->editorRevision()) {
1373
1374
1375
1376
1377
        // outdated
        qWarning() << "TODO: outdated semantic info, force a reparse.";
        return -1;
    }

1378
    if (info.doc) {
1379
1380
1381
        ASTPath astPath(info.doc);

        const QList<AST *> path = astPath(_editor->textCursor());
Roberto Raggi's avatar
Roberto Raggi committed
1382
1383
        if (path.isEmpty())
            return -1;
1384

Roberto Raggi's avatar
Roberto Raggi committed
1385
1386
1387
1388
1389
1390
        QSharedPointer<RewriteLogicalAndOp> rewriteLogicalAndOp(new RewriteLogicalAndOp());
        QSharedPointer<SplitIfStatementOp> splitIfStatementOp(new SplitIfStatementOp());
        QSharedPointer<MoveDeclarationOutOfIfOp> moveDeclarationOutOfIfOp(new MoveDeclarationOutOfIfOp());
        QSharedPointer<MoveDeclarationOutOfWhileOp> moveDeclarationOutOfWhileOp(new MoveDeclarationOutOfWhileOp());
        QSharedPointer<SplitSimpleDeclarationOp> splitSimpleDeclarationOp(new SplitSimpleDeclarationOp());
        QSharedPointer<AddBracesToIfOp> addBracesToIfOp(new AddBracesToIfOp());
1391
1392
        QSharedPointer<UseInverseOp> useInverseOp(new UseInverseOp());
        QSharedPointer<FlipBinaryOp> flipBinaryOp(new FlipBinaryOp());
1393
        QSharedPointer<WrapStringLiteral> wrapStringLiteral(new WrapStringLiteral());
1394
        QSharedPointer<CStringToNSString> wrapCString(new CStringToNSString());
1395
        QSharedPointer<UseFastStringConcatenation> useFastStringConcat(new UseFastStringConcatenation());
1396

1397
1398
        QList<QuickFixOperationPtr> candidates;
        candidates.append(rewriteLogicalAndOp);
1399
        candidates.append(splitIfStatementOp);
1400
1401
        candidates.append(moveDeclarationOutOfIfOp);
        candidates.append(moveDeclarationOutOfWhileOp);
1402
        candidates.append(splitSimpleDeclarationOp);
1403
        candidates.append(addBracesToIfOp);
1404
1405
        candidates.append(useInverseOp);
        candidates.append(flipBinaryOp);
1406
        candidates.append(wrapStringLiteral);
1407
1408
        if (_editor->mimeType() == CppTools::Constants::OBJECTIVE_CPP_SOURCE_MIMETYPE)
            candidates.append(wrapCString);
1409
        candidates.append(useFastStringConcat);
Roberto Raggi's avatar
Roberto Raggi committed
1410

1411
        QMap<int, QList<QuickFixOperationPtr> > matchedOps;
Roberto Raggi's avatar
Roberto Raggi committed
1412

1413
        foreach (QuickFixOperationPtr op, candidates) {
Roberto Raggi's avatar
Roberto Raggi committed
1414
1415
1416
            op->setSnapshot(info.snapshot);
            op->setDocument(info.doc);
            op->setEditor(_editor);
1417
1418
            op->setTextCursor(_editor->textCursor());
            int priority = op->match(path);
1419
            if (priority != -1)
1420
                matchedOps[priority].append(op);
1421
        }
Roberto Raggi's avatar
Roberto Raggi committed
1422

1423
        QMapIterator<int, QList<QuickFixOperationPtr> > it(matchedOps);
1424
1425
1426
1427
        it.toBack();
        if (it.hasPrevious()) {
            it.previous();

1428
            _quickFixes = it.value();
1429
1430
        }

1431
1432
        if (! _quickFixes.isEmpty())
            return editable->position();
1433
1434
    }

1435
1436
1437
    return -1;
}

1438
void CPPQuickFixCollector::completions(QList<TextEditor::CompletionItem> *quickFixItems)
1439
{
1440
1441
1442
1443
1444
1445
1446
1447
    for (int i = 0; i < _quickFixes.size(); ++i) {
        QuickFixOperationPtr op = _quickFixes.at(i);

        TextEditor::CompletionItem item(this);
        item.text = op->description();
        item.data = QVariant::fromValue(i);
        quickFixItems->append(item);
    }
1448
1449
1450
1451
1452
1453
}

void CPPQuickFixCollector::complete(const TextEditor::CompletionItem &item)
{
    const int index = item.data.toInt();

1454
1455
    if (index < _quickFixes.size()) {
        QuickFixOperationPtr quickFix = _quickFixes.at(index);
1456
        perform(quickFix);
1457
1458
1459
    }
}

1460
1461
1462
void CPPQuickFixCollector::perform(QuickFixOperationPtr op)
{
    op->setTextCursor(_editor->textCursor());
Roberto Raggi's avatar
Roberto Raggi committed
1463
    op->createChangeSet();
1464
    op->apply();
1465
1466
}

1467
1468
void CPPQuickFixCollector::cleanup()
{