Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Marco Bubke
flatpak-qt-creator
Commits
00a97664
Commit
00a97664
authored
Nov 08, 2010
by
Kai Koehne
Browse files
DebugHelpers: Use static QRegExp for performance reasons
Reviewed-by: Bill King
parent
424fcf8c
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/libs/utils/buildablehelperlibrary.cpp
View file @
00a97664
...
...
@@ -90,10 +90,12 @@ QString BuildableHelperLibrary::qtVersionForQMake(const QString &qmakePath)
return
QString
();
}
const
QString
output
=
QString
::
fromLocal8Bit
(
qmake
.
readAllStandardOutput
());
QRegExp
regexp
(
QLatin1String
(
"(QMake version|QMake version:)[
\\
s]*([
\\
d.]*)"
),
Qt
::
CaseInsensitive
);
static
QRegExp
regexp
(
QLatin1String
(
"(QMake version|QMake version:)[
\\
s]*([
\\
d.]*)"
),
Qt
::
CaseInsensitive
);
regexp
.
indexIn
(
output
);
if
(
regexp
.
cap
(
2
).
startsWith
(
QLatin1String
(
"2."
)))
{
QRegExp
regexp2
(
QLatin1String
(
"Using Qt version[
\\
s]*([
\\
d
\\
.]*)"
),
Qt
::
CaseInsensitive
);
static
QRegExp
regexp2
(
QLatin1String
(
"Using Qt version[
\\
s]*([
\\
d
\\
.]*)"
),
Qt
::
CaseInsensitive
);
regexp2
.
indexIn
(
output
);
const
QString
version
=
regexp2
.
cap
(
1
);
return
version
;
...
...
@@ -108,7 +110,7 @@ bool BuildableHelperLibrary::checkMinimumQtVersion(const QString &qtVersionStrin
int
patch
=
-
1
;
// check format
QRegExp
qtVersionRegex
(
QLatin1String
(
"^
\\
d+
\\
.
\\
d+
\\
.
\\
d+$"
));
static
QRegExp
qtVersionRegex
(
QLatin1String
(
"^
\\
d+
\\
.
\\
d+
\\
.
\\
d+$"
));
if
(
!
qtVersionRegex
.
exactMatch
(
qtVersionString
))
return
false
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment