VCS: Remove unnecessary indirection

Change-Id: I73d70da7e6cc6006da92c05bf0b15da6b8bbf5bf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/clearcase/clearcaseplugin.cpp

@@ -1530,9 +1530,8 @@ IEditor *ClearCasePlugin::showOutputInEditor(const QString& title, const QString
         e->setSource(source);
     if (codec)
         e->setCodec(codec);
-    IEditor *ie = e->editor();
-    EditorManager::activateEditor(ie);
-    return ie;
+    EditorManager::activateEditor(editor);
+    return editor;
 }
 
 const ClearCaseSettings &ClearCasePlugin::settings() const

src/plugins/cvs/cvsplugin.cpp

@@ -1182,9 +1182,8 @@ IEditor *CvsPlugin::showOutputInEditor(const QString& title, const QString &outp
         e->setSource(source);
     if (codec)
         e->setCodec(codec);
-    IEditor *ie = e->editor();
-    EditorManager::activateEditor(ie);
-    return ie;
+    EditorManager::activateEditor(editor);
+    return editor;
 }
 
 CvsSettings CvsPlugin::settings() const

src/plugins/perforce/perforceplugin.cpp

@@ -1185,9 +1185,8 @@ Core::IEditor *PerforcePlugin::showOutputInEditor(const QString &title, const QS
     e->setSuggestedFileName(s);
     if (codec)
         e->setCodec(codec);
-    Core::IEditor *ie = e->editor();
-    Core::EditorManager::activateEditor(ie);
-    return ie;
+    Core::EditorManager::activateEditor(editor);
+    return editor;
 }
 
 void PerforcePlugin::slotSubmitDiff(const QStringList &files)

src/plugins/subversion/subversionplugin.cpp

@@ -1036,9 +1036,8 @@ Core::IEditor *SubversionPlugin::showOutputInEditor(const QString &title, const
         e->setSource(source);
     if (codec)
         e->setCodec(codec);
-    Core::IEditor *ie = e->editor();
-    Core::EditorManager::activateEditor(ie);
-    return ie;
+    Core::EditorManager::activateEditor(editor);
+    return editor;
 }
 
 SubversionSettings SubversionPlugin::settings() const