diff --git a/src/libs/3rdparty/cplusplus/Symbol.cpp b/src/libs/3rdparty/cplusplus/Symbol.cpp index cd8ec1ffdd7d890435a9e1f75d59bf2645e033b5..0510117f8b6fc309c47d7be80a28675fa87b57f2 100644 --- a/src/libs/3rdparty/cplusplus/Symbol.cpp +++ b/src/libs/3rdparty/cplusplus/Symbol.cpp @@ -105,7 +105,7 @@ Symbol::Symbol(TranslationUnit *translationUnit, unsigned sourceLocation, const Symbol::Symbol(Clone *clone, Subst *subst, Symbol *original) : _name(clone->name(original->_name, subst)), - _scope(original->_scope), + _scope(0), _next(0), _fileId(clone->control()->stringLiteral(original->fileName(), original->fileNameLength())), _sourceLocation(original->_sourceLocation), @@ -296,6 +296,11 @@ Block *Symbol::enclosingBlock() const return 0; } +Scope *Symbol::scope() const +{ + return _scope; +} + unsigned Symbol::index() const { return _index; } diff --git a/src/libs/3rdparty/cplusplus/Symbol.h b/src/libs/3rdparty/cplusplus/Symbol.h index a995f436312674fb9848e51f4670c1a0d157a4ea..30cd28797b7c2004095e7c5e16add85f51be1e7f 100644 --- a/src/libs/3rdparty/cplusplus/Symbol.h +++ b/src/libs/3rdparty/cplusplus/Symbol.h @@ -290,6 +290,7 @@ public: /// Returns the enclosing Block scope. Block *enclosingBlock() const; + Scope *scope() const; void setScope(Scope *enclosingScope); // ### make me private void resetScope(); // ### make me private void setSourceLocation(unsigned sourceLocation, TranslationUnit *translationUnit); // ### make me private diff --git a/src/libs/cplusplus/LookupContext.cpp b/src/libs/cplusplus/LookupContext.cpp index 51d28f29eac0ab6e4ebb789fcb3d25c04cfb1811..fab318e8ca896e92086876bd543fbd284881360f 100644 --- a/src/libs/cplusplus/LookupContext.cpp +++ b/src/libs/cplusplus/LookupContext.cpp @@ -936,6 +936,7 @@ ClassOrNamespace *ClassOrNamespace::nestedType(const Name *name, ClassOrNamespac foreach (Symbol *s, reference->symbols()) { Symbol *clone = cloner.symbol(s, &subst); + clone->setScope(s->scope()); instantiation->_symbols.append(clone); #ifdef DEBUG_LOOKUP Overview oo;oo.showFunctionSignatures = true; @@ -1089,6 +1090,7 @@ void ClassOrNamespace::NestedClassInstantiator::instantiate(ClassOrNamespace *en foreach (Symbol *s, nestedClassOrNamespace->_symbols) { Symbol *clone = _cloner.symbol(s, &_subst); + clone->setScope(s->scope()); nestedClassOrNamespaceInstantiation->_symbols.append(clone); } } diff --git a/src/plugins/cpptools/cppcompletion_test.cpp b/src/plugins/cpptools/cppcompletion_test.cpp index 0af9130e96c29db03f7d07650ef2b0842b5a4622..b8ee95f7c04a879581c8f3f4cd4c94cc39cc6535 100644 --- a/src/plugins/cpptools/cppcompletion_test.cpp +++ b/src/plugins/cpptools/cppcompletion_test.cpp @@ -1843,3 +1843,42 @@ void CppToolsPlugin::test_completion_namespace_alias_with_many_namespace_declara QVERIFY(completions.contains(QLatin1String("Foo1"))); QVERIFY(completions.contains(QLatin1String("Foo2"))); } + +void CppToolsPlugin::test_completion_QTCREATORBUG9098() +{ + TestData data; + data.srcText = + "template \n" + "class B\n" + "{\n" + "public:\n" + " C c;\n" + "};\n" + "template \n" + "class A\n" + "{\n" + "public:\n" + " B b;\n" + " void fun()\n" + " {\n" + " @\n" + " // padding so we get the scope right\n" + " }\n" + "};\n" + + ; + setup(&data); + + Utils::ChangeSet change; + QString txt = QLatin1String("b."); + change.insert(data.pos, txt); + QTextCursor cursor(data.doc); + change.apply(&cursor); + data.pos += txt.length(); + + QStringList completions = getCompletions(data); + + QCOMPARE(completions.size(), 2); + QVERIFY(completions.contains(QLatin1String("c"))); + QVERIFY(completions.contains(QLatin1String("B"))); +} diff --git a/src/plugins/cpptools/cpptoolsplugin.h b/src/plugins/cpptools/cpptoolsplugin.h index dfce31798ab76fa02b8f5240eb4eb2fcf8202a5c..10975a53013d09e1f02aed4de8a230a5041c2670 100644 --- a/src/plugins/cpptools/cpptoolsplugin.h +++ b/src/plugins/cpptools/cpptoolsplugin.h @@ -123,6 +123,7 @@ private slots: void test_completion_typedef_using_templates1(); void test_completion_typedef_using_templates2(); void test_completion_namespace_alias_with_many_namespace_declarations(); + void test_completion_QTCREATORBUG9098(); void test_format_pointerdeclaration_in_simpledeclarations(); void test_format_pointerdeclaration_in_simpledeclarations_data(); diff --git a/tests/auto/cplusplus/checksymbols/tst_checksymbols.cpp b/tests/auto/cplusplus/checksymbols/tst_checksymbols.cpp index b5ee70b5239e6921eed96782b601923eaa4fa436..2a7d082c18e5f714ac304cc92b08f74d41c141a2 100644 --- a/tests/auto/cplusplus/checksymbols/tst_checksymbols.cpp +++ b/tests/auto/cplusplus/checksymbols/tst_checksymbols.cpp @@ -185,6 +185,7 @@ private slots: void test_checksymbols_QTCREATORBUG8974_danglingPointer(); void operatorAsteriskOfNestedClassOfTemplateClass_QTCREATORBUG9006(); void test_checksymbols_templated_functions(); + void test_checksymbols_QTCREATORBUG9098(); }; void tst_CheckSymbols::test_checksymbols_TypeUse() @@ -1415,6 +1416,44 @@ void tst_CheckSymbols::test_checksymbols_templated_functions() << Use(6, 17, 1, SemanticInfo::TypeUse) ; +} + +void tst_CheckSymbols::test_checksymbols_QTCREATORBUG9098() +{ + const QByteArray source = + "template \n" + "class B\n" + "{\n" + "public:\n" + " C c;\n" + "};\n" + "template \n" + "class A\n" + "{\n" + "public:\n" + " B b;\n" + " void fun()\n" + " {\n" + " b.c;\n" + " }\n" + "}\n" + ; + + const QList expectedUses = QList() + << Use(1, 20, 1, SemanticInfo::TypeUse) + << Use(2, 7, 1, SemanticInfo::TypeUse) + << Use(5, 7, 1, SemanticInfo::TypeUse) + << Use(5, 10, 1, SemanticInfo::FieldUse) + << Use(7, 20, 1, SemanticInfo::TypeUse) + << Use(8, 7, 1, SemanticInfo::TypeUse) + << Use(11, 5, 1, SemanticInfo::TypeUse) + << Use(11, 7, 1, SemanticInfo::TypeUse) + << Use(11, 10, 1, SemanticInfo::FieldUse) + << Use(12, 10, 3, SemanticInfo::FunctionUse) + << Use(14, 9, 1, SemanticInfo::FieldUse) + << Use(14, 11, 1, SemanticInfo::FieldUse) + ; + TestData::check(source, expectedUses); }