Commit 1ee7205a authored by Daniel Teske's avatar Daniel Teske
Browse files

Cleanup more TODOs in ProjectExplorer



Those are just comments on the code, nothing to do.

Change-Id: I1daaa26eafd3d5f4da1d4be3eede9996ea87248f
Reviewed-by: default avatarTobias Hunger <tobias.hunger@nokia.com>
parent 36500c21
...@@ -199,7 +199,7 @@ bool BuildConfiguration::fromMap(const QVariantMap &map) ...@@ -199,7 +199,7 @@ bool BuildConfiguration::fromMap(const QVariantMap &map)
setToolChain(ToolChainManager::instance()->findToolChain(id)); // Do not validate the tool chain as setToolChain(ToolChainManager::instance()->findToolChain(id)); // Do not validate the tool chain as
// the BC is not completely set up yet! // the BC is not completely set up yet!
// TODO: We currently assume there to be at least a clean and build list! // We currently assume there to be at least a clean and build list!
QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_BUILD))); QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_BUILD)));
QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_CLEAN))); QTC_CHECK(knownStepLists().contains(Core::Id(ProjectExplorer::Constants::BUILDSTEPS_CLEAN)));
......
...@@ -127,7 +127,7 @@ bool DeployConfiguration::fromMap(const QVariantMap &map) ...@@ -127,7 +127,7 @@ bool DeployConfiguration::fromMap(const QVariantMap &map)
return false; return false;
} }
// TODO: We assume that we hold the deploy list // We assume that we hold the deploy list
Q_ASSERT(m_stepList && m_stepList->id() == Core::Id(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY)); Q_ASSERT(m_stepList && m_stepList->id() == Core::Id(ProjectExplorer::Constants::BUILDSTEPS_DEPLOY));
return true; return true;
......
...@@ -158,7 +158,7 @@ bool SessionManager::recursiveDependencyCheck(const QString &newDep, const QStri ...@@ -158,7 +158,7 @@ bool SessionManager::recursiveDependencyCheck(const QString &newDep, const QStri
} }
/* /*
* TODO: The dependency management exposes an interface based on projects, but * The dependency management exposes an interface based on projects, but
* is internally purely string based. This is suboptimal. Probably it would be * is internally purely string based. This is suboptimal. Probably it would be
* nicer to map the filenames to projects on load and only map it back to * nicer to map the filenames to projects on load and only map it back to
* filenames when saving. * filenames when saving.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment