diff --git a/src/plugins/git/gitclient.cpp b/src/plugins/git/gitclient.cpp index c1d9161551ce56626a5fb5b94ff2538a3c3c0f16..885a4b45f9c381ce552c22c95492068a11fb0cf3 100644 --- a/src/plugins/git/gitclient.cpp +++ b/src/plugins/git/gitclient.cpp @@ -2019,10 +2019,10 @@ QString GitClient::gitBinaryPath(bool *ok, QString *errorMessage) const bool GitClient::getCommitData(const QString &workingDirectory, QString *commitTemplate, - CommitData *commitData, + CommitData &commitData, QString *errorMessage) { - commitData->clear(); + commitData.clear(); // Find repo const QString repoDirectory = GitClient::findRepositoryForDirectory(workingDirectory); @@ -2031,7 +2031,7 @@ bool GitClient::getCommitData(const QString &workingDirectory, return false; } - commitData->panelInfo.repository = repoDirectory; + commitData.panelInfo.repository = repoDirectory; QString gitDir = findGitDirForRepository(repoDirectory); if (gitDir.isEmpty()) { @@ -2046,7 +2046,7 @@ bool GitClient::getCommitData(const QString &workingDirectory, case StatusChanged: break; case StatusUnchanged: - if (commitData->commitType == AmendCommit) // amend might be run just for the commit message + if (commitData.commitType == AmendCommit) // amend might be run just for the commit message break; *errorMessage = msgNoChangedFiles(); return false; @@ -2062,39 +2062,39 @@ bool GitClient::getCommitData(const QString &workingDirectory, // D deleted_file // ?? untracked_file if (status != StatusUnchanged) { - if (!commitData->parseFilesFromStatus(output)) { + if (!commitData.parseFilesFromStatus(output)) { *errorMessage = msgParseFilesFailed(); return false; } // Filter out untracked files that are not part of the project - QStringList untrackedFiles = commitData->filterFiles(UntrackedFile); + QStringList untrackedFiles = commitData.filterFiles(UntrackedFile); VcsBase::VcsBaseSubmitEditor::filterUntrackedFilesOfProject(repoDirectory, &untrackedFiles); QList<CommitData::StateFilePair> filteredFiles; - QList<CommitData::StateFilePair>::const_iterator it = commitData->files.constBegin(); - for ( ; it != commitData->files.constEnd(); ++it) { + QList<CommitData::StateFilePair>::const_iterator it = commitData.files.constBegin(); + for ( ; it != commitData.files.constEnd(); ++it) { if (it->first == UntrackedFile && !untrackedFiles.contains(it->second)) continue; filteredFiles.append(*it); } - commitData->files = filteredFiles; + commitData.files = filteredFiles; - if (commitData->files.isEmpty() && commitData->commitType != AmendCommit) { + if (commitData.files.isEmpty() && commitData.commitType != AmendCommit) { *errorMessage = msgNoChangedFiles(); return false; } } - commitData->commitEncoding = readConfigValue(workingDirectory, QLatin1String("i18n.commitEncoding")); + commitData.commitEncoding = readConfigValue(workingDirectory, QLatin1String("i18n.commitEncoding")); // Get the commit template or the last commit message - switch (commitData->commitType) { + switch (commitData.commitType) { case AmendCommit: { // Amend: get last commit data as "SHA1<tab>author<tab>email<tab>message". QStringList args(QLatin1String("log")); args << QLatin1String("--max-count=1") << QLatin1String("--pretty=format:%h\t%an\t%ae\t%B"); - QTextCodec *codec = QTextCodec::codecForName(commitData->commitEncoding.toLocal8Bit()); + QTextCodec *codec = QTextCodec::codecForName(commitData.commitEncoding.toLocal8Bit()); const Utils::SynchronousProcessResponse sp = synchronousGit(repoDirectory, args, 0, codec); if (sp.result != Utils::SynchronousProcessResponse::Finished) { *errorMessage = tr("Cannot retrieve last commit data of repository \"%1\".").arg(repoDirectory); @@ -2102,15 +2102,15 @@ bool GitClient::getCommitData(const QString &workingDirectory, } QStringList values = sp.stdOut.split(QLatin1Char('\t')); QTC_ASSERT(values.size() >= 4, return false); - commitData->amendSHA1 = values.takeFirst(); - commitData->panelData.author = values.takeFirst(); - commitData->panelData.email = values.takeFirst(); + commitData.amendSHA1 = values.takeFirst(); + commitData.panelData.author = values.takeFirst(); + commitData.panelData.email = values.takeFirst(); *commitTemplate = values.join(QLatin1String("\t")); break; } case SimpleCommit: { - commitData->panelData.author = readConfigValue(workingDirectory, QLatin1String("user.name")); - commitData->panelData.email = readConfigValue(workingDirectory, QLatin1String("user.email")); + commitData.panelData.author = readConfigValue(workingDirectory, QLatin1String("user.name")); + commitData.panelData.email = readConfigValue(workingDirectory, QLatin1String("user.email")); // Commit: Get the commit template QDir gitDirectory(gitDir); QString templateFilename = gitDirectory.absoluteFilePath(QLatin1String("MERGE_MSG")); diff --git a/src/plugins/git/gitclient.h b/src/plugins/git/gitclient.h index 377b4240fb886cd6b11b6c6746e3f482c8539663..122271fe89805fe06a078749de4ab292c856df16 100644 --- a/src/plugins/git/gitclient.h +++ b/src/plugins/git/gitclient.h @@ -262,7 +262,7 @@ public: QString readConfigValue(const QString &workingDirectory, const QString &configVar) const; bool getCommitData(const QString &workingDirectory, QString *commitTemplate, - CommitData *commitData, QString *errorMessage); + CommitData &commitData, QString *errorMessage); bool addAndCommit(const QString &workingDirectory, const GitSubmitEditorPanelData &data, diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp index bad45c3b37ad13b9abab7b95d46952055e792e40..0e2557b429f95097d62eb6f457c81b6e780a6b2f 100644 --- a/src/plugins/git/gitplugin.cpp +++ b/src/plugins/git/gitplugin.cpp @@ -897,7 +897,7 @@ void GitPlugin::startCommit(CommitType commitType) QString errorMessage, commitTemplate; CommitData data(commitType); - if (!m_gitClient->getCommitData(state.topLevel(), &commitTemplate, &data, &errorMessage)) { + if (!m_gitClient->getCommitData(state.topLevel(), &commitTemplate, data, &errorMessage)) { VcsBase::VcsBaseOutputWindow::instance()->append(errorMessage); return; } diff --git a/src/plugins/git/gitsubmiteditor.cpp b/src/plugins/git/gitsubmiteditor.cpp index da3d1df4b84db4f12a6e914cc8360fb393489e7c..9229022090a8738d8995bc134090cde2df4b7f4c 100644 --- a/src/plugins/git/gitsubmiteditor.cpp +++ b/src/plugins/git/gitsubmiteditor.cpp @@ -164,7 +164,7 @@ void GitSubmitEditor::updateFileModel() GitClient *client = GitPlugin::instance()->gitClient(); QString errorMessage, commitTemplate; CommitData data(m_commitType); - if (client->getCommitData(m_workingDirectory, &commitTemplate, &data, &errorMessage)) { + if (client->getCommitData(m_workingDirectory, &commitTemplate, data, &errorMessage)) { setCommitData(data); } else { VcsBase::VcsBaseOutputWindow::instance()->append(errorMessage);