Commit 21a94e5e authored by Ulf Hermann's avatar Ulf Hermann

Timeline: Optimize selection tools for fewer scene graph rebuilds

The selection details "windows" contain frequently updated text and can
be moved around in the scene. We don't want their contents to be batched
with the rest of the scene as there may be many events in the timeline
and rebuilding the batch they are in is expensive. The clip property has
the side effect of preventing nodes within the clipped area from getting
batched with nodes outside it. Thus, by setting the clip property on
the details we reduce the number of batch rebuilds for the actual

Having a transparent rectangle in there doesn't help the renderer,
either, so we replace it with a plain item.

Change-Id: Ie6bac1324d3bc6b8b3d56e658a766f1f90be9046
Task-number: QTCREATORBUG-14983
Reviewed-by: default avatarJoerg Bornemann <>
parent f1ede405
...@@ -317,6 +317,7 @@ Rectangle { ...@@ -317,6 +317,7 @@ Rectangle {
x: 200 x: 200
y: 125 y: 125
clip: true
id: selectionRangeDetails id: selectionRangeDetails
visible: selectionRange.visible visible: selectionRange.visible
startTime: zoomControl.selectionStart startTime: zoomControl.selectionStart
...@@ -345,6 +346,7 @@ Rectangle { ...@@ -345,6 +346,7 @@ Rectangle {
x: 200 x: 200
y: 25 y: 25
clip: true
locked: content.selectionLocked locked: content.selectionLocked
models: timelineModelAggregator.models models: timelineModelAggregator.models
notes: timelineModelAggregator.notes notes: timelineModelAggregator.notes
...@@ -30,10 +30,9 @@ ...@@ -30,10 +30,9 @@
import QtQuick 2.1 import QtQuick 2.1
Rectangle { Item {
id: rangeMover id: rangeMover
anchors.fill: parent anchors.fill: parent
color: "transparent"
signal rangeDoubleClicked() signal rangeDoubleClicked()
property color handleColor: "#869cd1" property color handleColor: "#869cd1"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment