Commit 2998d335 authored by Tobias Hunger's avatar Tobias Hunger Committed by Orgad Shaneh

Gerrit: Rename member

This is more in line with what we do elsewhere.

Change-Id: If5fb57a498c021c2c2f830d9aaa375bc13afeb19
Reviewed-by: Orgad Shaneh's avatarOrgad Shaneh <orgads@gmail.com>
parent 6a4d6efb
......@@ -316,7 +316,7 @@ void GerritPlugin::push(const QString &topLevel)
// QScopedPointer is required to delete the dialog when leaving the function
GerritPushDialog dialog(topLevel, m_reviewers, ICore::mainWindow());
if (!dialog.valid()) {
if (!dialog.isValid()) {
QMessageBox::warning(ICore::mainWindow(), tr("Initialization Failed"),
tr("Failed to initialize dialog. Aborting."));
return;
......
......@@ -136,7 +136,7 @@ GerritPushDialog::GerritPushDialog(const QString &workingDir, const QString &rev
QDialog(parent),
m_workingDir(workingDir),
m_ui(new Ui::GerritPushDialog),
m_valid(false)
m_isValid(false)
{
m_client = GitPlugin::instance()->gitClient();
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
......@@ -166,7 +166,7 @@ GerritPushDialog::GerritPushDialog(const QString &workingDir, const QString &rev
m_ui->reviewersLineEdit->setValidator(noSpaceValidator);
m_ui->topicLineEdit->setValidator(noSpaceValidator);
m_valid = true;
m_isValid = true;
}
GerritPushDialog::~GerritPushDialog()
......@@ -216,9 +216,9 @@ void GerritPushDialog::setChangeRange()
.arg(calculateChangeRange(branch)));
}
bool GerritPushDialog::valid() const
bool GerritPushDialog::isValid() const
{
return m_valid;
return m_isValid;
}
void GerritPushDialog::setRemoteBranches(bool includeOld)
......
......@@ -58,7 +58,7 @@ public:
QString selectedPushType() const;
QString selectedTopic() const;
QString reviewers() const;
bool valid() const;
bool isValid() const;
private slots:
void setChangeRange();
......@@ -76,7 +76,7 @@ private:
QString m_suggestedRemoteBranch;
Ui::GerritPushDialog *m_ui;
RemoteBranchesMap m_remoteBranches;
bool m_valid;
bool m_isValid;
Git::Internal::GitClient *m_client;
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment