From 2c91b3b744b7c88e6fb885d21f61e9677016250d Mon Sep 17 00:00:00 2001 From: Tobias Hunger <tobias.hunger@theqtcompany.com> Date: Mon, 3 Nov 2014 14:23:49 +0100 Subject: [PATCH] Subversion: Clean up commit message file after failed commit attempts This prevents creator from claiming there is a ongoing commit when trying to commit the next time. Task-number: QTCREATORBUG-13236 Change-Id: Iaeb27db2cbebdeaf97cd410c05cf88c5d437046b Reviewed-by: Orgad Shaneh <orgads@gmail.com> --- src/plugins/subversion/subversionplugin.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/subversion/subversionplugin.cpp b/src/plugins/subversion/subversionplugin.cpp index c9d3d8b6a54..ab61a121649 100644 --- a/src/plugins/subversion/subversionplugin.cpp +++ b/src/plugins/subversion/subversionplugin.cpp @@ -504,8 +504,8 @@ bool SubversionPlugin::submitEditorAboutToClose() VcsCommand *commitCmd = m_client->createCommitCmd(m_commitRepository, fileList, m_commitMessageFileName); - QObject::connect(commitCmd, SIGNAL(success(QVariant)), - this, SLOT(cleanCommitMessageFile())); + QObject::connect(commitCmd, &VcsCommand::finished, + this, [this]() { cleanCommitMessageFile(); }); commitCmd->execute(); } } -- GitLab