diff --git a/src/plugins/diffeditor/diffeditorplugin.cpp b/src/plugins/diffeditor/diffeditorplugin.cpp index 6ca9090f03d35275f2caab3964fb875d7724017e..a3a86b6d8f92c2b8ae4ec477b8c4da4e64fbee12 100644 --- a/src/plugins/diffeditor/diffeditorplugin.cpp +++ b/src/plugins/diffeditor/diffeditorplugin.cpp @@ -172,4 +172,14 @@ QString DiffEditorPlugin::getFileContents(const QString &fileName, QTextCodec *c } // namespace Internal } // namespace DiffEditor +#ifdef WITH_TESTS + +void DiffEditor::Internal::DiffEditorPlugin::testAssemblyRows() +{ + DiffEditorWidget widget; + widget.testAssemblyRows(); +} + +#endif // WITH_TESTS + Q_EXPORT_PLUGIN(DiffEditor::Internal::DiffEditorPlugin) diff --git a/src/plugins/diffeditor/diffeditorplugin.h b/src/plugins/diffeditor/diffeditorplugin.h index 8c1303d7a464588af921e749e9bd775f782e2c73..12b4b5bd1c47303a959c7981089d64ff15bf9fdf 100644 --- a/src/plugins/diffeditor/diffeditorplugin.h +++ b/src/plugins/diffeditor/diffeditorplugin.h @@ -65,6 +65,10 @@ public: private slots: void diff(); +#ifdef WITH_TESTS + void testAssemblyRows(); +#endif // WITH_TESTS + private: QString getFileContents(const QString &fileName, QTextCodec *codec) const; diff --git a/src/plugins/diffeditor/diffeditorwidget.cpp b/src/plugins/diffeditor/diffeditorwidget.cpp index 4bce0b3466244f114b22a9fcc3e38da395fdf182..97616375ea92d0f475833da0d124ccfdcb9a58c5 100644 --- a/src/plugins/diffeditor/diffeditorwidget.cpp +++ b/src/plugins/diffeditor/diffeditorwidget.cpp @@ -775,8 +775,10 @@ QList<TextLineData> DiffEditorWidget::assemblyRows(const QStringList &lines, { QList<TextLineData> data; + int previousSpanOffset = 0; int spanOffset = 0; int pos = 0; + bool usePreviousSpanOffsetForStartPosition = false; QMap<int, int>::ConstIterator changedIt = changedPositions.constBegin(); QMap<int, int>::ConstIterator changedEnd = changedPositions.constEnd(); const int lineCount = lines.count(); @@ -794,7 +796,17 @@ QList<TextLineData> DiffEditorWidget::assemblyRows(const QStringList &lines, if (changedIt.key() >= pos) break; - const int startPos = changedIt.key() + spanOffset; + if (changedIt.value() >= pos) { + usePreviousSpanOffsetForStartPosition = true; + previousSpanOffset = spanOffset; + break; + } + + const int startSpanOffset = usePreviousSpanOffsetForStartPosition + ? previousSpanOffset : spanOffset; + usePreviousSpanOffsetForStartPosition = false; + + const int startPos = changedIt.key() + startSpanOffset; const int endPos = changedIt.value() + spanOffset; if (outputChangedPositions) outputChangedPositions->insert(startPos, endPos); @@ -1550,4 +1562,30 @@ void DiffEditorWidget::synchronizeFoldings(DiffViewEditorWidget *source, DiffVie } // namespace DiffEditor +#ifdef WITH_TESTS +#include <QTest> + +void DiffEditor::DiffEditorWidget::testAssemblyRows() +{ + QStringList lines; + lines << QLatin1String("abcd efgh"); // line 0 + lines << QLatin1String("ijkl mnop"); // line 1 + + QMap<int, int> lineSpans; + lineSpans[1] = 6; // before line 1 insert 6 span lines + + QMap<int, int> changedPositions; + changedPositions[5] = 14; // changed text from position 5 to position 14, occupy 9 characters: "efgh\nijkl" + + QMap<int, int> expectedChangedPositions; + expectedChangedPositions[5] = 20; // "efgh\n[\n\n\n\n\n\n]ijkl" - [\n] means inserted span + + QMap<int, int> outputChangedPositions; + + assemblyRows(lines, lineSpans, changedPositions, &outputChangedPositions); + QVERIFY(outputChangedPositions == expectedChangedPositions); +} + +#endif // WITH_TESTS + #include "diffeditorwidget.moc" diff --git a/src/plugins/diffeditor/diffeditorwidget.h b/src/plugins/diffeditor/diffeditorwidget.h index 8e4973c7f64dbc8ce8e259d8cba11b8cd2abb0b7..28affe26c878cd2ddc935c679bafa15308140eb3 100644 --- a/src/plugins/diffeditor/diffeditorwidget.h +++ b/src/plugins/diffeditor/diffeditorwidget.h @@ -83,6 +83,10 @@ public: void setDiff(const QList<DiffFilesContents> &diffFileList, const QString &workingDirectory = QString()); QTextCodec *codec() const; +#ifdef WITH_TESTS + void testAssemblyRows(); +#endif // WITH_TESTS + public slots: void setContextLinesNumber(int lines); void setIgnoreWhitespaces(bool ignore);