Commit 3261128a authored by Kai Koehne's avatar Kai Koehne
Browse files

Debugger: Don't warn about never-hit breakpoints when loading a coredumps

Only check the breakpoints when app was started internally.

Change-Id: I38f0af08a2c137d44a127b254283574277b57eff
Reviewed-on: http://codereview.qt.nokia.com/2751

Reviewed-by: default avatarQt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: default avatarhjk <qthjk@ovi.com>
parent 65317dea
...@@ -249,20 +249,22 @@ void DebuggerRunControl::start() ...@@ -249,20 +249,22 @@ void DebuggerRunControl::start()
return; return;
} }
foreach (const BreakpointModelId &id, debuggerCore()->breakHandler()->allBreakpointIds()) { if (d->m_engine->startParameters().startMode == StartInternal) {
if (d->m_engine->breakHandler()->breakpointData(id).enabled foreach (const BreakpointModelId &id, debuggerCore()->breakHandler()->allBreakpointIds()) {
&& !d->m_engine->acceptsBreakpoint(id)) { if (d->m_engine->breakHandler()->breakpointData(id).enabled
&& !d->m_engine->acceptsBreakpoint(id)) {
QString warningMessage = QString warningMessage =
DebuggerPlugin::tr("Some breakpoints cannot be handled by the debugger " DebuggerPlugin::tr("Some breakpoints cannot be handled by the debugger "
"languages currently active, and will be ignored."); "languages currently active, and will be ignored.");
debuggerCore()->showMessage(warningMessage, LogWarning); debuggerCore()->showMessage(warningMessage, LogWarning);
QErrorMessage *msgBox = new QErrorMessage(debuggerCore()->mainWindow()); QErrorMessage *msgBox = new QErrorMessage(debuggerCore()->mainWindow());
msgBox->setAttribute(Qt::WA_DeleteOnClose); msgBox->setAttribute(Qt::WA_DeleteOnClose);
msgBox->showMessage(warningMessage); msgBox->showMessage(warningMessage);
break; break;
}
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment