Commit 38a5dedc authored by Laurent Desmecht's avatar Laurent Desmecht Committed by Thorbjørn Lindeijer
Browse files

Make GenericMakeStep not immutable

GenericMakeStep is currently immutable. This is quite annoying since
it's possible to create GenericMakeStep but it's not possible to remove

Fix: make GenericMakeStep not immutable

Merge-request: 117
Reviewed-by: default avatarThorbjørn Lindeijer <>
Reviewed-by: dt
Reviewed-by: Tobias Hunger
parent 5f9e4c7e
...@@ -177,14 +177,7 @@ ProjectExplorer::BuildStepConfigWidget *GenericMakeStep::createConfigWidget() ...@@ -177,14 +177,7 @@ ProjectExplorer::BuildStepConfigWidget *GenericMakeStep::createConfigWidget()
bool GenericMakeStep::immutable() const bool GenericMakeStep::immutable() const
{ {
// Only make one GenericMakeStep immutable: return false;
QList<BuildStep *> steps = buildConfiguration()->buildSteps();
int makestepCount = 0;
foreach (const BuildStep *bs, steps) {
if (qobject_cast<const GenericMakeStep *>(bs))
return makestepCount <= 1;
} }
bool GenericMakeStep::buildsTarget(const QString &target) const bool GenericMakeStep::buildsTarget(const QString &target) const
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment