Commit 3cd19a59 authored by Hugues Delorme's avatar Hugues Delorme

VcsBase: fix constness of VcsBaseClient member functions

Member functions VcsBaseClient::createCommand() and vcsSynchronousExec()
should be const (ie. read-only functions)

Change-Id: I4db75c9e23d9d1abf316ce1a4e222a5f3b339b13
Reviewed-by: default avatarTobias Hunger <>
parent e23ac6f6
......@@ -316,7 +316,7 @@ Utils::SynchronousProcessResponse VcsBaseClient::vcsSynchronousExec(
const QString &workingDirectory,
const QStringList &args,
unsigned flags,
QTextCodec *outputCodec)
QTextCodec *outputCodec) const
const QString binary = settings()->binaryPath();
const int timeoutSec = settings()->intValue(VcsBaseClientSettings::timeoutKey);
......@@ -603,7 +603,7 @@ QProcessEnvironment VcsBaseClient::processEnvironment() const
Command *VcsBaseClient::createCommand(const QString &workingDirectory,
VcsBase::VcsBaseEditorWidget *editor,
JobOutputBindMode mode)
JobOutputBindMode mode) const
Command *cmd = new Command(d->m_clientSettings->binaryPath(),
workingDirectory, processEnvironment());
......@@ -172,7 +172,7 @@ protected:
Utils::SynchronousProcessResponse vcsSynchronousExec(const QString &workingDir,
const QStringList &args,
unsigned flags = 0,
QTextCodec *outputCodec = 0);
QTextCodec *outputCodec = 0) const;
VcsBase::VcsBaseEditorWidget *createVcsEditor(Core::Id kind, QString title,
const QString &source, bool setSourceCodec,
const char *registerDynamicProperty,
......@@ -184,7 +184,7 @@ protected:
Command *createCommand(const QString &workingDirectory,
VcsBase::VcsBaseEditorWidget *editor = 0,
JobOutputBindMode mode = NoOutputBind);
JobOutputBindMode mode = NoOutputBind) const;
void enqueueJob(Command *cmd, const QStringList &args, Utils::ExitCodeInterpreter *interpreter = 0);
void resetCachedVcsInfo(const QString &workingDir);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment