Commit 43869721 authored by hjk's avatar hjk Committed by Eike Ziller

ProjectExplorer: Fix comparison with default-constructed Runnables

Regression was introduced with 3f11ef92.

The original check asserting 'that != 0' is still needed without
dynamic_cast, as d-pointer of 'other' can be statically 0 for
default-constructed Runnable objects.

Change-Id: Ibee898ffc61fb2f4a6a6276390fdf6d517fde546
Reviewed-by: Eike Ziller's avatarEike Ziller <eike.ziller@qt.io>
Reviewed-by: Tobias Hunger's avatarTobias Hunger <tobias.hunger@qt.io>
parent b06cc736
......@@ -173,6 +173,8 @@ public:
bool equals(const std::unique_ptr<ClonableConcept> &other) const override
{
if (!other.get())
return false;
if (other->typeId() != typeId())
return false;
auto that = static_cast<const ClonableModel<T> *>(other.get());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment