diff --git a/share/qtcreator/qmljsdebugger/jsdebuggeragent.cpp b/share/qtcreator/qmljsdebugger/jsdebuggeragent.cpp index a10c747b830d1f7f78810fdfff39cd4db41d6ac7..1ace46e2cd10003188590735d5e8546bd664a804 100644 --- a/share/qtcreator/qmljsdebugger/jsdebuggeragent.cpp +++ b/share/qtcreator/qmljsdebugger/jsdebuggeragent.cpp @@ -302,6 +302,8 @@ void JSDebuggerAgent::exceptionThrow(qint64 scriptId, bool hasHandler) { Q_UNUSED(scriptId); + Q_UNUSED(exception); + Q_UNUSED(hasHandler); // qDebug() << Q_FUNC_INFO << exception.toString() << hasHandler; #if 0 //sometimes, we get exceptions that we should just ignore. if (!hasHandler && state != Stopped) diff --git a/src/plugins/debugger/debuggerengine.cpp b/src/plugins/debugger/debuggerengine.cpp index 05302371620b262632760023bac36137caa19273..3d0c93632c530b397b575b5e4a0419ea113a2fe6 100644 --- a/src/plugins/debugger/debuggerengine.cpp +++ b/src/plugins/debugger/debuggerengine.cpp @@ -105,10 +105,10 @@ using namespace TextEditor; // /////////////////////////////////////////////////////////////////////// -DebuggerStartParameters::DebuggerStartParameters() - : attachPID(-1), - useTerminal(false), +DebuggerStartParameters::DebuggerStartParameters() : isSnapshot(false), + attachPID(-1), + useTerminal(false), breakAtMain(false), qmlServerAddress("127.0.0.1"), qmlServerPort(0), diff --git a/src/plugins/help/openpagesswitcher.cpp b/src/plugins/help/openpagesswitcher.cpp index 9c5705c5f5b6aba3bf0f14a8e145e831b891af41..f503939c9d723154a2dbcd14af3699d250277810 100644 --- a/src/plugins/help/openpagesswitcher.cpp +++ b/src/plugins/help/openpagesswitcher.cpp @@ -124,10 +124,10 @@ bool OpenPagesSwitcher::eventFilter(QObject *object, QEvent *event) emit setCurrentPage(m_openPagesWidget->currentIndex()); return true; } - - Qt::KeyboardModifier modifier = Qt::ControlModifier; #ifdef Q_WS_MAC - modifier = Qt::AltModifier; + const Qt::KeyboardModifier modifier = Qt::AltModifier; +#else + const Qt::KeyboardModifier modifier = Qt::ControlModifier; #endif if (key == Qt::Key_Backtab && (ke->modifiers() == (modifier | Qt::ShiftModifier))) diff --git a/src/plugins/projectexplorer/outputparser_test.cpp b/src/plugins/projectexplorer/outputparser_test.cpp index ab3b714ec82afd728a0e05a77e7bca2689601921..bd8323788927785474e7eee65a8ba26be9cf80bd 100644 --- a/src/plugins/projectexplorer/outputparser_test.cpp +++ b/src/plugins/projectexplorer/outputparser_test.cpp @@ -66,7 +66,7 @@ void OutputParserTester::testParsing(const QString &lines, } // first disconnect ourselves from the end of the parser chain again IOutputParser * parser = this; - while (parser = parser->childParser()) { + while ( (parser = parser->childParser()) ) { if (parser->childParser() == this) { childParser()->takeOutputParserChain(); break; diff --git a/src/plugins/qmljseditor/qmloutlinemodel.cpp b/src/plugins/qmljseditor/qmloutlinemodel.cpp index cabad859f667ca098604e28b92cc76401f9519d9..f6662b9f7509dc6cb525b6be76b72465bee240d6 100644 --- a/src/plugins/qmljseditor/qmloutlinemodel.cpp +++ b/src/plugins/qmljseditor/qmloutlinemodel.cpp @@ -727,7 +727,7 @@ void QmlOutlineModel::moveObjectMember(AST::UiObjectMember *toMove, } else { *addedRange = rewriter.addObject(arrayBinding, strToMove); } - } else if (AST::UiObjectBinding *objectBinding = AST::cast<AST::UiObjectBinding*>(newParent)) { + } else if (AST::cast<AST::UiObjectBinding*>(newParent)) { qDebug() << "TODO: Reparent to UiObjectBinding"; return; // target is a property diff --git a/src/plugins/qt4projectmanager/wizards/qmlstandaloneapp.cpp b/src/plugins/qt4projectmanager/wizards/qmlstandaloneapp.cpp index 84e1375f4c311411ba5df4687c25f1dd1c38264e..7b43c14c2084239032604c9ee1080f846fad05a4 100644 --- a/src/plugins/qt4projectmanager/wizards/qmlstandaloneapp.cpp +++ b/src/plugins/qt4projectmanager/wizards/qmlstandaloneapp.cpp @@ -634,7 +634,8 @@ static QList<GeneratedFileInfo> updateableFiles(const QString &mainProFile) {GeneratedFileInfo::AppViewerCppFile, appViewerHFileName} }; const QFileInfo mainProFileInfo(mainProFile); - for (int i = 0; i < sizeof files / sizeof files[0]; ++i) { + const int size = sizeof(files) / sizeof(files[0]); + for (int i = 0; i < size; ++i) { const QString fileName = mainProFileInfo.dir().absolutePath() + QLatin1Char('/') + appViewerOriginsSubDir + files[i].fileName; if (!QFile::exists(fileName)) diff --git a/src/plugins/texteditor/linenumberfilter.cpp b/src/plugins/texteditor/linenumberfilter.cpp index 6cbd99713a088a60bf7faf34a7c4bad2eaca34e5..710b5cebec554ed1ca668d6d9cbf7e98e30b11c1 100644 --- a/src/plugins/texteditor/linenumberfilter.cpp +++ b/src/plugins/texteditor/linenumberfilter.cpp @@ -48,7 +48,7 @@ LineNumberFilter::LineNumberFilter(QObject *parent) setIncludedByDefault(true); } -QList<FilterEntry> LineNumberFilter::matchesFor(QFutureInterface<Locator::FilterEntry> &future, const QString &entry) +QList<FilterEntry> LineNumberFilter::matchesFor(QFutureInterface<Locator::FilterEntry> &, const QString &entry) { bool ok; QList<FilterEntry> value;