Commit 4e3435a5 authored by Ulf Hermann's avatar Ulf Hermann
Browse files

Analyzer: Trigger stopIt() only once when pressing the stop button



The stopIt() slot is already connected in the constructor of
AnalyzerRunControl.

The double connection is clearly not intended and, considering that
various analyzers modify internal state from those callse, could lead
to incorrect behavior.

Change-Id: I1c68eb06729849771f4a25257a219c84a032adf3
Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
parent beac7b95
......@@ -454,7 +454,6 @@ static void startRemoteTool(IAnalyzerTool *tool, StartMode mode)
sp.analyzerPort = port;
AnalyzerRunControl *rc = tool->createRunControl(sp, 0);
QObject::connect(AnalyzerManager::stopAction(), SIGNAL(triggered()), rc, SLOT(stopIt()));
ProjectExplorerPlugin::startRunControl(rc, tool->runMode());
}
......
......@@ -150,7 +150,6 @@ static void startRemoteTool(IAnalyzerTool *tool)
sp.workingDirectory = dlg.workingDirectory();
AnalyzerRunControl *rc = tool->createRunControl(sp, 0);
QObject::connect(AnalyzerManager::stopAction(), SIGNAL(triggered()), rc, SLOT(stopIt()));
ProjectExplorerPlugin::startRunControl(rc, tool->runMode());
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment