diff --git a/src/plugins/projectexplorer/project.cpp b/src/plugins/projectexplorer/project.cpp index f246b09d9935021e5cbf6feac4d2f47d45b7da5f..0e031498cb859efc2457698511be0f4916d076e7 100644 --- a/src/plugins/projectexplorer/project.cpp +++ b/src/plugins/projectexplorer/project.cpp @@ -85,7 +85,7 @@ void Project::addBuildConfiguration(BuildConfiguration *configuration) // add it m_buildConfigurationValues.push_back(configuration); - emit addedBuildConfiguration(this, configuration); + emit addedBuildConfiguration(configuration); } void Project::removeBuildConfiguration(BuildConfiguration *configuration) @@ -96,7 +96,7 @@ void Project::removeBuildConfiguration(BuildConfiguration *configuration) m_buildConfigurationValues.removeOne(configuration); - emit removedBuildConfiguration(this, configuration); + emit removedBuildConfiguration(configuration); delete configuration; } diff --git a/src/plugins/projectexplorer/project.h b/src/plugins/projectexplorer/project.h index 730c1762db4bafac555b044a322a6f35e5b3cd6c..18e1617506f446b4da4cc9a4b4ad12adc53eb7ae 100644 --- a/src/plugins/projectexplorer/project.h +++ b/src/plugins/projectexplorer/project.h @@ -127,9 +127,7 @@ signals: void fileListChanged(); // TODO clean up signal names -// might be better to also have -// a aboutToRemoveRunConfiguration -// and a removedBuildConfiguration +// might be better to also have aboutToRemove signals // a runconfiguration display name changed is missing void activeBuildConfigurationChanged(); void activeRunConfigurationChanged(); @@ -138,8 +136,8 @@ signals: void removedRunConfiguration(ProjectExplorer::Project *p, const QString &name); void addedRunConfiguration(ProjectExplorer::Project *p, const QString &name); - void removedBuildConfiguration(ProjectExplorer::Project *p, ProjectExplorer::BuildConfiguration *bc); - void addedBuildConfiguration(ProjectExplorer::Project *p, ProjectExplorer::BuildConfiguration *bc); + void removedBuildConfiguration(ProjectExplorer::BuildConfiguration *bc); + void addedBuildConfiguration(ProjectExplorer::BuildConfiguration *bc); protected: /* This method is called when the project .user file is saved. Simply call diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp index 48d526e6ddf8f672439f75fff0edbcfb5e6d97ac..ff419e65be7ba440fa447a8c57edefb0c8287b3d 100644 --- a/src/plugins/projectexplorer/projectexplorer.cpp +++ b/src/plugins/projectexplorer/projectexplorer.cpp @@ -836,7 +836,6 @@ void ProjectExplorerPlugin::unloadProject() QList<Core::IFile*> filesToSave; filesToSave << fi; - // FIXME: What we want here is to check whether we need to safe any of the pro/pri files in this project // check the number of modified files int readonlycount = 0; diff --git a/src/plugins/projectexplorer/projectwindow.cpp b/src/plugins/projectexplorer/projectwindow.cpp index 1812a5e9fdfce37e8f6354c85a42cd2d50ee0cfd..2414782b1b565caddd01646c2b507fc52efe44a8 100644 --- a/src/plugins/projectexplorer/projectwindow.cpp +++ b/src/plugins/projectexplorer/projectwindow.cpp @@ -518,10 +518,10 @@ BuildConfigurationComboBox::BuildConfigurationComboBox(Project *p, QWidget *pare // this, SLOT(nameChanged(ProjectExplorer::BuildConfiguration *))); connect(p, SIGNAL(activeBuildConfigurationChanged()), this, SLOT(activeConfigurationChanged())); - connect(p, SIGNAL(addedBuildConfiguration(ProjectExplorer::Project*,ProjectExplorer::BuildConfiguration*)), - this, SLOT(addedBuildConfiguration(ProjectExplorer::Project*,ProjectExplorer::BuildConfiguration*))); - connect(p, SIGNAL(removedBuildConfiguration(ProjectExplorer::Project*,ProjectExplorer::BuildConfiguration*)), - this, SLOT(removedBuildConfiguration(ProjectExplorer::Project*,ProjectExplorer::BuildConfiguration*))); + connect(p, SIGNAL(addedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), + this, SLOT(addedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); + connect(p, SIGNAL(removedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), + this, SLOT(removedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); connect(m_comboBox, SIGNAL(activated(int)), this, SLOT(changedIndex(int))); } @@ -560,10 +560,8 @@ void BuildConfigurationComboBox::activeConfigurationChanged() ignoreIndexChange = false; } -void BuildConfigurationComboBox::addedBuildConfiguration(ProjectExplorer::Project *project, - ProjectExplorer::BuildConfiguration *bc) +void BuildConfigurationComboBox::addedBuildConfiguration(BuildConfiguration *bc) { - Q_UNUSED(project); ignoreIndexChange = true; m_comboBox->addItem(bc->displayName(), QVariant::fromValue(bc)); @@ -572,10 +570,8 @@ void BuildConfigurationComboBox::addedBuildConfiguration(ProjectExplorer::Projec ignoreIndexChange = false; } -void BuildConfigurationComboBox::removedBuildConfiguration(ProjectExplorer::Project *project, - BuildConfiguration * bc) +void BuildConfigurationComboBox::removedBuildConfiguration(BuildConfiguration * bc) { - Q_UNUSED(project); ignoreIndexChange = true; const int index(buildConfigurationToIndex(bc)); if (index == -1) diff --git a/src/plugins/projectexplorer/projectwindow.h b/src/plugins/projectexplorer/projectwindow.h index aec941d76641eac1b6c708592e7c92d383550e27..55e43cc2026d2b17232caebd8b76c3b9a9aea2b2 100644 --- a/src/plugins/projectexplorer/projectwindow.h +++ b/src/plugins/projectexplorer/projectwindow.h @@ -97,10 +97,8 @@ public: private slots: void nameChanged(BuildConfiguration *bc); void activeConfigurationChanged(); - void addedBuildConfiguration(ProjectExplorer::Project *project, - ProjectExplorer::BuildConfiguration *bc); - void removedBuildConfiguration(ProjectExplorer::Project *project, - ProjectExplorer::BuildConfiguration *bc); + void addedBuildConfiguration(ProjectExplorer::BuildConfiguration *bc); + void removedBuildConfiguration(ProjectExplorer::BuildConfiguration *bc); void changedIndex(int newIndex); private: int buildConfigurationToIndex(BuildConfiguration *bc);