Debugger: Code cosmetics

Change-Id: I52a0f5d842917459ba05a0423402ffebd640db61
Reviewed-by: hjk <hjk121@nokiamail.com>

src/plugins/debugger/debuggerconstants.h

@@ -64,9 +64,6 @@ const char QML_UPDATE_ON_SAVE[]     = "Debugger.QmlUpdateOnSave";
 const char QML_SELECTTOOL[]         = "Debugger.QmlSelectTool";
 const char QML_ZOOMTOOL[]           = "Debugger.QmlZoomTool";
 
-// VariableManager Prefix
-const char PrefixDebugExecutable[]  = "DebuggedExecutable";
-
 const char TASK_CATEGORY_DEBUGGER_DEBUGINFO[] = "Debuginfo";
 const char TASK_CATEGORY_DEBUGGER_RUNTIME[]   = "DebugRuntime";
 

src/plugins/debugger/debuggerengine.cpp

@@ -92,6 +92,9 @@ enum { debug = 0 };
 //
 ///////////////////////////////////////////////////////////////////////
 
+// VariableManager Prefix
+const char PrefixDebugExecutable[]  = "DebuggedExecutable";
+
 namespace Debugger {
 
 Internal::Location::Location(const StackFrame &frame, bool marker)
@@ -172,7 +175,7 @@ public:
         connect(&m_locationTimer, SIGNAL(timeout()), SLOT(resetLocation()));
         connect(debuggerCore()->action(IntelFlavor), SIGNAL(valueChanged(QVariant)),
                 SLOT(reloadDisassembly()));
-        VariableManager::registerFileVariables(Constants::PrefixDebugExecutable,
+        VariableManager::registerFileVariables(PrefixDebugExecutable,
                                                tr("Debugged executable"));
         connect(VariableManager::instance(), SIGNAL(variableUpdateRequested(QByteArray)),
                 SLOT(updateVariable(QByteArray)));
@@ -187,11 +190,11 @@ public slots:
     void doInterruptInferior();
     void doFinishDebugger();
 
-    void updateVariable(QByteArray variable)
+    void updateVariable(const QByteArray &variable)
     {
-        if (VariableManager::isFileVariable(variable, Constants::PrefixDebugExecutable))
-            VariableManager::insert(variable, VariableManager::fileVariableValue(variable,
-                     Constants::PrefixDebugExecutable, QFileInfo(m_startParameters.executable)));
+        if (VariableManager::isFileVariable(variable, PrefixDebugExecutable))
+            VariableManager::insert(variable,
+                VariableManager::fileVariableValue(variable, PrefixDebugExecutable, m_startParameters.executable));
     }
 
     void reloadDisassembly()