From 5652337785a449397b3c0465279764adf92fb0a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorbj=C3=B8rn=20Lindeijer?= <thorbjorn.lindeijer@nokia.com> Date: Wed, 14 Jul 2010 14:20:17 +0200 Subject: [PATCH] Some adjustments signed/unsigned --- src/plugins/cppeditor/cpphoverhandler.cpp | 12 ++++++------ src/plugins/cppeditor/cpphoverhandler.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/plugins/cppeditor/cpphoverhandler.cpp b/src/plugins/cppeditor/cpphoverhandler.cpp index 5524643c050..5c84e868412 100644 --- a/src/plugins/cppeditor/cpphoverhandler.cpp +++ b/src/plugins/cppeditor/cpphoverhandler.cpp @@ -232,10 +232,10 @@ void CppHoverHandler::identifyMatch(TextEditor::ITextEditor *editor, int pos) } bool CppHoverHandler::matchDiagnosticMessage(const CPlusPlus::Document::Ptr &document, - const int line) + unsigned line) { foreach (const Document::DiagnosticMessage &m, document->diagnosticMessages()) { - if (m.line() == unsigned(line)) { + if (m.line() == line) { m_toolTip = m.text(); return true; } @@ -243,10 +243,10 @@ bool CppHoverHandler::matchDiagnosticMessage(const CPlusPlus::Document::Ptr &doc return false; } -bool CppHoverHandler::matchIncludeFile(const CPlusPlus::Document::Ptr &document, const int line) +bool CppHoverHandler::matchIncludeFile(const CPlusPlus::Document::Ptr &document, unsigned line) { foreach (const Document::Include &includeFile, document->includes()) { - if (includeFile.line() == unsigned(line)) { + if (includeFile.line() == line) { m_toolTip = QDir::toNativeSeparators(includeFile.fileName()); const QString &fileName = QFileInfo(includeFile.fileName()).fileName(); m_helpCandidates.append(HelpCandidate(fileName, fileName, HelpCandidate::Include)); @@ -256,11 +256,11 @@ bool CppHoverHandler::matchIncludeFile(const CPlusPlus::Document::Ptr &document, return false; } -bool CppHoverHandler::matchMacroInUse(const CPlusPlus::Document::Ptr &document, const int pos) +bool CppHoverHandler::matchMacroInUse(const CPlusPlus::Document::Ptr &document, unsigned pos) { foreach (const Document::MacroUse &use, document->macroUses()) { if (use.contains(pos)) { - const int begin = use.begin(); + const unsigned begin = use.begin(); const QString &name = use.macro().name(); if (pos < begin + name.length()) { m_toolTip = use.macro().toString(); diff --git a/src/plugins/cppeditor/cpphoverhandler.h b/src/plugins/cppeditor/cpphoverhandler.h index 3ba7177c15a..84c58733d48 100644 --- a/src/plugins/cppeditor/cpphoverhandler.h +++ b/src/plugins/cppeditor/cpphoverhandler.h @@ -97,9 +97,9 @@ private: void resetMatchings(); void identifyMatch(TextEditor::ITextEditor *editor, int pos); - bool matchDiagnosticMessage(const CPlusPlus::Document::Ptr &document, const int line); - bool matchIncludeFile(const CPlusPlus::Document::Ptr &document, const int line); - bool matchMacroInUse(const CPlusPlus::Document::Ptr &document, const int pos); + bool matchDiagnosticMessage(const CPlusPlus::Document::Ptr &document, unsigned line); + bool matchIncludeFile(const CPlusPlus::Document::Ptr &document, unsigned line); + bool matchMacroInUse(const CPlusPlus::Document::Ptr &document, unsigned pos); void handleLookupItemMatch(const CPlusPlus::LookupItem &lookupItem, const bool assignTooltip); -- GitLab