Commit 5a041c51 authored by Daniel Teske's avatar Daniel Teske
Browse files

GenericProjectManager: Remove todos



Actually update the "Override make" label on toolchain changes
The makestep configuration widget being a friend of the step is not that
bad.

Change-Id: I5e88905cb0da99a4c1c28d8c56e669141e80ce17
Reviewed-by: default avatarDaniel Teske <daniel.teske@nokia.com>
parent ce62c4bf
...@@ -225,7 +225,6 @@ GenericMakeStepConfigWidget::GenericMakeStepConfigWidget(GenericMakeStep *makeSt ...@@ -225,7 +225,6 @@ GenericMakeStepConfigWidget::GenericMakeStepConfigWidget(GenericMakeStep *makeSt
m_ui = new Ui::GenericMakeStep; m_ui = new Ui::GenericMakeStep;
m_ui->setupUi(this); m_ui->setupUi(this);
// TODO update this list also on rescans of the GenericLists.txt
GenericProject *pro = static_cast<GenericProject *>(m_makeStep->target()->project()); GenericProject *pro = static_cast<GenericProject *>(m_makeStep->target()->project());
foreach (const QString &target, pro->buildTargets()) { foreach (const QString &target, pro->buildTargets()) {
QListWidgetItem *item = new QListWidgetItem(target, m_ui->targetsList); QListWidgetItem *item = new QListWidgetItem(target, m_ui->targetsList);
...@@ -249,6 +248,9 @@ GenericMakeStepConfigWidget::GenericMakeStepConfigWidget(GenericMakeStep *makeSt ...@@ -249,6 +248,9 @@ GenericMakeStepConfigWidget::GenericMakeStepConfigWidget(GenericMakeStep *makeSt
this, SLOT(updateMakeOverrrideLabel())); this, SLOT(updateMakeOverrrideLabel()));
connect(ProjectExplorer::ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()), connect(ProjectExplorer::ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()),
this, SLOT(updateDetails())); this, SLOT(updateDetails()));
connect(pro, SIGNAL(toolChainChanged(ProjectExplorer::ToolChain*)),
this, SLOT(updateMakeOverrrideLabel()));
} }
QString GenericMakeStepConfigWidget::displayName() const QString GenericMakeStepConfigWidget::displayName() const
...@@ -256,7 +258,6 @@ QString GenericMakeStepConfigWidget::displayName() const ...@@ -256,7 +258,6 @@ QString GenericMakeStepConfigWidget::displayName() const
return tr("Make", "GenericMakestep display name."); return tr("Make", "GenericMakestep display name.");
} }
// TODO: Label should update when tool chain is changed
void GenericMakeStepConfigWidget::updateMakeOverrrideLabel() void GenericMakeStepConfigWidget::updateMakeOverrrideLabel()
{ {
m_ui->makeLabel->setText(tr("Override %1:").arg(m_makeStep->makeCommand())); m_ui->makeLabel->setText(tr("Override %1:").arg(m_makeStep->makeCommand()));
......
...@@ -51,7 +51,7 @@ class GenericMakeStep : public ProjectExplorer::AbstractProcessStep ...@@ -51,7 +51,7 @@ class GenericMakeStep : public ProjectExplorer::AbstractProcessStep
{ {
Q_OBJECT Q_OBJECT
friend class GenericMakeStepConfigWidget; // TODO remove again? friend class GenericMakeStepConfigWidget;
friend class GenericMakeStepFactory; friend class GenericMakeStepFactory;
public: public:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment