Commit 5aedcb78 authored by Christian Kandeler's avatar Christian Kandeler
Browse files

Help plugin: Fix possible crash on documentation update.

We must not call updateFilterPage() when the "Options" dialog
is not currently open.
Without this patch, Creator will crash on a documentation update
if that dialog has been opened at least once and is currently closed.

Reviewed-by: kh1
Reviewed-by: con
parent e35c53e7
...@@ -247,6 +247,12 @@ void FilterSettingsPage::apply() ...@@ -247,6 +247,12 @@ void FilterSettingsPage::apply()
} }
} }
void FilterSettingsPage::finish()
{
disconnect(Core::HelpManager::instance(), SIGNAL(documentationChanged()),
this, SLOT(updateFilterPage()));
}
bool FilterSettingsPage::matches(const QString &s) const bool FilterSettingsPage::matches(const QString &s) const
{ {
return m_searchKeywords.contains(s, Qt::CaseInsensitive); return m_searchKeywords.contains(s, Qt::CaseInsensitive);
......
...@@ -52,7 +52,7 @@ public: ...@@ -52,7 +52,7 @@ public:
QWidget *createPage(QWidget *parent); QWidget *createPage(QWidget *parent);
void apply(); void apply();
void finish() {} void finish();
virtual bool matches(const QString &s) const; virtual bool matches(const QString &s) const;
signals: signals:
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment