Commit 5d5a4839 authored by hjk's avatar hjk
Browse files

genericprojectmanager: code cosmetic



White space, namespaces, include order, comments, literal style,
remove unneded include/declarations etc.

Change-Id: Ifcb4371699c5cde244be1610b67cf81915cad2b2
Reviewed-by: default avatarhjk <qthjk@ovi.com>
parent 58845266
...@@ -36,12 +36,13 @@ ...@@ -36,12 +36,13 @@
#include <coreplugin/mimedatabase.h> #include <coreplugin/mimedatabase.h>
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <QVBoxLayout> #include <QVBoxLayout>
#include <QLineEdit> #include <QLineEdit>
#include <QPushButton> #include <QPushButton>
using namespace GenericProjectManager; namespace GenericProjectManager {
using namespace GenericProjectManager::Internal; namespace Internal {
FilesSelectionWizardPage::FilesSelectionWizardPage(GenericProjectWizardDialog *genericProjectWizard, QWidget *parent) FilesSelectionWizardPage::FilesSelectionWizardPage(GenericProjectWizardDialog *genericProjectWizard, QWidget *parent)
: QWizardPage(parent), m_genericProjectWizardDialog(genericProjectWizard), m_model(0), m_finished(false) : QWizardPage(parent), m_genericProjectWizardDialog(genericProjectWizard), m_model(0), m_finished(false)
...@@ -143,3 +144,6 @@ void FilesSelectionWizardPage::applyFilter() ...@@ -143,3 +144,6 @@ void FilesSelectionWizardPage::applyFilter()
Core::ICore::settings()->setValue(Constants::FILEFILTER_SETTING, filter); Core::ICore::settings()->setValue(Constants::FILEFILTER_SETTING, filter);
m_model->applyFilter(filter); m_model->applyFilter(filter);
} }
} // namespace Internal
} // namespace GenericProjectManager
...@@ -37,23 +37,27 @@ ...@@ -37,23 +37,27 @@
namespace GenericProjectManager { namespace GenericProjectManager {
namespace Internal { namespace Internal {
class GenericProjectWizardDialog; class GenericProjectWizardDialog;
class SelectableFilesModel; class SelectableFilesModel;
class FilesSelectionWizardPage : public QWizardPage class FilesSelectionWizardPage : public QWizardPage
{ {
Q_OBJECT Q_OBJECT
public: public:
FilesSelectionWizardPage(GenericProjectWizardDialog *genericProjectWizard, QWidget *parent = 0); FilesSelectionWizardPage(GenericProjectWizardDialog *genericProjectWizard, QWidget *parent = 0);
virtual bool isComplete() const; bool isComplete() const;
virtual void initializePage(); void initializePage();
virtual void cleanupPage(); void cleanupPage();
QStringList selectedFiles() const; QStringList selectedFiles() const;
QStringList selectedPaths() const; QStringList selectedPaths() const;
private slots: private slots:
void applyFilter(); void applyFilter();
void parsingProgress(const QString &text); void parsingProgress(const QString &text);
void parsingFinished(); void parsingFinished();
private: private:
GenericProjectWizardDialog *m_genericProjectWizardDialog; GenericProjectWizardDialog *m_genericProjectWizardDialog;
SelectableFilesModel *m_model; SelectableFilesModel *m_model;
...@@ -65,6 +69,7 @@ private: ...@@ -65,6 +69,7 @@ private:
bool m_finished; bool m_finished;
}; };
} } // namespace Internal
} } // namespace GenericProjectManager
#endif // FILESSELECTIONWIZARDPAGE_H #endif // FILESSELECTIONWIZARDPAGE_H
...@@ -43,37 +43,31 @@ ...@@ -43,37 +43,31 @@
#include <QFormLayout> #include <QFormLayout>
#include <QInputDialog> #include <QInputDialog>
using namespace GenericProjectManager; using namespace ProjectExplorer;
using namespace GenericProjectManager::Internal;
using ProjectExplorer::BuildConfiguration;
namespace { namespace GenericProjectManager {
const char * const GENERIC_BC_ID("GenericProjectManager.GenericBuildConfiguration"); namespace Internal {
const char * const BUILD_DIRECTORY_KEY("GenericProjectManager.GenericBuildConfiguration.BuildDirectory"); const char GENERIC_BC_ID[] = "GenericProjectManager.GenericBuildConfiguration";
} const char BUILD_DIRECTORY_KEY[] = "GenericProjectManager.GenericBuildConfiguration.BuildDirectory";
GenericBuildConfiguration::GenericBuildConfiguration(ProjectExplorer::Target *parent) GenericBuildConfiguration::GenericBuildConfiguration(Target *parent)
: BuildConfiguration(parent, Core::Id(GENERIC_BC_ID)) : BuildConfiguration(parent, Core::Id(GENERIC_BC_ID))
{ {
} }
GenericBuildConfiguration::GenericBuildConfiguration(ProjectExplorer::Target *parent, const Core::Id id) GenericBuildConfiguration::GenericBuildConfiguration(Target *parent, const Core::Id id)
: BuildConfiguration(parent, id) : BuildConfiguration(parent, id)
{ {
} }
GenericBuildConfiguration::GenericBuildConfiguration(ProjectExplorer::Target *parent, GenericBuildConfiguration *source) : GenericBuildConfiguration::GenericBuildConfiguration(Target *parent, GenericBuildConfiguration *source) :
BuildConfiguration(parent, source), BuildConfiguration(parent, source),
m_buildDirectory(source->m_buildDirectory) m_buildDirectory(source->m_buildDirectory)
{ {
cloneSteps(source); cloneSteps(source);
} }
GenericBuildConfiguration::~GenericBuildConfiguration()
{
}
QVariantMap GenericBuildConfiguration::toMap() const QVariantMap GenericBuildConfiguration::toMap() const
{ {
QVariantMap map(BuildConfiguration::toMap()); QVariantMap map(BuildConfiguration::toMap());
...@@ -112,15 +106,14 @@ void GenericBuildConfiguration::setBuildDirectory(const QString &buildDirectory) ...@@ -112,15 +106,14 @@ void GenericBuildConfiguration::setBuildDirectory(const QString &buildDirectory)
emit buildDirectoryChanged(); emit buildDirectoryChanged();
} }
ProjectExplorer::BuildConfigWidget *GenericBuildConfiguration::createConfigWidget() BuildConfigWidget *GenericBuildConfiguration::createConfigWidget()
{ {
return new GenericBuildSettingsWidget; return new GenericBuildSettingsWidget;
} }
ProjectExplorer::IOutputParser *GenericBuildConfiguration::createOutputParser() const IOutputParser *GenericBuildConfiguration::createOutputParser() const
{ {
ProjectExplorer::ToolChain *tc = ToolChain *tc = ToolChainProfileInformation::toolChain(target()->profile());
ProjectExplorer::ToolChainProfileInformation::toolChain(target()->profile());
return tc ? tc->outputParser() : 0; return tc ? tc->outputParser() : 0;
} }
...@@ -130,7 +123,7 @@ ProjectExplorer::IOutputParser *GenericBuildConfiguration::createOutputParser() ...@@ -130,7 +123,7 @@ ProjectExplorer::IOutputParser *GenericBuildConfiguration::createOutputParser()
*/ */
GenericBuildConfigurationFactory::GenericBuildConfigurationFactory(QObject *parent) : GenericBuildConfigurationFactory::GenericBuildConfigurationFactory(QObject *parent) :
ProjectExplorer::IBuildConfigurationFactory(parent) IBuildConfigurationFactory(parent)
{ {
} }
...@@ -138,7 +131,7 @@ GenericBuildConfigurationFactory::~GenericBuildConfigurationFactory() ...@@ -138,7 +131,7 @@ GenericBuildConfigurationFactory::~GenericBuildConfigurationFactory()
{ {
} }
QList<Core::Id> GenericBuildConfigurationFactory::availableCreationIds(const ProjectExplorer::Target *parent) const QList<Core::Id> GenericBuildConfigurationFactory::availableCreationIds(const Target *parent) const
{ {
if (!canHandle(parent)) if (!canHandle(parent))
return QList<Core::Id>(); return QList<Core::Id>();
...@@ -152,7 +145,7 @@ QString GenericBuildConfigurationFactory::displayNameForId(const Core::Id id) co ...@@ -152,7 +145,7 @@ QString GenericBuildConfigurationFactory::displayNameForId(const Core::Id id) co
return QString(); return QString();
} }
bool GenericBuildConfigurationFactory::canCreate(const ProjectExplorer::Target *parent, const Core::Id id) const bool GenericBuildConfigurationFactory::canCreate(const Target *parent, const Core::Id id) const
{ {
if (!canHandle(parent)) if (!canHandle(parent))
return false; return false;
...@@ -161,7 +154,7 @@ bool GenericBuildConfigurationFactory::canCreate(const ProjectExplorer::Target * ...@@ -161,7 +154,7 @@ bool GenericBuildConfigurationFactory::canCreate(const ProjectExplorer::Target *
return false; return false;
} }
BuildConfiguration *GenericBuildConfigurationFactory::create(ProjectExplorer::Target *parent, const Core::Id id, const QString &name) BuildConfiguration *GenericBuildConfigurationFactory::create(Target *parent, const Core::Id id, const QString &name)
{ {
if (!canCreate(parent, id)) if (!canCreate(parent, id))
return 0; return 0;
...@@ -183,8 +176,8 @@ BuildConfiguration *GenericBuildConfigurationFactory::create(ProjectExplorer::Ta ...@@ -183,8 +176,8 @@ BuildConfiguration *GenericBuildConfigurationFactory::create(ProjectExplorer::Ta
GenericBuildConfiguration *bc = new GenericBuildConfiguration(parent); GenericBuildConfiguration *bc = new GenericBuildConfiguration(parent);
bc->setDisplayName(buildConfigurationName); bc->setDisplayName(buildConfigurationName);
ProjectExplorer::BuildStepList *buildSteps = bc->stepList(ProjectExplorer::Constants::BUILDSTEPS_BUILD); BuildStepList *buildSteps = bc->stepList(Constants::BUILDSTEPS_BUILD);
ProjectExplorer::BuildStepList *cleanSteps = bc->stepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN); BuildStepList *cleanSteps = bc->stepList(Constants::BUILDSTEPS_CLEAN);
Q_ASSERT(buildSteps); Q_ASSERT(buildSteps);
GenericMakeStep *makeStep = new GenericMakeStep(buildSteps); GenericMakeStep *makeStep = new GenericMakeStep(buildSteps);
...@@ -200,24 +193,24 @@ BuildConfiguration *GenericBuildConfigurationFactory::create(ProjectExplorer::Ta ...@@ -200,24 +193,24 @@ BuildConfiguration *GenericBuildConfigurationFactory::create(ProjectExplorer::Ta
return bc; return bc;
} }
bool GenericBuildConfigurationFactory::canClone(const ProjectExplorer::Target *parent, ProjectExplorer::BuildConfiguration *source) const bool GenericBuildConfigurationFactory::canClone(const Target *parent, BuildConfiguration *source) const
{ {
return canCreate(parent, source->id()); return canCreate(parent, source->id());
} }
BuildConfiguration *GenericBuildConfigurationFactory::clone(ProjectExplorer::Target *parent, BuildConfiguration *source) BuildConfiguration *GenericBuildConfigurationFactory::clone(Target *parent, BuildConfiguration *source)
{ {
if (!canClone(parent, source)) if (!canClone(parent, source))
return 0; return 0;
return new GenericBuildConfiguration(parent, qobject_cast<GenericBuildConfiguration *>(source)); return new GenericBuildConfiguration(parent, qobject_cast<GenericBuildConfiguration *>(source));
} }
bool GenericBuildConfigurationFactory::canRestore(const ProjectExplorer::Target *parent, const QVariantMap &map) const bool GenericBuildConfigurationFactory::canRestore(const Target *parent, const QVariantMap &map) const
{ {
return canCreate(parent, ProjectExplorer::idFromMap(map)); return canCreate(parent, ProjectExplorer::idFromMap(map));
} }
BuildConfiguration *GenericBuildConfigurationFactory::restore(ProjectExplorer::Target *parent, const QVariantMap &map) BuildConfiguration *GenericBuildConfigurationFactory::restore(Target *parent, const QVariantMap &map)
{ {
if (!canRestore(parent, map)) if (!canRestore(parent, map))
return 0; return 0;
...@@ -228,7 +221,7 @@ BuildConfiguration *GenericBuildConfigurationFactory::restore(ProjectExplorer::T ...@@ -228,7 +221,7 @@ BuildConfiguration *GenericBuildConfigurationFactory::restore(ProjectExplorer::T
return 0; return 0;
} }
bool GenericBuildConfigurationFactory::canHandle(const ProjectExplorer::Target *t) const bool GenericBuildConfigurationFactory::canHandle(const Target *t) const
{ {
if (!t->project()->supportsProfile(t->profile())) if (!t->project()->supportsProfile(t->profile()))
return false; return false;
...@@ -258,7 +251,9 @@ GenericBuildSettingsWidget::GenericBuildSettingsWidget() : m_buildConfiguration( ...@@ -258,7 +251,9 @@ GenericBuildSettingsWidget::GenericBuildSettingsWidget() : m_buildConfiguration(
} }
QString GenericBuildSettingsWidget::displayName() const QString GenericBuildSettingsWidget::displayName() const
{ return tr("Generic Manager"); } {
return tr("Generic Manager");
}
void GenericBuildSettingsWidget::init(BuildConfiguration *bc) void GenericBuildSettingsWidget::init(BuildConfiguration *bc)
{ {
...@@ -271,3 +266,6 @@ void GenericBuildSettingsWidget::buildDirectoryChanged() ...@@ -271,3 +266,6 @@ void GenericBuildSettingsWidget::buildDirectoryChanged()
{ {
m_buildConfiguration->setBuildDirectory(m_pathChooser->rawPath()); m_buildConfiguration->setBuildDirectory(m_pathChooser->rawPath());
} }
} // namespace Internal
} // namespace GenericProjectManager
...@@ -49,18 +49,15 @@ class GenericBuildConfiguration : public ProjectExplorer::BuildConfiguration ...@@ -49,18 +49,15 @@ class GenericBuildConfiguration : public ProjectExplorer::BuildConfiguration
public: public:
explicit GenericBuildConfiguration(ProjectExplorer::Target *parent); explicit GenericBuildConfiguration(ProjectExplorer::Target *parent);
virtual ~GenericBuildConfiguration();
ProjectExplorer::BuildConfigWidget *createConfigWidget(); ProjectExplorer::BuildConfigWidget *createConfigWidget();
virtual QString buildDirectory() const; QString buildDirectory() const;
QString rawBuildDirectory() const; QString rawBuildDirectory() const;
void setBuildDirectory(const QString &buildDirectory); void setBuildDirectory(const QString &buildDirectory);
QVariantMap toMap() const; QVariantMap toMap() const;
ProjectExplorer::IOutputParser *createOutputParser() const; ProjectExplorer::IOutputParser *createOutputParser() const;
BuildType buildType() const; BuildType buildType() const;
protected: protected:
...@@ -115,4 +112,5 @@ private: ...@@ -115,4 +112,5 @@ private:
} // namespace Internal } // namespace Internal
} // namespace GenericProjectManager } // namespace GenericProjectManager
#endif // GENERICBUILDCONFIGURATION_H #endif // GENERICBUILDCONFIGURATION_H
...@@ -46,41 +46,36 @@ ...@@ -46,41 +46,36 @@
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <utils/qtcprocess.h> #include <utils/qtcprocess.h>
#include <QFormLayout> using namespace Core;
#include <QGroupBox> using namespace ProjectExplorer;
#include <QCheckBox>
#include <QLineEdit>
#include <QListWidget>
using namespace GenericProjectManager; namespace GenericProjectManager {
using namespace GenericProjectManager::Internal; namespace Internal {
namespace { const char GENERIC_MS_ID[] = "GenericProjectManager.GenericMakeStep";
const char * const GENERIC_MS_ID("GenericProjectManager.GenericMakeStep"); const char GENERIC_MS_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("GenericProjectManager::Internal::GenericMakeStep",
const char * const GENERIC_MS_DISPLAY_NAME(QT_TRANSLATE_NOOP("GenericProjectManager::Internal::GenericMakeStep", "Make");
"Make"));
const char * const BUILD_TARGETS_KEY("GenericProjectManager.GenericMakeStep.BuildTargets"); const char BUILD_TARGETS_KEY[] = "GenericProjectManager.GenericMakeStep.BuildTargets";
const char * const MAKE_ARGUMENTS_KEY("GenericProjectManager.GenericMakeStep.MakeArguments"); const char MAKE_ARGUMENTS_KEY[] = "GenericProjectManager.GenericMakeStep.MakeArguments";
const char * const MAKE_COMMAND_KEY("GenericProjectManager.GenericMakeStep.MakeCommand"); const char MAKE_COMMAND_KEY[] = "GenericProjectManager.GenericMakeStep.MakeCommand";
const char * const CLEAN_KEY("GenericProjectManager.GenericMakeStep.Clean"); const char CLEAN_KEY[] = "GenericProjectManager.GenericMakeStep.Clean";
}
GenericMakeStep::GenericMakeStep(ProjectExplorer::BuildStepList *parent) : GenericMakeStep::GenericMakeStep(BuildStepList *parent) :
AbstractProcessStep(parent, Core::Id(GENERIC_MS_ID)), AbstractProcessStep(parent, Id(GENERIC_MS_ID)),
m_clean(false) m_clean(false)
{ {
ctor(); ctor();
} }
GenericMakeStep::GenericMakeStep(ProjectExplorer::BuildStepList *parent, const Core::Id id) : GenericMakeStep::GenericMakeStep(BuildStepList *parent, const Id id) :
AbstractProcessStep(parent, id), AbstractProcessStep(parent, id),
m_clean(false) m_clean(false)
{ {
ctor(); ctor();
} }
GenericMakeStep::GenericMakeStep(ProjectExplorer::BuildStepList *parent, GenericMakeStep *bs) : GenericMakeStep::GenericMakeStep(BuildStepList *parent, GenericMakeStep *bs) :
AbstractProcessStep(parent, bs), AbstractProcessStep(parent, bs),
m_buildTargets(bs->m_buildTargets), m_buildTargets(bs->m_buildTargets),
m_makeArguments(bs->m_makeArguments), m_makeArguments(bs->m_makeArguments),
...@@ -111,7 +106,7 @@ bool GenericMakeStep::init() ...@@ -111,7 +106,7 @@ bool GenericMakeStep::init()
if (!bc) if (!bc)
bc = static_cast<GenericBuildConfiguration *>(target()->activeBuildConfiguration()); bc = static_cast<GenericBuildConfiguration *>(target()->activeBuildConfiguration());
ProjectExplorer::ProcessParameters *pp = processParameters(); ProcessParameters *pp = processParameters();
pp->setMacroExpander(bc->macroExpander()); pp->setMacroExpander(bc->macroExpander());
pp->setWorkingDirectory(bc->buildDirectory()); pp->setWorkingDirectory(bc->buildDirectory());
pp->setEnvironment(bc->environment()); pp->setEnvironment(bc->environment());
...@@ -123,9 +118,8 @@ bool GenericMakeStep::init() ...@@ -123,9 +118,8 @@ bool GenericMakeStep::init()
// That is mostly so that rebuild works on an already clean project // That is mostly so that rebuild works on an already clean project
setIgnoreReturnValue(m_clean); setIgnoreReturnValue(m_clean);
setOutputParser(new ProjectExplorer::GnuMakeParser()); setOutputParser(new GnuMakeParser());
ProjectExplorer::ToolChain *tc = ToolChain *tc = ToolChainProfileInformation::toolChain(bc->target()->profile());
ProjectExplorer::ToolChainProfileInformation::toolChain(bc->target()->profile());
if (tc) if (tc)
appendOutputParser(tc->outputParser()); appendOutputParser(tc->outputParser());
outputParser()->setWorkingDirectory(pp->effectiveWorkingDirectory()); outputParser()->setWorkingDirectory(pp->effectiveWorkingDirectory());
...@@ -175,7 +169,7 @@ QString GenericMakeStep::makeCommand() const ...@@ -175,7 +169,7 @@ QString GenericMakeStep::makeCommand() const
{ {
QString command = m_makeCommand; QString command = m_makeCommand;
if (command.isEmpty()) { if (command.isEmpty()) {
ProjectExplorer::ToolChain *tc = ProjectExplorer::ToolChainProfileInformation::toolChain(target()->profile()); ToolChain *tc = ToolChainProfileInformation::toolChain(target()->profile());
if (tc) if (tc)
command = tc->makeCommand(); command = tc->makeCommand();
else else
...@@ -189,7 +183,7 @@ void GenericMakeStep::run(QFutureInterface<bool> &fi) ...@@ -189,7 +183,7 @@ void GenericMakeStep::run(QFutureInterface<bool> &fi)
AbstractProcessStep::run(fi); AbstractProcessStep::run(fi);
} }
ProjectExplorer::BuildStepConfigWidget *GenericMakeStep::createConfigWidget() BuildStepConfigWidget *GenericMakeStep::createConfigWidget()
{ {
return new GenericMakeStepConfigWidget(this); return new GenericMakeStepConfigWidget(this);
} }
...@@ -244,9 +238,9 @@ GenericMakeStepConfigWidget::GenericMakeStepConfigWidget(GenericMakeStep *makeSt ...@@ -244,9 +238,9 @@ GenericMakeStepConfigWidget::GenericMakeStepConfigWidget(GenericMakeStep *makeSt
connect(m_ui->makeArgumentsLineEdit, SIGNAL(textEdited(QString)), connect(m_ui->makeArgumentsLineEdit, SIGNAL(textEdited(QString)),
this, SLOT(makeArgumentsLineEditTextEdited())); this, SLOT(makeArgumentsLineEditTextEdited()));
connect(ProjectExplorer::ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()), connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()),
this, SLOT(updateMakeOverrrideLabel())); this, SLOT(updateMakeOverrrideLabel()));
connect(ProjectExplorer::ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()), connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()),
this, SLOT(updateDetails())); this, SLOT(updateDetails()));
connect(m_makeStep->target(), SIGNAL(profileChanged()), connect(m_makeStep->target(), SIGNAL(profileChanged()),
...@@ -274,7 +268,7 @@ void GenericMakeStepConfigWidget::updateDetails() ...@@ -274,7 +268,7 @@ void GenericMakeStepConfigWidget::updateDetails()
if (!bc) if (!bc)
bc = static_cast<GenericBuildConfiguration *>(m_makeStep->target()->activeBuildConfiguration()); bc = static_cast<GenericBuildConfiguration *>(m_makeStep->target()->activeBuildConfiguration());
ProjectExplorer::ProcessParameters param; ProcessParameters param;
param.setMacroExpander(bc->macroExpander()); param.setMacroExpander(bc->macroExpander());
param.setWorkingDirectory(bc->buildDirectory()); param.setWorkingDirectory(bc->buildDirectory());
param.setEnvironment(bc->environment()); param.setEnvironment(bc->environment());
...@@ -312,24 +306,18 @@ void GenericMakeStepConfigWidget::makeArgumentsLineEditTextEdited() ...@@ -312,24 +306,18 @@ void GenericMakeStepConfigWidget::makeArgumentsLineEditTextEdited()
// //
GenericMakeStepFactory::GenericMakeStepFactory(QObject *parent) : GenericMakeStepFactory::GenericMakeStepFactory(QObject *parent) :
ProjectExplorer::IBuildStepFactory(parent) IBuildStepFactory(parent)
{ {
} }
GenericMakeStepFactory::~GenericMakeStepFactory() bool GenericMakeStepFactory::canCreate(BuildStepList *parent, const Id id) const
{
}
bool GenericMakeStepFactory::canCreate(ProjectExplorer::BuildStepList *parent,
const Core::Id id) const
{ {
if (parent->target()->project()->id() == Constants::GENERICPROJECT_ID) if (parent->target()->project()->id() == Constants::GENERICPROJECT_ID)
return id == GENERIC_MS_ID; return id == GENERIC_MS_ID;
return false; return false;
} }
ProjectExplorer::BuildStep *GenericMakeStepFactory::create(ProjectExplorer::BuildStepList *parent, BuildStep *GenericMakeStepFactory::create(BuildStepList *parent, const Id id)
const Core::Id id)
{ {
if (!canCreate(parent, id)) if (!canCreate(parent, id))
return 0; return 0;
...@@ -343,14 +331,12 @@ ProjectExplorer::BuildStep *GenericMakeStepFactory::create(ProjectExplorer::Buil ...@@ -343,14 +331,12 @@ ProjectExplorer::BuildStep *GenericMakeStepFactory::create(ProjectExplorer::Buil
return step; return step;
} }
bool GenericMakeStepFactory::canClone(ProjectExplorer::BuildStepList *parent, bool GenericMakeStepFactory::canClone(BuildStepList *parent, BuildStep *source) const
ProjectExplorer::BuildStep *source) const
{ {
return canCreate(parent, source->id()); return canCreate(parent, source->id());