Commit 640d1269 authored by Marco Bubke's avatar Marco Bubke

Utils: Optimize Small String comparison a little bit

Change-Id: I798d4c399b1aced566e9b302463fd6491c04e8a1
Reviewed-by: default avatarTobias Hunger <tobias.hunger@theqtcompany.com>
parent 4ec10b55
......@@ -673,23 +673,15 @@ bool operator==(Type first, const SmallString& second) noexcept
inline
bool operator==(const SmallString& first, const SmallString& second) noexcept
{
if (Q_LIKELY(first.size() != second.size()))
return false;
const int comparison = std::memcmp(first.data(), second.data(), first.size());
return comparison == 0;
return first.size() == second.size()
&& std::memcmp(first.data(), second.data(), first.size()) == 0;
}
inline
bool operator==(const SmallString& first, const SmallStringView& second) noexcept
{
if (Q_LIKELY(first.size() != second.size()))
return false;
const int comparison = std::memcmp(first.data(), second.data(), first.size());
return comparison == 0;
return first.size() == second.size()
&& std::memcmp(first.data(), second.data(), first.size()) == 0;
}
inline
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment