Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
F
flatpak-qt-creator
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Marco Bubke
flatpak-qt-creator
Commits
6db7426d
Commit
6db7426d
authored
Apr 08, 2011
by
Tobias Hunger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix warning about signed/unsigned comparison
Use int instead of unsigned and do some code cosmetics while at it.
parent
9043b8e7
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
6 deletions
+6
-6
src/libs/utils/submiteditorwidget.cpp
src/libs/utils/submiteditorwidget.cpp
+5
-5
src/libs/utils/submiteditorwidget.h
src/libs/utils/submiteditorwidget.h
+1
-1
No files found.
src/libs/utils/submiteditorwidget.cpp
View file @
6db7426d
...
...
@@ -518,7 +518,7 @@ void SubmitEditorWidget::updateDiffAction()
void
SubmitEditorWidget
::
updateCheckAllComboBox
()
{
m_d
->
m_ignoreChange
=
true
;
unsigned
checkedCount
=
checkedFilesCount
();
int
checkedCount
=
checkedFilesCount
();
if
(
checkedCount
==
0
)
m_d
->
m_ui
.
checkAllCheckBox
->
setCheckState
(
Qt
::
Unchecked
);
else
if
(
checkedCount
==
m_d
->
m_ui
.
fileView
->
model
()
->
rowCount
())
...
...
@@ -536,14 +536,14 @@ bool SubmitEditorWidget::hasSelection() const
return
false
;
}
unsigned
SubmitEditorWidget
::
checkedFilesCount
()
const
int
SubmitEditorWidget
::
checkedFilesCount
()
const
{
unsigned
checkedCount
=
0
;
int
checkedCount
=
0
;
if
(
const
QAbstractItemModel
*
model
=
m_d
->
m_ui
.
fileView
->
model
())
{
const
int
count
=
model
->
rowCount
();
for
(
int
i
=
0
;
i
<
count
;
i
++
)
for
(
int
i
=
0
;
i
<
count
;
++
i
)
if
(
listModelChecked
(
model
,
i
,
checkableColumn
))
checkedCount
++
;
++
checkedCount
;
}
return
checkedCount
;
}
...
...
src/libs/utils/submiteditorwidget.h
View file @
6db7426d
...
...
@@ -145,7 +145,7 @@ private slots:
private:
bool
hasSelection
()
const
;
unsigned
checkedFilesCount
()
const
;
int
checkedFilesCount
()
const
;
SubmitEditorWidgetPrivate
*
m_d
;
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment