From 6e7e6acba4f64e9704774d15e12a823d158da801 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@nokia.com>
Date: Wed, 16 May 2012 12:50:31 +0200
Subject: [PATCH] Remove some old TODO items
Change-Id: I43c893176e5a83530f909371fc143dbb0cafd3ba
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
src/libs/utils/fancymainwindow.cpp | 2 +-
src/plugins/bineditor/bineditorplugin.cpp | 4 ++--
src/plugins/coreplugin/editormanager/editormanager.cpp | 2 +-
src/plugins/coreplugin/editormanager/editorview.cpp | 2 +-
src/plugins/coreplugin/progressmanager/progressbar.h | 1 -
src/plugins/coreplugin/rightpane.cpp | 2 +-
src/plugins/find/searchresulttreemodel.cpp | 7 -------
7 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/libs/utils/fancymainwindow.cpp b/src/libs/utils/fancymainwindow.cpp
index 1302567c884..965c8e1c342 100644
--- a/src/libs/utils/fancymainwindow.cpp
+++ b/src/libs/utils/fancymainwindow.cpp
@@ -64,7 +64,7 @@ struct FancyMainWindowPrivate
FancyMainWindowPrivate();
bool m_locked;
- bool m_handleDockVisibilityChanges; //todo
+ bool m_handleDockVisibilityChanges;
QAction m_menuSeparator1;
QAction m_toggleLockedAction;
diff --git a/src/plugins/bineditor/bineditorplugin.cpp b/src/plugins/bineditor/bineditorplugin.cpp
index cc7ccdeba7a..02bad814e78 100644
--- a/src/plugins/bineditor/bineditorplugin.cpp
+++ b/src/plugins/bineditor/bineditorplugin.cpp
@@ -375,8 +375,8 @@ public:
bool duplicateSupported() const { return false; }
IEditor *duplicate(QWidget * /* parent */) { return 0; }
- QByteArray saveState() const { return QByteArray(); } // TODO
- bool restoreState(const QByteArray & /* state */) { return false; } // TODO
+ QByteArray saveState() const { return QByteArray(); } // not supported
+ bool restoreState(const QByteArray & /* state */) { return false; } // not supported
QWidget *toolBar() { return m_toolBar; }
diff --git a/src/plugins/coreplugin/editormanager/editormanager.cpp b/src/plugins/coreplugin/editormanager/editormanager.cpp
index dc9c82b4651..d9ab7b9ef23 100644
--- a/src/plugins/coreplugin/editormanager/editormanager.cpp
+++ b/src/plugins/coreplugin/editormanager/editormanager.cpp
@@ -1588,7 +1588,7 @@ bool EditorManager::saveDocumentAs(IDocument *documentParam)
const bool success = DocumentManager::saveDocument(document, absoluteFilePath);
document->checkPermissions();
- // @todo: There is an issue to be treated here. The new file might be of a different mime
+ // TODO: There is an issue to be treated here. The new file might be of a different mime
// type than the original and thus require a different editor. An alternative strategy
// would be to close the current editor and open a new appropriate one, but this is not
// a good way out either (also the undo stack would be lost). Perhaps the best is to
diff --git a/src/plugins/coreplugin/editormanager/editorview.cpp b/src/plugins/coreplugin/editormanager/editorview.cpp
index c58ad38e1f1..a45beca58a4 100644
--- a/src/plugins/coreplugin/editormanager/editorview.cpp
+++ b/src/plugins/coreplugin/editormanager/editorview.cpp
@@ -264,7 +264,7 @@ void EditorView::setCurrentEditor(IEditor *editor)
|| m_container->indexOf(editor->widget()) == -1) {
m_toolBar->updateEditorStatus(0);
m_infoBarDisplay->setInfoBar(0);
- // ### TODO the combo box m_editorList should show an empty item
+ QTC_CHECK(m_container->count() == 0);
return;
}
diff --git a/src/plugins/coreplugin/progressmanager/progressbar.h b/src/plugins/coreplugin/progressmanager/progressbar.h
index 5e14bc7faf9..f290618b111 100644
--- a/src/plugins/coreplugin/progressmanager/progressbar.h
+++ b/src/plugins/coreplugin/progressmanager/progressbar.h
@@ -51,7 +51,6 @@ public:
QString title() const;
void setTitle(const QString &title);
- // TODO rename setError
void setError(bool on);
bool hasError() const;
QSize sizeHint() const;
diff --git a/src/plugins/coreplugin/rightpane.cpp b/src/plugins/coreplugin/rightpane.cpp
index 4c29c7c43fe..af340be3322 100644
--- a/src/plugins/coreplugin/rightpane.cpp
+++ b/src/plugins/coreplugin/rightpane.cpp
@@ -182,7 +182,7 @@ void RightPaneWidget::readSettings(QSettings *settings)
if (settings->contains(QLatin1String("RightPane/Visible"))) {
setShown(settings->value(QLatin1String("RightPane/Visible")).toBool());
} else {
- setShown(false); //TODO set to false
+ setShown(false);
}
if (settings->contains(QLatin1String("RightPane/Width"))) {
diff --git a/src/plugins/find/searchresulttreemodel.cpp b/src/plugins/find/searchresulttreemodel.cpp
index f4f4caf7f50..2e697ae5fad 100644
--- a/src/plugins/find/searchresulttreemodel.cpp
+++ b/src/plugins/find/searchresulttreemodel.cpp
@@ -273,13 +273,6 @@ QVariant SearchResultTreeModel::data(const SearchResultTreeItem *row, int role)
case ItemDataRoles::IsGeneratedRole:
result = row->isGenerated();
break;
-// TODO this looks stupid in case of symbol tree, is it necessary?
-// case Qt::BackgroundRole:
-// if (row->parent() && row->parent()->parent())
-// result = QVariant();
-// else
-// result = QApplication::palette().base().color().darker(105);
-// break;
default:
result = QVariant();
break;
--
GitLab