Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Marco Bubke
flatpak-qt-creator
Commits
75ee5bce
Commit
75ee5bce
authored
Nov 26, 2010
by
hjk
Browse files
debugger: make DebuggerEngine::acceptsBreakpoint(id) pure
parent
7d8d5167
Changes
12
Hide whitespace changes
Inline
Side-by-side
src/plugins/debugger/debuggerengine.cpp
View file @
75ee5bce
...
...
@@ -1237,11 +1237,6 @@ void DebuggerEngine::attemptBreakpointSynchronization()
d
->
m_disassemblerViewAgent
.
updateBreakpointMarkers
();
}
bool
DebuggerEngine
::
acceptsBreakpoint
(
BreakpointId
)
const
{
return
true
;
}
void
DebuggerEngine
::
insertBreakpoint
(
BreakpointId
)
{
QTC_ASSERT
(
false
,
/**/
);
...
...
src/plugins/debugger/debuggerengine.h
View file @
75ee5bce
...
...
@@ -188,7 +188,7 @@ public:
virtual
bool
stateAcceptsBreakpointChanges
()
const
{
return
true
;
}
virtual
void
attemptBreakpointSynchronization
();
virtual
bool
acceptsBreakpoint
(
BreakpointId
id
)
const
;
// FIXME: make pure
virtual
bool
acceptsBreakpoint
(
BreakpointId
id
)
const
=
0
;
virtual
void
insertBreakpoint
(
BreakpointId
id
);
// FIXME: make pure
virtual
void
removeBreakpoint
(
BreakpointId
id
);
// FIXME: make pure
virtual
void
changeBreakpoint
(
BreakpointId
id
);
// FIXME: make pure
...
...
src/plugins/debugger/debuggerplugin.cpp
View file @
75ee5bce
...
...
@@ -475,15 +475,16 @@ class DummyEngine : public DebuggerEngine
public:
DummyEngine
()
:
DebuggerEngine
(
DebuggerStartParameters
())
{}
virtual
~
DummyEngine
()
{}
virtual
void
setupEngine
()
{}
virtual
void
setupInferior
()
{}
virtual
void
runEngine
()
{}
virtual
void
shutdownEngine
()
{}
virtual
void
shutdownInferior
()
{}
virtual
void
executeDebuggerCommand
(
const
QString
&
)
{}
virtual
unsigned
debuggerCapabilities
()
const
{
return
0
;
}
~
DummyEngine
()
{}
void
setupEngine
()
{}
void
setupInferior
()
{}
void
runEngine
()
{}
void
shutdownEngine
()
{}
void
shutdownInferior
()
{}
void
executeDebuggerCommand
(
const
QString
&
)
{}
unsigned
debuggerCapabilities
()
const
{
return
0
;
}
bool
acceptsBreakpoint
(
BreakpointId
)
const
{
return
false
;
}
};
static
DebuggerEngine
*
dummyEngine
()
...
...
src/plugins/debugger/lldb/ipcenginehost.h
View file @
75ee5bce
...
...
@@ -104,6 +104,7 @@ public:
void
activateFrame
(
int
index
);
void
selectThread
(
int
index
);
void
fetchDisassembler
(
DisassemblerViewAgent
*
);
bool
acceptsBreakpoint
(
BreakpointId
)
const
{
return
true
;
}
// FIXME
void
insertBreakpoint
(
BreakpointId
id
);
void
removeBreakpoint
(
BreakpointId
id
);
void
changeBreakpoint
(
BreakpointId
id
);
...
...
src/plugins/debugger/lldb/lldbenginehost.cpp
View file @
75ee5bce
...
...
@@ -96,7 +96,7 @@ LLDBEngineHost::~LLDBEngineHost()
m_guestp
->
kill
();
}
void
LLDBEngineHost
::
finished
(
int
,
QProcess
::
ExitStatus
)
void
LLDBEngineHost
::
finished
(
int
,
QProcess
::
ExitStatus
)
{
showStatusMessage
(
QLatin1String
(
"lldb crashed"
));
notifyEngineIll
();
...
...
src/plugins/debugger/qml/qmlcppengine.cpp
View file @
75ee5bce
...
...
@@ -242,7 +242,7 @@ void QmlCppEngine::attemptBreakpointSynchronization()
static_cast
<
DebuggerEngine
*>
(
d
->
m_qmlEngine
)
->
attemptBreakpointSynchronization
();
}
bool
QmlCppEngine
::
acceptsBreakpoint
(
BreakpointId
id
)
bool
QmlCppEngine
::
acceptsBreakpoint
(
BreakpointId
id
)
const
{
return
d
->
m_cppEngine
->
acceptsBreakpoint
(
id
)
||
d
->
m_qmlEngine
->
acceptsBreakpoint
(
id
);
...
...
src/plugins/debugger/qml/qmlcppengine.h
View file @
75ee5bce
...
...
@@ -56,10 +56,10 @@ public:
virtual
void
updateAll
();
virtual
void
attemptBreakpointSynchronization
();
virtual
bool
acceptsBreakpoint
(
BreakpointId
id
);
virtual
bool
acceptsBreakpoint
(
BreakpointId
id
)
const
;
virtual
void
selectThread
(
int
index
);
virtual
void
assignValueInDebugger
(
const
Internal
::
WatchData
*
w
,
virtual
void
assignValueInDebugger
(
const
Internal
::
WatchData
*
data
,
const
QString
&
expr
,
const
QVariant
&
value
);
QAbstractItemModel
*
modulesModel
()
const
;
...
...
src/plugins/debugger/qml/qmlengine.cpp
View file @
75ee5bce
...
...
@@ -494,7 +494,7 @@ void QmlEngine::attemptBreakpointSynchronization()
sendMessage
(
reply
);
}
bool
QmlEngine
::
acceptsBreakpoint
(
BreakpointId
id
)
bool
QmlEngine
::
acceptsBreakpoint
(
BreakpointId
id
)
const
{
const
QString
fileName
=
breakHandler
()
->
fileName
(
id
);
return
fileName
.
endsWith
(
QLatin1String
(
".qml"
))
...
...
src/plugins/debugger/qml/qmlengine.h
View file @
75ee5bce
...
...
@@ -93,7 +93,7 @@ private:
void
selectThread
(
int
index
);
void
attemptBreakpointSynchronization
();
bool
acceptsBreakpoint
(
BreakpointId
id
);
bool
acceptsBreakpoint
(
BreakpointId
id
)
const
;
void
assignValueInDebugger
(
const
Internal
::
WatchData
*
data
,
const
QString
&
expr
,
const
QVariant
&
value
);
...
...
src/plugins/debugger/script/scriptengine.cpp
View file @
75ee5bce
...
...
@@ -447,6 +447,12 @@ void ScriptEngine::selectThread(int index)
Q_UNUSED
(
index
)
}
bool
ScriptEngine
::
acceptsBreakpoint
(
BreakpointId
id
)
const
{
const
QString
fileName
=
breakHandler
()
->
fileName
(
id
);
return
fileName
.
endsWith
(
QLatin1String
(
".js"
));
}
void
ScriptEngine
::
attemptBreakpointSynchronization
()
{
QTC_ASSERT
(
false
,
/* FIXME */
);
...
...
src/plugins/debugger/script/scriptengine.h
View file @
75ee5bce
...
...
@@ -87,6 +87,7 @@ private:
void
activateFrame
(
int
index
);
void
selectThread
(
int
index
);
bool
acceptsBreakpoint
(
BreakpointId
id
)
const
;
void
attemptBreakpointSynchronization
();
void
assignValueInDebugger
(
const
WatchData
*
w
,
...
...
src/plugins/debugger/tcf/tcfengine.h
View file @
75ee5bce
...
...
@@ -92,8 +92,10 @@ private:
void
selectThread
(
int
index
);
void
attemptBreakpointSynchronization
();
bool
acceptsBreakpoint
(
BreakpointId
)
const
{
return
false
;
}
void
assignValueInDebugger
(
const
Internal
::
WatchData
*
w
,
const
QString
&
expr
,
const
QVariant
&
value
);
void
assignValueInDebugger
(
const
WatchData
*
data
,
const
QString
&
expr
,
const
QVariant
&
value
);
void
executeDebuggerCommand
(
const
QString
&
command
);
void
loadSymbols
(
const
QString
&
moduleName
);
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment