From 7ca93f9b1e728b99a0a4d554733a1fa31e6ab4d9 Mon Sep 17 00:00:00 2001
From: hjk <qthjk@ovi.com>
Date: Fri, 3 Aug 2012 14:33:10 +0200
Subject: [PATCH] coreid: add overload for ==(const char *)
Saves code on caller side and cycles for the hashing.
Change-Id: I9d0c739b44a4611a4d70d33cf2798e0b078a72b5
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
src/plugins/coreplugin/id.cpp | 7 ++++++-
src/plugins/coreplugin/id.h | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/plugins/coreplugin/id.cpp b/src/plugins/coreplugin/id.cpp
index 28d60377ee7..7c72042df74 100644
--- a/src/plugins/coreplugin/id.cpp
+++ b/src/plugins/coreplugin/id.cpp
@@ -129,7 +129,12 @@ QByteArray Id::name() const
QString Id::toString() const
{
- return QString::fromUtf8(stringFromId[m_id]);
+ return QString::fromUtf8(stringFromId.at(m_id));
+}
+
+bool Id::operator==(const char *name) const
+{
+ return strcmp(stringFromId.at(m_id).constData(), name) == 0;
}
// For debugging purposes
diff --git a/src/plugins/coreplugin/id.h b/src/plugins/coreplugin/id.h
index 6fee7e85983..51e889c092c 100644
--- a/src/plugins/coreplugin/id.h
+++ b/src/plugins/coreplugin/id.h
@@ -50,6 +50,7 @@ public:
QString toString() const;
bool isValid() const { return m_id; }
bool operator==(Id id) const { return m_id == id.m_id; }
+ bool operator==(const char *name) const;
bool operator!=(Id id) const { return m_id != id.m_id; }
bool operator<(Id id) const { return m_id < id.m_id; }
bool operator>(Id id) const { return m_id > id.m_id; }
--
GitLab