QmlDesigner: Use QmlDesigner_HighlightColor consistently

This fixes a couple of issue in the .css and we
always use the same highlight color (QmlDesigner_HighlightColor).

Change-Id: I6522eabc00c30399b2c3b2689256b970ec558719
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

share/qtcreator/qmldesigner/statesEditorQmlSources/StatesDelegate.qml

@@ -101,9 +101,6 @@ Rectangle {
                 statesEditorModel.renameState(internalNodeId, text)
         }
 
-        // as we change the background we need to change the text
-        // color to see some text
-        textColor: creatorTheme.PanelTextColorLight
     }
 
     Item {

share/qtcreator/qmldesigner/statesEditorQmlSources/StatesList.qml

@@ -147,7 +147,7 @@ FocusScope {
                 height: delegateHeight
                 isBaseState: 0 == internalNodeId
                 isCurrentState: root.currentStateInternalId == internalNodeId
-                baseColor: isCurrentState ? Qt.darker(highlightColor, 1.2) : background.color
+                baseColor: isCurrentState ? creatorTheme.QmlDesigner_HighlightColor : background.color
                 delegateStateName: stateName
                 delegateStateImageSource: stateImageSource
                 delegateStateImageSize: stateImageSize

src/plugins/qmldesigner/components/resources/stylesheet.css

@@ -59,19 +59,13 @@ QLineEdit#itemLibrarySearchInput
  QTreeView {
     color: creatorTheme.PanelTextColorLight;
     selection-color: creatorTheme.PanelTextColorLight;
- }
-
- QTreeView::item:selected {
-     color: creatorTheme.PanelTextColorLight;
+    selection-background-color: creatorTheme.QmlDesigner_HighlightColor;
  }
 
  QListView {
-    color:creatorTheme.PanelTextColorLight;
+    color: creatorTheme.PanelTextColorLight;
     selection-color: creatorTheme.PanelTextColorLight;
- }
-
- QListView::item:selected {
-     color: creatorTheme.PanelTextColorLight;
+    selection-background-color: creatorTheme.QmlDesigner_HighlightColor;
  }
 
   QComboBox QAbstractItemView {

src/plugins/qmldesigner/components/stateseditor/stateseditorwidget.cpp

@@ -96,7 +96,6 @@ StatesEditorWidget::StatesEditorWidget(StatesEditorView *statesEditorView, State
     setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
 
     rootContext()->setContextProperty(QStringLiteral("statesEditorModel"), statesEditorModel);
-    rootContext()->setContextProperty(QStringLiteral("highlightColor"), Utils::StyleHelper::notTooBrightHighlightColor());
 
     rootContext()->setContextProperty(QLatin1String("canAddNewStates"), true);
 

src/plugins/qmldesigner/qmldesignerextension/connectioneditor/stylesheet.css

@@ -8,6 +8,9 @@ QFrame
 
 QTableView {
     color: creatorTheme.PanelTextColorLight;
+    selection-color: creatorTheme.PanelTextColorLight;
+    selection-background-color: creatorTheme.QmlDesigner_HighlightColor;
+
 }
 
 QTableView::item
@@ -24,12 +27,9 @@ QTableView::item:focus
 
 QTableView::item:selected
 {
-    background-color:  qlineargradient(x1: 0, y1: -0.4, x2: 0, y2: 0.6,stop: 0  palette(midlight), stop: 1 palette(highlight));
-
     border: none
 }
 
-
 QHeaderView::section {
     background-color: #494949;
     padding: 4px;