Commit 91a9a241 authored by Daniel Teske's avatar Daniel Teske
Browse files

OutputPane: Flash the output button instead of switching to edit mode

That is if the current mode has no OutputPanePlaceHolder, then we don't
switch modes, but flash the button. Also if the button is not visible,
we make it visible. The button doesn't autohide though.

Task-number: QTCREATORBUG-7272
Change-Id: I5ceacd2a17d1ece744f28952819c34bfcfdd5e7b
Reviewed-by: default avatarOswald Buddenhagen <>
Reviewed-by: default avatarTobias Hunger <>
Reviewed-by: default avatarEike Ziller <>
parent 80502c61
......@@ -465,10 +465,14 @@ void OutputPaneManager::setBadgeNumber(int number)
void OutputPaneManager::showPage(bool focus, bool ensureSizeHint)
int idx = findIndexForPage(qobject_cast<IOutputPane*>(sender()));
showPage(idx, focus);
if (ensureSizeHint)
if (OutputPanePlaceHolder *ph = OutputPanePlaceHolder::getCurrent())
OutputPanePlaceHolder *ph = OutputPanePlaceHolder::getCurrent();
if (!ph)
showPage(idx, focus);
if (ensureSizeHint && ph)
void OutputPaneManager::showPage(int idx, bool focus)
......@@ -705,6 +709,7 @@ void OutputPaneToggleButton::checkStateSet()
void OutputPaneToggleButton::flash(int count)
//Start flashing if button is not checked
if (!isChecked()) {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment