From 934bccbc7e4f0f977f036c5fda9cd44b257cadaa Mon Sep 17 00:00:00 2001
From: Friedemann Kleint <Friedemann.Kleint@digia.com>
Date: Fri, 8 Mar 2013 09:58:01 +0100
Subject: [PATCH] Fix Krazy-warnings in CppTools.
- values or keys iteration
- non-const ref iterator
Change-Id: I6bb58793b3155243e0fbfaf33ee43ce60edea8d1
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
---
src/plugins/cpptools/cpphighlightingsupportinternal.cpp | 2 +-
src/plugins/cpptools/cppmodelmanager.cpp | 4 ++--
src/plugins/cpptools/cpptoolsplugin.cpp | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/plugins/cpptools/cpphighlightingsupportinternal.cpp b/src/plugins/cpptools/cpphighlightingsupportinternal.cpp
index e20c0a9a2f1..28e22d27875 100644
--- a/src/plugins/cpptools/cpphighlightingsupportinternal.cpp
+++ b/src/plugins/cpptools/cpphighlightingsupportinternal.cpp
@@ -65,7 +65,7 @@ QFuture<CppHighlightingSupport::Use> CppHighlightingSupportInternal::highlightin
}
//Get macro uses
- foreach (Document::MacroUse macro, doc->macroUses()) {
+ foreach (const Document::MacroUse ¯o, doc->macroUses()) {
const QString name = QString::fromUtf8(macro.macro().name());
//Filter out QtKeywords
diff --git a/src/plugins/cpptools/cppmodelmanager.cpp b/src/plugins/cpptools/cppmodelmanager.cpp
index 6a06671d00f..9f661b6c91d 100644
--- a/src/plugins/cpptools/cppmodelmanager.cpp
+++ b/src/plugins/cpptools/cppmodelmanager.cpp
@@ -813,7 +813,7 @@ void CppModelManager::dumpModelManagerConfiguration()
{
// Tons of debug output...
qDebug()<<"========= CppModelManager::dumpModelManagerConfiguration ======";
- foreach (const ProjectInfo &pinfo, m_projects.values()) {
+ foreach (const ProjectInfo &pinfo, m_projects) {
qDebug()<<" for project:"<< pinfo.project().data()->document()->fileName();
foreach (const ProjectPart::Ptr &part, pinfo.projectParts()) {
qDebug() << "=== part ===";
@@ -958,7 +958,7 @@ void CppModelManager::updateProjectInfo(const ProjectInfo &pinfo)
m_srcToProjectPart.clear();
- foreach (const ProjectInfo &projectInfo, m_projects.values()) {
+ foreach (const ProjectInfo &projectInfo, m_projects) {
foreach (const ProjectPart::Ptr &projectPart, projectInfo.projectParts()) {
foreach (const QString &sourceFile, projectPart->sourceFiles)
m_srcToProjectPart[sourceFile].append(projectPart);
diff --git a/src/plugins/cpptools/cpptoolsplugin.cpp b/src/plugins/cpptools/cpptoolsplugin.cpp
index 002b12120f2..deef0985e0d 100644
--- a/src/plugins/cpptools/cpptoolsplugin.cpp
+++ b/src/plugins/cpptools/cpptoolsplugin.cpp
@@ -329,7 +329,7 @@ QString correspondingHeaderOrSource(const QString &fileName, bool *wasHeader)
foreach (const QString &candidateFileName, candidateFileNames) {
const QStringList projectFiles = findFilesInProject(candidateFileName, project);
// Find the file having the most common path with fileName
- foreach (const QString projectFile, projectFiles) {
+ foreach (const QString &projectFile, projectFiles) {
int value = commonStringLength(fileName, projectFile);
if (value > compareValue) {
compareValue = value;
--
GitLab