QmlPuppet: Pass const strings by reference

Change-Id: I6bf60d6484f13817dcbe36a4bfc099f3edf7559c Reviewed-by: Marco Bubke <marco.bubke@digia.com>

QmlPuppet: Pass const strings by reference
Change-Id: I6bf60d6484f13817dcbe36a4bfc099f3edf7559c Reviewed-by: Marco Bubke <marco.bubke@digia.com>
93c94d65 · Orgad Shaneh · Orgad Shaneh · 27cbc89c · 93c94d65 · 93c94d65
Commit 93c94d65 authored May 19, 2014 by Orgad Shaneh Committed by Orgad Shaneh May 21, 2014
6 changed files
--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp
@@ -235,7 +235,7 @@ void Qt5InformationNodeInstanceServer::createScene(const CreateSceneCommand &com

 }

-void Qt5InformationNodeInstanceServer::sendChildrenChangedCommand(const QList<ServerNodeInstance> childList)
+void Qt5InformationNodeInstanceServer::sendChildrenChangedCommand(const QList<ServerNodeInstance> &childList)
 {
    QSet<ServerNodeInstance> parentSet;
    QList<ServerNodeInstance> noParentList;

--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.h
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.h
@@ -50,7 +50,7 @@ public:

 protected:
    void collectItemChangesAndSendChangeCommands() Q_DECL_OVERRIDE;
-    void sendChildrenChangedCommand(const QList<ServerNodeInstance> childList);
+    void sendChildrenChangedCommand(const QList<ServerNodeInstance> &childList);
    void sendTokenBack();
    bool isDirtyRecursiveForNonInstanceItems(QQuickItem *item) const;
    bool isDirtyRecursiveForParentInstances(QQuickItem *item) const;

--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.cpp
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.cpp
@@ -307,7 +307,7 @@ void QmlDesigner::Qt5TestNodeInstanceServer::collectItemChangesAndSendChangeComm
    }
 }

-void Qt5TestNodeInstanceServer::sendChildrenChangedCommand(const QList<ServerNodeInstance> childList)
+void Qt5TestNodeInstanceServer::sendChildrenChangedCommand(const QList<ServerNodeInstance> &childList)
 {
    QSet<ServerNodeInstance> parentSet;
    QList<ServerNodeInstance> noParentList;

--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.h
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5testnodeinstanceserver.h
@@ -61,7 +61,7 @@ public:

 protected:
    void collectItemChangesAndSendChangeCommands() Q_DECL_OVERRIDE;
-    void sendChildrenChangedCommand(const QList<ServerNodeInstance> childList);
+    void sendChildrenChangedCommand(const QList<ServerNodeInstance> &childList);
    bool isDirtyRecursiveForNonInstanceItems(QQuickItem *item) const;
 };


--- a/share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/qt4informationnodeinstanceserver.cpp
+++ b/share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/qt4informationnodeinstanceserver.cpp
@@ -234,7 +234,7 @@ void Qt4InformationNodeInstanceServer::createScene(const CreateSceneCommand &com

 }

-void Qt4InformationNodeInstanceServer::sendChildrenChangedCommand(const QList<ServerNodeInstance> childList)
+void Qt4InformationNodeInstanceServer::sendChildrenChangedCommand(const QList<ServerNodeInstance> &childList)
 {
    QSet<ServerNodeInstance> parentSet;
    QList<ServerNodeInstance> noParentList;

--- a/share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/qt4informationnodeinstanceserver.h
+++ b/share/qtcreator/qml/qmlpuppet/qmlpuppet/instances/qt4informationnodeinstanceserver.h
@@ -50,7 +50,7 @@ public:

 protected:
    void collectItemChangesAndSendChangeCommands();
-    void sendChildrenChangedCommand(const QList<ServerNodeInstance> childList);
+    void sendChildrenChangedCommand(const QList<ServerNodeInstance> &childList);
    void sendTokenBack();

 private: