From 9689582ee6702d3eb21a910234b96d3bf936c660 Mon Sep 17 00:00:00 2001
From: dt <qtc-committer@nokia.com>
Date: Mon, 20 Apr 2009 16:29:46 +0200
Subject: [PATCH] Refacotring: Move BuildConfiguration into internal namespace.

It should not be used outside of the ProjectExplorer and is likewise not
exported.
---
 src/plugins/projectexplorer/buildconfiguration.cpp |  2 +-
 src/plugins/projectexplorer/buildconfiguration.h   |  4 ++--
 src/plugins/projectexplorer/buildstep.cpp          |  5 ++---
 src/plugins/projectexplorer/buildstep.h            | 10 ++++++----
 src/plugins/projectexplorer/project.cpp            |  1 +
 src/plugins/projectexplorer/project.h              |  4 ++--
 6 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp
index 6196e988e3..06364fb054 100644
--- a/src/plugins/projectexplorer/buildconfiguration.cpp
+++ b/src/plugins/projectexplorer/buildconfiguration.cpp
@@ -29,7 +29,7 @@
 
 #include "buildconfiguration.h"
 
-using namespace ProjectExplorer;
+using namespace ProjectExplorer::Internal;
 
 BuildConfiguration::BuildConfiguration(const QString &name)
     : m_name(name)
diff --git a/src/plugins/projectexplorer/buildconfiguration.h b/src/plugins/projectexplorer/buildconfiguration.h
index c061b33808..dbb200896e 100644
--- a/src/plugins/projectexplorer/buildconfiguration.h
+++ b/src/plugins/projectexplorer/buildconfiguration.h
@@ -35,7 +35,7 @@
 #include <QtCore/QHash>
 
 namespace ProjectExplorer {
-
+namespace Internal {
 class BuildConfiguration
 {
 public:
@@ -55,7 +55,7 @@ private:
     QHash<QString, QVariant> m_values;
     QString m_name;
 };
-
+}
 } // namespace ProjectExplorer
 
 #endif // BUILDCONFIGURATION_H
diff --git a/src/plugins/projectexplorer/buildstep.cpp b/src/plugins/projectexplorer/buildstep.cpp
index 8141861b70..3199cc3e48 100644
--- a/src/plugins/projectexplorer/buildstep.cpp
+++ b/src/plugins/projectexplorer/buildstep.cpp
@@ -32,7 +32,8 @@
 
 #include <utils/qtcassert.h>
 
-namespace ProjectExplorer {
+using namespace ProjectExplorer;
+using namespace ProjectExplorer::Internal;
 
 BuildStep::BuildStep(Project * pro)
     : m_project(pro)
@@ -141,5 +142,3 @@ IBuildStepFactory::~IBuildStepFactory()
 {
 
 }
-
-} // namespace ProjectExplorer
diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h
index e9b4267d83..9fb5a3cdc8 100644
--- a/src/plugins/projectexplorer/buildstep.h
+++ b/src/plugins/projectexplorer/buildstep.h
@@ -39,7 +39,9 @@
 
 namespace ProjectExplorer {
 
+namespace Internal {
 class BuildConfiguration;
+}
 
 /*
 // BuildSteps are the primary way plugin developers can customize
@@ -132,14 +134,14 @@ Q_SIGNALS:
     void displayNameChanged(BuildStep *, const QString &displayName);
 
 private:
-    QList<BuildConfiguration *> buildConfigurations();
+    QList<Internal::BuildConfiguration *> buildConfigurations();
     void addBuildConfiguration(const QString & name);
     void removeBuildConfiguration(const QString & name);
-    BuildConfiguration *getBuildConfiguration(const QString & name) const;
+    Internal::BuildConfiguration *getBuildConfiguration(const QString & name) const;
     void copyBuildConfiguration(const QString &source, const QString &dest);
 
-    QList<BuildConfiguration *> m_buildConfigurations;
-    BuildConfiguration *m_configuration;
+    QList<Internal::BuildConfiguration *> m_buildConfigurations;
+    Internal::BuildConfiguration *m_configuration;
     Project *m_project;
 };
 
diff --git a/src/plugins/projectexplorer/project.cpp b/src/plugins/projectexplorer/project.cpp
index 3f83f4763e..a36c01235e 100644
--- a/src/plugins/projectexplorer/project.cpp
+++ b/src/plugins/projectexplorer/project.cpp
@@ -42,6 +42,7 @@
 #include <QtCore/QTextCodec>
 
 using namespace ProjectExplorer;
+using namespace ProjectExplorer::Internal;
 
 Project::Project()
     : m_activeRunConfiguration(0),
diff --git a/src/plugins/projectexplorer/project.h b/src/plugins/projectexplorer/project.h
index bfe5872e78..b4be7fa0c1 100644
--- a/src/plugins/projectexplorer/project.h
+++ b/src/plugins/projectexplorer/project.h
@@ -165,13 +165,13 @@ protected:
     virtual void restoreSettingsImpl(PersistentSettingsReader &reader);
 
 private:
-    BuildConfiguration *getBuildConfiguration(const QString & name) const;
+    Internal::BuildConfiguration *getBuildConfiguration(const QString & name) const;
 
     QList<BuildStep *> m_buildSteps;
     QList<BuildStep *> m_cleanSteps;
     QStringList m_buildConfigurations;
     QMap<QString, QVariant> m_values;
-    QList<BuildConfiguration *> m_buildConfigurationValues;
+    QList<Internal::BuildConfiguration *> m_buildConfigurationValues;
     QString m_activeBuildConfiguration;
     QList<QSharedPointer<RunConfiguration> > m_runConfigurations;
     QSharedPointer<RunConfiguration> m_activeRunConfiguration;
-- 
GitLab