From 9a40d3c4772ca63e52cc4bca5dd85f1eba1c85e2 Mon Sep 17 00:00:00 2001
From: Nikita Baryshnikov <nib952051@gmail.com>
Date: Wed, 27 May 2015 00:15:55 +0300
Subject: [PATCH] Coding style: mention inlined virtual dtors
in exported classes
Change-Id: I9ff274f05e26baa9d4377f69b0ba441606893357
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
---
doc/api/coding-style.qdoc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/api/coding-style.qdoc b/doc/api/coding-style.qdoc
index 8b26dcabc95..8193941fa46 100644
--- a/doc/api/coding-style.qdoc
+++ b/doc/api/coding-style.qdoc
@@ -1093,6 +1093,10 @@
for (Container::const_iterator it = c.begin(); it != c.end(); ++it)
\endcode
+
+ \li Do not inline virtual destructors in exported classes. This leads to duplicated vtables
+ in dependent plugins and this can also break RTTI. See
+ \l {https://bugreports.qt.io/browse/QTBUG-45582}{QTBUG-45582}.
\endlist
\section2 Esthetics
--
GitLab