Fixes: - Warning about wrong connect

Details: - Bookmarks plugin accidentally thought all editors are text editors.

Fixes: - Warning about wrong connect
Details: - Bookmarks plugin accidentally thought all editors are text editors.
9c244bcb · con · 65f07aa2 · 9c244bcb
Commit 9c244bcb authored Dec 10, 2008 by con
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 4 deletions

src/plugins/bookmarks/bookmarksplugin.cpp src/plugins/bookmarks/bookmarksplugin.cpp +8 -4

No files found.
--- a/src/plugins/bookmarks/bookmarksplugin.cpp
+++ b/src/plugins/bookmarks/bookmarksplugin.cpp
@@ -201,14 +201,18 @@ void BookmarksPlugin::updateActions(int state)

 void BookmarksPlugin::editorOpened(Core::IEditor *editor)
 {
-    connect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)),
-            this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*)));
+    if (qobject_cast<ITextEditor *>(editor)) {
+        connect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)),
+                this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*)));
+    }
 }

 void BookmarksPlugin::editorAboutToClose(Core::IEditor *editor)
 {
-    disconnect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)),
-            this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*)));
+    if (qobject_cast<ITextEditor *>(editor)) {
+        disconnect(editor, SIGNAL(markContextMenuRequested(TextEditor::ITextEditor*,int,QMenu*)),
+                this, SLOT(requestContextMenu(TextEditor::ITextEditor*,int,QMenu*)));
+    }
 }

 void BookmarksPlugin::requestContextMenu(TextEditor::ITextEditor *editor,