Commit ac7fe92e authored by Ulf Hermann's avatar Ulf Hermann Committed by Kai Koehne

Remove disconnectClientSignals() from ~QmlProfilerClientManager()

disconnectClientSignals only disconnects signals of objects that are
deleted directly afterwards. As deleting a QObject automatically
disconnects its signals it's unnecessary to explicitly do that before.

However, if QmlProfilerClientManager is deleted from the destructor of
QmlProfilerTool, receivers of those signals may have already been
deleted. This can lead to crashes.

Task-number: QTCREATORBUG-10634
Change-Id: I1e5ce7a6ac4b331fa423987e3a8faa3584b991d2
Reviewed-by: default avatarKai Koehne <kai.koehne@digia.com>
parent 6bdb402f
......@@ -95,7 +95,6 @@ QmlProfilerClientManager::QmlProfilerClientManager(QObject *parent) :
QmlProfilerClientManager::~QmlProfilerClientManager()
{
disconnectClientSignals();
delete d->connection;
delete d->qmlclientplugin.data();
delete d->v8clientplugin.data();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment