Commit b2461087 authored by Tobias Hunger's avatar Tobias Hunger

Qbs: Remove activeTargetChanged slot

Changing the build configuration triggers a reparsing of Qbs nowadays,
so that is update is already covered.

Change-Id: I8415fe8e1da71e2c7b044cbf7623362b6cdf4ed3
Reviewed-by: default avatarDaniel Teske <daniel.teske@digia.com>
parent 279756d0
......@@ -80,7 +80,6 @@ QbsProjectManagerPlugin::QbsProjectManagerPlugin() :
m_manager(0),
m_projectExplorer(0),
m_selectedProject(0),
m_selectedTarget(0),
m_selectedNode(0)
{ }
......@@ -219,19 +218,8 @@ void QbsProjectManagerPlugin::projectWasAdded(Project *project)
void QbsProjectManagerPlugin::updateContextActions(ProjectExplorer::Node *node, ProjectExplorer::Project *project)
{
if (m_selectedProject) {
disconnect(m_selectedProject, SIGNAL(activeTargetChanged(ProjectExplorer::Target*)),
this, SLOT(activeTargetChanged()));
}
m_selectedNode = node;
m_selectedProject = qobject_cast<Internal::QbsProject *>(project);
if (m_selectedProject) {
connect(m_selectedProject, SIGNAL(activeTargetChanged(ProjectExplorer::Target*)),
this, SLOT(activeTargetChanged()));
}
activeTargetChanged();
bool isBuilding = BuildManager::isBuilding(project);
bool isFile = m_selectedProject && node && (node->nodeType() == ProjectExplorer::FileNodeType);
......@@ -296,21 +284,6 @@ void QbsProjectManagerPlugin::updateBuildActions()
m_buildSubproject->setVisible(subprojectVisible);
}
void QbsProjectManagerPlugin::activeTargetChanged()
{
if (m_selectedTarget)
disconnect(m_selectedTarget, SIGNAL(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*)),
this, SLOT(updateReparseQbsAction()));
m_selectedTarget = m_selectedProject ? m_selectedProject->activeTarget() : 0;
if (m_selectedTarget)
connect(m_selectedTarget, SIGNAL(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*)),
this, SLOT(updateReparseQbsAction()));
updateReparseQbsAction();
}
void QbsProjectManagerPlugin::buildStateChanged(ProjectExplorer::Project *project)
{
if (project == m_selectedProject) {
......
......@@ -70,7 +70,6 @@ private slots:
void updateContextActions(ProjectExplorer::Node *node, ProjectExplorer::Project *project);
void updateReparseQbsAction();
void updateBuildActions();
void activeTargetChanged();
void buildStateChanged(ProjectExplorer::Project *project);
void parsingStateChanged();
......@@ -102,7 +101,6 @@ private:
Utils::ParameterAction *m_buildSubproject;
Internal::QbsProject *m_selectedProject;
ProjectExplorer::Target *m_selectedTarget;
ProjectExplorer::Node *m_selectedNode;
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment