Commit b39de891 authored by Friedemann Kleint's avatar Friedemann Kleint Committed by hjk
Browse files

Check if debuggers read from settings files are executable.



Change-Id: I412d3fdf228bcf8948d8247363bf3b034cbb788c
Reviewed-by: default avatarMehdi Fekari <mfekari@blackberry.com>
Reviewed-by: default avatarhjk <hjk121@nokiamail.com>
parent ba93c22d
......@@ -92,11 +92,19 @@ static void readDebuggers(const FileName &fileName, bool isSystem)
// SDK debuggers are always considered to be up-to-date, so no need to recheck them.
} else {
// User settings.
if (item.isAutoDetected() && (!item.isValid() || item.engineType() == NoEngineType)) {
qWarning() << QString::fromLatin1("DebuggerItem \"%1\" (%2) dropped since it is not valid")
.arg(item.command().toString()).arg(item.id().toString());
if (item.isAutoDetected()) {
if (!item.isValid() || item.engineType() == NoEngineType) {
qWarning() << QString::fromLatin1("DebuggerItem \"%1\" (%2) read from \"%3\" dropped since it is not valid.")
.arg(item.command().toUserOutput(), item.id().toString(), fileName.toUserOutput());
continue;
}
if (!item.command().toFileInfo().isExecutable()) {
qWarning() << QString::fromLatin1("DebuggerItem \"%1\" (%2) read from \"%3\" dropped since the command is not executable.")
.arg(item.command().toUserOutput(), item.id().toString(), fileName.toUserOutput());
continue;
}
}
}
DebuggerItemManager::registerDebugger(item);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment