Redesign the New Projects/Files dialog

- allow for more verbose description
- allow to fit all catagories and subcategories in
- bring more clear separation between projects and files
- expense: one more click

Reviewed-by: jbache

src/plugins/coreplugin/coreconstants.h

@@ -224,7 +224,7 @@ const char * const ICON_MAGNIFIER        = ":/core/images/magnifier.png";
 const char * const ICON_TOGGLE_SIDEBAR   = ":/core/images/sidebaricon.png";
 
 const char * const WIZARD_CATEGORY_QT = "R.Qt";
-const char * const WIZARD_TR_CATEGORY_QT = QT_TRANSLATE_NOOP("Core", "Qt Files and Classes");
+const char * const WIZARD_TR_CATEGORY_QT = QT_TRANSLATE_NOOP("Core", "Qt");
 
 const char * const SETTINGS_CATEGORY_CORE = "A.Core";
 const char * const SETTINGS_CATEGORY_CORE_ICON = ":/core/images/category_core.png";

src/plugins/coreplugin/dialogs/newdialog.cpp

@@ -31,23 +31,130 @@
 #include "ui_newdialog.h"
 #include "basefilewizard.h"
 
+#include <utils/stylehelper.h>
+
 #include <coreplugin/coreconstants.h>
 #include <coreplugin/dialogs/iwizard.h>
 
+#include <QtGui/QAbstractProxyModel>
 #include <QtGui/QHeaderView>
 #include <QtGui/QPushButton>
 #include <QtGui/QStandardItem>
+#include <QtGui/QItemDelegate>
+#include <QtGui/QPainter>
 #include <QtCore/QDebug>
 
 Q_DECLARE_METATYPE(Core::IWizard*)
 
-static inline Core::IWizard *wizardOfItem(const QStandardItem *item = 0)
+
+namespace {
+
+class TwoLevelProxyModel : public QAbstractProxyModel
+{
+//    Q_OBJECT
+public:
+    TwoLevelProxyModel(QObject *parent = 0): QAbstractProxyModel(parent) {}
+
+    QModelIndex index(int row, int column, const QModelIndex &parent) const
+    {
+        QModelIndex ourModelIndex = sourceModel()->index(row, column, mapToSource(parent));
+        return createIndex(row, column, ourModelIndex.internalPointer());
+    }
+
+    QModelIndex parent(const QModelIndex &index) const
+    {
+        return mapFromSource(mapToSource(index).parent());
+    }
+
+    int rowCount(const QModelIndex &index) const
+    {
+        if (index.isValid() && index.parent().isValid() && !index.parent().parent().isValid())
+            return 0;
+        else
+            return sourceModel()->rowCount(mapToSource(index));
+    }
+
+    int columnCount(const QModelIndex &index) const
+    {
+        return sourceModel()->columnCount(mapToSource(index));
+    }
+
+    QModelIndex	mapFromSource (const QModelIndex &index) const
+    {
+        if (!index.isValid())
+            return QModelIndex();
+        return createIndex(index.row(), index.column(), index.internalPointer());
+    }
+
+    QModelIndex	mapToSource (const QModelIndex &index) const
+    {
+        if (!index.isValid())
+            return QModelIndex();
+        return static_cast<TwoLevelProxyModel*>(sourceModel())->createIndex(index.row(), index.column(), index.internalPointer());
+    }
+
+    Qt::ItemFlags flags(const QModelIndex &index) const
+    {
+        Qt::ItemFlags f = sourceModel()->flags(index);
+        if (!index.parent().isValid())
+            return f ^ Qt::ItemIsSelectable;
+        else
+            return f;
+    }
+};
+
+#define CATEGORY_ROW_HEIGHT 18
+
+class FancyTopLevelDelegate : public QItemDelegate
+{
+public:
+    FancyTopLevelDelegate(QObject *parent = 0)
+        : QItemDelegate(parent) {}
+
+
+    void drawDisplay(QPainter *painter, const QStyleOptionViewItem &option, const QRect &rect, const QString &text) const
+    {
+        if (rect.height() == CATEGORY_ROW_HEIGHT) {
+            QLinearGradient gradient(rect.topLeft(), rect.bottomLeft());
+            gradient.setColorAt(0, option.palette.window().color().lighter(106));
+            gradient.setColorAt(1, option.palette.window().color().darker(106));
+            painter->fillRect(rect, gradient);
+            painter->setPen(option.palette.window().color().darker(130));
+            if (rect.top())
+                painter->drawLine(rect.topRight(), rect.topLeft());
+            painter->drawLine(rect.bottomRight(), rect.bottomLeft());
+        }
+
+        QItemDelegate::drawDisplay(painter, option, rect, text);
+    }
+
+    void drawFocus(QPainter *painter, const QStyleOptionViewItem &option, const QRect &rect) const
+    {
+        if (rect.height() != CATEGORY_ROW_HEIGHT)
+            QItemDelegate::drawFocus(painter, option, rect);
+    }
+
+    QSize sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const
+    {
+        QSize size = QItemDelegate::sizeHint(option, index);
+
+        if (!index.parent().isValid())
+            size = size.expandedTo(QSize(0, CATEGORY_ROW_HEIGHT));
+
+        return size;
+    }
+};
+
+
+inline Core::IWizard *wizardOfItem(const QStandardItem *item = 0)
 {
     if (!item)
         return 0;
     return item->data(Qt::UserRole).value<Core::IWizard*>();
 }
 
+}
+
 using namespace Core;
 using namespace Core::Internal;
 
@@ -61,16 +168,23 @@ NewDialog::NewDialog(QWidget *parent) :
     m_ui->setupUi(this);
     m_okButton = m_ui->buttonBox->button(QDialogButtonBox::Ok);
     m_okButton->setDefault(true);
-    m_okButton->setText(tr("&Create"));
+    m_okButton->setText(tr("&Choose..."));
 
-    m_ui->templatesTree->header()->hide();
     m_model = new QStandardItemModel(this);
-    m_ui->templatesTree->setModel(m_model);
+    m_proxyModel = new TwoLevelProxyModel(this);
+    m_proxyModel->setSourceModel(m_model);
+    m_ui->templateCategoryView->setModel(m_proxyModel);
+    m_ui->templateCategoryView->setEditTriggers(QAbstractItemView::NoEditTriggers);
+    m_ui->templateCategoryView->setItemDelegate(new FancyTopLevelDelegate);
+
+    m_ui->templatesView->setIconSize(QSize(22, 22));
 
-    connect(m_ui->templatesTree, SIGNAL(clicked(const QModelIndex&)),
+    connect(m_ui->templateCategoryView, SIGNAL(clicked(const QModelIndex&)),
+        this, SLOT(currentCategoryChanged(const QModelIndex&)));
+    connect(m_ui->templatesView, SIGNAL(clicked(const QModelIndex&)),
         this, SLOT(currentItemChanged(const QModelIndex&)));
-    connect(m_ui->templatesTree, SIGNAL(activated(const QModelIndex&)),
-            m_okButton, SLOT(animateClick()));
+//    connect(m_ui->templatesView, SIGNAL(activated(const QModelIndex&)),
+//            m_okButton, SLOT(animateClick()));
 
     connect(m_okButton, SIGNAL(clicked()), this, SLOT(okButtonClicked()));
     connect(m_ui->buttonBox, SIGNAL(rejected()), this, SLOT(reject()));
@@ -95,17 +209,41 @@ void NewDialog::setWizards(QList<IWizard*> wizards)
 
     qStableSort(wizards.begin(), wizards.end(), wizardLessThan);
 
+
     CategoryItemMap categories;
 
     m_model->clear();
+    QStandardItem *projectKindItem = new QStandardItem(tr("Projects"));
+    projectKindItem->setData(IWizard::ProjectWizard, Qt::UserRole);
+    QStandardItem *filesClassesKindItem = new QStandardItem(tr("Files & Classes"));
+    filesClassesKindItem->setData(IWizard::FileWizard, Qt::UserRole);
+
+    QStandardItem *parentItem = m_model->invisibleRootItem();
+    parentItem->appendRow(projectKindItem);
+    parentItem->appendRow(filesClassesKindItem);
+
+    static QPixmap dummyIcon(22, 22);
+    dummyIcon.fill(Qt::transparent);
+
     foreach (IWizard *wizard, wizards) {
         // ensure category root
         const QString categoryName = wizard->category();
+
         CategoryItemMap::iterator cit = categories.find(categoryName);
         if (cit == categories.end()) {
-            QStandardItem *parentItem = m_model->invisibleRootItem();
             QStandardItem *categoryItem = new QStandardItem();
-            parentItem->appendRow(categoryItem);
+            QStandardItem *kindItem;
+            switch (wizard->kind()) {
+            case IWizard::ProjectWizard:
+                kindItem = projectKindItem;
+                break;
+            case IWizard::ClassWizard:
+            case IWizard::FileWizard:
+            default:
+                kindItem = filesClassesKindItem;
+                break;
+            }
+            kindItem->appendRow(categoryItem);
             categoryItem->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable);
             categoryItem->setText(wizard->displayCategory());
             categoryItem->setData(QVariant::fromValue(0), Qt::UserRole);
@@ -113,44 +251,66 @@ void NewDialog::setWizards(QList<IWizard*> wizards)
         }
         // add item
         QStandardItem *wizardItem = new QStandardItem(wizard->displayName());
-        wizardItem->setIcon(wizard->icon());
+        QIcon wizardIcon;
+
+        // spacing hack. Add proper icons instead
+        if (wizard->icon().isNull())
+            wizardIcon = dummyIcon;
+        else
+            wizardIcon = wizard->icon();
+        wizardItem->setIcon(wizardIcon);
         wizardItem->setData(QVariant::fromValue(wizard), Qt::UserRole);
         wizardItem->setFlags(Qt::ItemIsEnabled|Qt::ItemIsSelectable);
         cit.value()->appendRow(wizardItem);
     }
+
+
+    if (!projectKindItem->hasChildren()) {
+        QModelIndex idx = projectKindItem->index();
+        m_model->removeRow(idx.row());
+    }
+    if (!filesClassesKindItem->hasChildren()) {
+        QModelIndex idx = filesClassesKindItem->index();
+        m_model->removeRow(idx.row());
+    }
+
 }
 
 Core::IWizard *NewDialog::showDialog()
 {
-    QStandardItem *itemToSelect = 0;
-    if (m_preferredWizardKinds == 0) {
-        m_ui->templatesTree->expandAll();
-        if (QStandardItem *rootItem = m_model->invisibleRootItem()->child(0)) {
-            if (rootItem->rowCount())
-                itemToSelect = rootItem->child(0);
-        }
-    } else {
-        for (int i = 0; i < m_model->invisibleRootItem()->rowCount(); ++i) {
-            QStandardItem *category = m_model->invisibleRootItem()->child(i);
-            bool hasOnlyPreferred = true;
-            for (int j = 0; j < category->rowCount(); ++j) {
-                QStandardItem *item = category->child(j);
-                if (!(item->data(Qt::UserRole).value<IWizard*>()
-                        ->kind() & m_preferredWizardKinds)) {
-                    hasOnlyPreferred = false;
-                    break;
-                }
-            }
-            m_ui->templatesTree->setExpanded(category->index(), hasOnlyPreferred);
-            if (hasOnlyPreferred && itemToSelect == 0 && category->rowCount() > 0) {
-                itemToSelect = category->child(0);
-            }
-        }
-    }
-    if (itemToSelect) {
-        m_ui->templatesTree->scrollTo(itemToSelect->index());
-        m_ui->templatesTree->setCurrentIndex(itemToSelect->index());
-    }
+    for (int row = 0; row < m_proxyModel->rowCount(); ++row)
+        m_ui->templateCategoryView->setExpanded(m_proxyModel->index(row, 0), true);
+
+//    QStandardItem *itemToSelect = 0;
+//    if (m_preferredWizardKinds == 0) {
+//        if (QStandardItem *rootItem = m_model->invisibleRootItem()->child(0)) {
+//            if (rootItem->rowCount())
+//                itemToSelect = rootItem->child(0);
+//        }
+//    } else {
+//        for (int i = 0; i < m_model->invisibleRootItem()->rowCount(); ++i) {
+//            QStandardItem *type = m_model->invisibleRootItem()->child(i);
+//            bool hasOnlyPreferred = true;
+//            for (int j = 0; j < category->rowCount(); ++j) {
+//                QStandardItem *item = category->child(j);
+//                if (!(item->data(Qt::UserRole).value<IWizard*>()
+//                    ->kind() & m_preferredWizardKinds)) {
+//                    hasOnlyPreferred = false;
+//                    break;
+//                }
+//            }
+//            //m_ui->templatesTree->setExpanded(category->index(), hasOnlyPreferred);
+//            if (hasOnlyPreferred && itemToSelect == 0 && category->rowCount() > 0) {
+//                itemToSelect = category->child(0);
+//            }
+//        }
+//    }
+//    if (itemToSelect) {
+//        m_ui->templateCategoryView->scrollTo(itemToSelect->index());
+//        m_ui->templateCategoryView->setCurrentIndex(itemToSelect->index());
+//        m_ui->templatesView->scrollTo(itemToSelect->index());
+//        m_ui->templatesView->setCurrentIndex(itemToSelect->index());
+//    }
     updateOkButton();
     if (exec() != Accepted)
         return 0;
@@ -164,22 +324,33 @@ NewDialog::~NewDialog()
 
 IWizard *NewDialog::currentWizard() const
 {
-    return wizardOfItem(m_model->itemFromIndex(m_ui->templatesTree->currentIndex()));
+    return wizardOfItem(m_model->itemFromIndex(m_ui->templatesView->currentIndex()));
+}
+
+void NewDialog::currentCategoryChanged(const QModelIndex &index)
+{
+
+    if (index.parent() != m_model->invisibleRootItem()->index()) {
+        m_ui->templatesView->setModel(m_model);
+        m_ui->templatesView->setRootIndex(m_proxyModel->mapToSource(index));
+    } else  {
+        m_ui->templatesView->setModel(0);
+    }
 }
 
 void NewDialog::currentItemChanged(const QModelIndex &index)
 {
     QStandardItem* cat = m_model->itemFromIndex(index);
     if (const IWizard *wizard = wizardOfItem(cat))
-        m_ui->descLabel->setText(wizard->description());
+        m_ui->templateDescription->setText(wizard->description());
     else
-        m_ui->descLabel->setText(QString());
+        m_ui->templateDescription->setText(QString());
     updateOkButton();
 }
 
 void NewDialog::okButtonClicked()
 {
-    if (m_ui->templatesTree->currentIndex().isValid())
+    if (m_ui->templatesView->currentIndex().isValid())
         accept();
 }
 

src/plugins/coreplugin/dialogs/newdialog.h

@@ -36,6 +36,7 @@
 #include <QtCore/QList>
 
 QT_BEGIN_NAMESPACE
+class QAbstractProxyModel;
 class QPushButton;
 class QStandardItem;
 class QStandardItemModel;
@@ -65,6 +66,7 @@ public:
     Core::IWizard *showDialog();
 
 private slots:
+    void currentCategoryChanged(const QModelIndex &);
     void currentItemChanged(const QModelIndex &);
     void okButtonClicked();
     void updateOkButton();
@@ -74,8 +76,10 @@ private:
 
     Ui::NewDialog *m_ui;
     QStandardItemModel *m_model;
+    QAbstractProxyModel *m_proxyModel;
     QPushButton *m_okButton;
     IWizard::WizardKinds m_preferredWizardKinds;
+    QPixmap m_dummyIcon;
 };
 
 } // namespace Internal

src/plugins/coreplugin/dialogs/newdialog.ui

@@ -6,35 +6,51 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>490</width>
+    <width>513</width>
     <height>390</height>
    </rect>
   </property>
   <property name="windowTitle">
    <string>New Project</string>
   </property>
-  <layout class="QVBoxLayout" name="verticalLayout">
-   <item>
-    <widget class="QTreeView" name="templatesTree">
-     <property name="minimumSize">
+  <layout class="QGridLayout" name="gridLayout">
+   <item row="1" column="1">
+    <widget class="QListView" name="templatesView">
+     <property name="sizePolicy">
+      <sizepolicy hsizetype="MinimumExpanding" vsizetype="Expanding">
+       <horstretch>0</horstretch>
+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
+     <property name="uniformItemSizes">
+      <bool>false</bool>
+     </property>
+    </widget>
+   </item>
+   <item row="2" column="1">
+    <widget class="QTextBrowser" name="templateDescription">
+     <property name="sizePolicy">
+      <sizepolicy hsizetype="MinimumExpanding" vsizetype="Expanding">
+       <horstretch>0</horstretch>
+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
+     <property name="maximumSize">
       <size>
-       <width>400</width>
-       <height>301</height>
+       <width>16777215</width>
+       <height>100</height>
       </size>
      </property>
     </widget>
    </item>
-   <item>
-    <widget class="QLabel" name="descLabel"/>
-   </item>
-   <item>
+   <item row="3" column="0" colspan="2">
     <widget class="Line" name="line">
      <property name="orientation">
       <enum>Qt::Horizontal</enum>
      </property>
     </widget>
    </item>
-   <item>
+   <item row="4" column="0" colspan="2">
     <widget class="QDialogButtonBox" name="buttonBox">
      <property name="orientation">
       <enum>Qt::Horizontal</enum>
@@ -44,6 +60,38 @@
      </property>
     </widget>
    </item>
+   <item row="0" column="0">
+    <widget class="QLabel" name="label">
+     <property name="text">
+      <string>Choose a template:</string>
+     </property>
+    </widget>
+   </item>
+   <item row="1" column="0" rowspan="2">
+    <widget class="QTreeView" name="templateCategoryView">
+     <property name="maximumSize">
+      <size>
+       <width>200</width>
+       <height>16777215</height>
+      </size>
+     </property>
+     <property name="indentation">
+      <number>0</number>
+     </property>
+     <property name="rootIsDecorated">
+      <bool>false</bool>
+     </property>
+     <property name="itemsExpandable">
+      <bool>false</bool>
+     </property>
+     <property name="headerHidden">
+      <bool>true</bool>
+     </property>
+     <attribute name="headerVisible">
+      <bool>false</bool>
+     </attribute>
+    </widget>
+   </item>
   </layout>
  </widget>
  <resources/>

src/plugins/cppeditor/cppeditorconstants.h

@@ -60,7 +60,7 @@ const char * const CPP_SOURCE_MIMETYPE = "text/x-c++src";
 const char * const CPP_HEADER_MIMETYPE = "text/x-c++hdr";
 
 const char * const WIZARD_CATEGORY = "O.C++";
-const char * const WIZARD_TR_CATEGORY = QT_TRANSLATE_NOOP("CppEditor", "C++ Files and Classes");
+const char * const WIZARD_TR_CATEGORY = QT_TRANSLATE_NOOP("CppEditor", "C++");
 
 } // namespace Constants
 } // namespace CppEditor

src/plugins/vcsbase/vcsbaseconstants.h

@@ -40,7 +40,7 @@ const char * const VCS_SETTINGS_TR_CATEGORY = QT_TRANSLATE_NOOP("VCSBase", "Vers
 const char * const VCS_COMMON_SETTINGS_ID = "A.Common";
 const char * const VCS_COMMON_SETTINGS_NAME = QT_TRANSLATE_NOOP("VCSBase", "Common");
 
-const char * const VCS_WIZARD_TR_CATEGORY = QT_TRANSLATE_NOOP("VCSBase", "Version Control");
+const char * const VCS_WIZARD_TR_CATEGORY = QT_TRANSLATE_NOOP("VCSBase", "Project from Version Control");
 const char * const VCS_WIZARD_CATEGORY = "L.Version Control";
 
 // Ids for sort order (wizards and preferences)