Commit bf9777e7 authored by Thomas Hartmann's avatar Thomas Hartmann

Fix Clang warnings

Do not hide virtual done() slot with done() signal.

Change-Id: Ic09439fdac2727f316f4a0983ffbd290f8555292
Reviewed-by: default avatarTobias Hunger <tobias.hunger@theqtcompany.com>
parent d3c44bd3
...@@ -74,5 +74,5 @@ void AddSignalHandlerDialog::updateComboBox() ...@@ -74,5 +74,5 @@ void AddSignalHandlerDialog::updateComboBox()
void AddSignalHandlerDialog::handleAccepted() void AddSignalHandlerDialog::handleAccepted()
{ {
m_signal = m_ui->comboBox->currentText(); m_signal = m_ui->comboBox->currentText();
emit done(); emit signalSelected();
} }
...@@ -43,7 +43,7 @@ public: ...@@ -43,7 +43,7 @@ public:
QString signal() const; QString signal() const;
signals: signals:
void done(); void signalSelected();
private: private:
void updateComboBox(); void updateComboBox();
......
...@@ -695,7 +695,7 @@ void gotoImplementation(const SelectionContext &selectionState) ...@@ -695,7 +695,7 @@ void gotoImplementation(const SelectionContext &selectionState)
AddSignalHandlerDialog *dialog = new AddSignalHandlerDialog(Core::ICore::dialogParent()); AddSignalHandlerDialog *dialog = new AddSignalHandlerDialog(Core::ICore::dialogParent());
dialog->setSignals(signalNames); dialog->setSignals(signalNames);
AddSignalHandlerDialog::connect(dialog, &AddSignalHandlerDialog::done, [=] { AddSignalHandlerDialog::connect(dialog, &AddSignalHandlerDialog::signalSelected, [=] {
dialog->deleteLater(); dialog->deleteLater();
if (dialog->signal().isEmpty()) if (dialog->signal().isEmpty())
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment