Commit c1038856 authored by Daniel Teske's avatar Daniel Teske Committed by hjk

KitModel: Fix crash on removing kits introduced in 7fd21d22

Removing a kit removes the item from the TreeModel and puts it into
KitModel::m_toRemoveList. A later update to that kit would trigger
the lambda connected to the dirty signal, thus calling node->update(),
which eventually ends up calling node->parent()->m_children, and
node->parent() is a null pointer there.

Change-Id: I9006f1eea036ae99b48a47baa2bc2a33bdcb84b1
Reviewed-by: default avatarhjk <hjk@theqtcompany.com>
parent ef7f34de
......@@ -259,8 +259,10 @@ KitNode *KitModel::createNode(Kit *k)
{
KitNode *node = new KitNode(k);
m_parentLayout->addWidget(node->widget);
connect(node->widget, &KitManagerConfigWidget::dirty, [node] {
node->update();
connect(node->widget, &KitManagerConfigWidget::dirty, [this, node] {
if (m_autoRoot->children().contains(node)
|| m_manualRoot->children().contains(node))
node->update();
});
return node;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment