From c7761d8b2e55ce756f69cfed2bdd329d07636c34 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@digia.com>
Date: Fri, 18 Oct 2013 08:43:10 +0200
Subject: [PATCH] Help: Only open 'internal' documentation links in Qt Creator
Open external webpages in external browser.
Task-number: QTCREATORBUG-8433
Change-Id: I760f6c5705046a6f8b7ebec3cd7b32253738e0df
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
---
src/plugins/help/helpviewer.cpp | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/plugins/help/helpviewer.cpp b/src/plugins/help/helpviewer.cpp
index 825f7b141fd..b063faa5d6f 100644
--- a/src/plugins/help/helpviewer.cpp
+++ b/src/plugins/help/helpviewer.cpp
@@ -126,14 +126,13 @@ bool HelpViewer::launchWithExternalApp(const QUrl &url)
if (!saver.hasError())
saver.write(helpEngine.fileData(resolvedUrl));
if (saver.finalize(Core::ICore::mainWindow()))
- return QDesktopServices::openUrl(QUrl(saver.fileName()));
+ QDesktopServices::openUrl(QUrl(saver.fileName()));
+ return true;
}
+ return false;
}
-
- if (url.scheme() == QLatin1String("mailto"))
- return QDesktopServices::openUrl(url);
-
- return false;
+ QDesktopServices::openUrl(url);
+ return true;
}
void HelpViewer::home()
--
GitLab