From cce21d430df391f267bb0b9f468f48ebf4b6d68c Mon Sep 17 00:00:00 2001
From: dt <qtc-committer@nokia.com>
Date: Mon, 30 Aug 2010 16:41:59 +0200
Subject: [PATCH] Don't run if the qmake arguments are just in a different
order
The code is technically incorrect and easy to fool.
See the comment in the patch.
---
.../qt4projectmanager/qt4buildconfiguration.cpp | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp b/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp
index 26925b679db..eb42cd9bc42 100644
--- a/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp
+++ b/src/plugins/qt4projectmanager/qt4buildconfiguration.cpp
@@ -468,6 +468,22 @@ bool Qt4BuildConfiguration::compareToImportFrom(const QString &workingDirectory)
qDebug()<<"Parsed spec:"<<parsedSpec;
}
+ // Comparing the sorted list is obviously wrong
+ // Though haven written a more complete version
+ // that managed had around 200 lines and yet faild
+ // to be actually foolproof at all, I think it's
+ // not feasible without actually taking the qmake
+ // command line parsing code
+
+ // Things, sorting gets wrong:
+ // parameters to positional parameters matter
+ // e.g. -o -spec is different from -spec -o
+ // -o 1 -spec 2 is diffrent from -spec 1 -o 2
+ // variable assignment order matters
+ // variable assignment vs -after
+ // -norecursive vs. recursive
+ actualArgs.sort();
+ parsedArgs.sort();
if (actualArgs == parsedArgs) {
// Specs match exactly
if (actualSpec == parsedSpec)
--
GitLab