From d2571548f81f3249f00a22b61d03ac9d03fcf058 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@digia.com>
Date: Thu, 30 May 2013 16:20:17 +0200
Subject: [PATCH] Remove unneeded IEditorFactor::open re-implementations.
Change-Id: I261bc1ee09a2c22155e4874a4429a868d837c256
Reviewed-by: hjk <hjk121@nokiamail.com>
Reviewed-by: David Schulz <david.schulz@digia.com>
---
src/plugins/imageviewer/imageviewerfactory.cpp | 5 -----
src/plugins/imageviewer/imageviewerfactory.h | 1 -
src/plugins/pythoneditor/pythoneditorfactory.cpp | 10 ----------
src/plugins/pythoneditor/pythoneditorfactory.h | 5 -----
src/plugins/qnx/bardescriptoreditorfactory.cpp | 6 ------
src/plugins/qnx/bardescriptoreditorfactory.h | 1 -
6 files changed, 28 deletions(-)
diff --git a/src/plugins/imageviewer/imageviewerfactory.cpp b/src/plugins/imageviewer/imageviewerfactory.cpp
index 55d501c5c4b..d925ea6cc94 100644
--- a/src/plugins/imageviewer/imageviewerfactory.cpp
+++ b/src/plugins/imageviewer/imageviewerfactory.cpp
@@ -103,11 +103,6 @@ QString ImageViewerFactory::displayName() const
return qApp->translate("OpenWith::Editors", Constants::IMAGEVIEWER_DISPLAY_NAME);
}
-Core::IDocument *ImageViewerFactory::open(const QString & /*fileName*/)
-{
- return 0;
-}
-
void ImageViewerFactory::extensionsInitialized()
{
d->actionHandler->createActions();
diff --git a/src/plugins/imageviewer/imageviewerfactory.h b/src/plugins/imageviewer/imageviewerfactory.h
index 427eacadd4d..77d372a265d 100644
--- a/src/plugins/imageviewer/imageviewerfactory.h
+++ b/src/plugins/imageviewer/imageviewerfactory.h
@@ -50,7 +50,6 @@ public:
QStringList mimeTypes() const;
Core::Id id() const;
QString displayName() const;
- Core::IDocument *open(const QString &fileName);
void extensionsInitialized();
diff --git a/src/plugins/pythoneditor/pythoneditorfactory.cpp b/src/plugins/pythoneditor/pythoneditorfactory.cpp
index 5afe99883da..5dc783f6ae9 100644
--- a/src/plugins/pythoneditor/pythoneditorfactory.cpp
+++ b/src/plugins/pythoneditor/pythoneditorfactory.cpp
@@ -56,16 +56,6 @@ QString EditorFactory::displayName() const
return tr(Constants::C_EDITOR_DISPLAY_NAME);
}
-Core::IDocument *EditorFactory::open(const QString &fileName)
-{
- Core::IEditor *iface = Core::EditorManager::instance()->openEditor(fileName, id());
- if (!iface) {
- qWarning() << "CEditorFactory::open: openEditor failed for " << fileName;
- return 0;
- }
- return iface->document();
-}
-
Core::IEditor *EditorFactory::createEditor(QWidget *parent)
{
EditorWidget *widget = new EditorWidget(parent);
diff --git a/src/plugins/pythoneditor/pythoneditorfactory.h b/src/plugins/pythoneditor/pythoneditorfactory.h
index b483e6e4dca..5879e6fe391 100644
--- a/src/plugins/pythoneditor/pythoneditorfactory.h
+++ b/src/plugins/pythoneditor/pythoneditorfactory.h
@@ -54,11 +54,6 @@ public:
Core::Id id() const;
QString displayName() const;
- /**
- Opens file in new editor
- */
- Core::IDocument *open(const QString &fileName);
-
/**
Creates and initializes new editor widget
*/
diff --git a/src/plugins/qnx/bardescriptoreditorfactory.cpp b/src/plugins/qnx/bardescriptoreditorfactory.cpp
index da3a933dcee..ac300d3710c 100644
--- a/src/plugins/qnx/bardescriptoreditorfactory.cpp
+++ b/src/plugins/qnx/bardescriptoreditorfactory.cpp
@@ -61,12 +61,6 @@ QString BarDescriptorEditorFactory::displayName() const
return tr("Bar descriptor editor");
}
-Core::IDocument *BarDescriptorEditorFactory::open(const QString &fileName)
-{
- Core::IEditor *iface = Core::EditorManager::instance()->openEditor(fileName, id());
- return iface ? iface->document() : 0;
-}
-
Core::IEditor *BarDescriptorEditorFactory::createEditor(QWidget *parent)
{
BarDescriptorEditorWidget *editorWidget = new BarDescriptorEditorWidget(parent);
diff --git a/src/plugins/qnx/bardescriptoreditorfactory.h b/src/plugins/qnx/bardescriptoreditorfactory.h
index 1e49ac3247b..36bade0089b 100644
--- a/src/plugins/qnx/bardescriptoreditorfactory.h
+++ b/src/plugins/qnx/bardescriptoreditorfactory.h
@@ -48,7 +48,6 @@ public:
QStringList mimeTypes() const;
Core::Id id() const;
QString displayName() const;
- Core::IDocument *open(const QString &fileName);
Core::IEditor *createEditor(QWidget *parent);
--
GitLab