From d2c47f5e5434b632c871a424fc45662e120a3cce Mon Sep 17 00:00:00 2001
From: Tobias Hunger <tobias.hunger@digia.com>
Date: Wed, 13 Nov 2013 13:34:23 +0100
Subject: [PATCH] NavigationWidget: Do not leak the factorymodel
Change-Id: Ic5c5dfd2ef9b3daab1f3e04375930fc991bff0e8
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
---
src/plugins/coreplugin/navigationwidget.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/plugins/coreplugin/navigationwidget.cpp b/src/plugins/coreplugin/navigationwidget.cpp
index 180e42dc10b..811e51ac8ed 100644
--- a/src/plugins/coreplugin/navigationwidget.cpp
+++ b/src/plugins/coreplugin/navigationwidget.cpp
@@ -134,6 +134,7 @@ void NavigationWidgetPlaceHolder::currentModeAboutToChange(Core::IMode *mode)
struct NavigationWidgetPrivate
{
explicit NavigationWidgetPrivate(QAction *toggleSideBarAction);
+ ~NavigationWidgetPrivate() { delete m_factoryModel; }
QList<Internal::NavigationSubWidget *> m_subWidgets;
QHash<QShortcut *, Core::Id> m_shortcutMap;
@@ -144,7 +145,7 @@ struct NavigationWidgetPrivate
bool m_suppressed;
int m_width;
static NavigationWidget* m_instance;
- QAction *m_toggleSideBarAction;
+ QAction *m_toggleSideBarAction; // does not take ownership
};
NavigationWidgetPrivate::NavigationWidgetPrivate(QAction *toggleSideBarAction) :
--
GitLab