Commit d41e10a5 authored by Tobias Hunger's avatar Tobias Hunger

CMake: Keep buildTargets private

Nobody needs those, so do not export them.

Change-Id: Ia8866ea2a514855c029974645d9b3f3dbcaa14ed
Reviewed-by: Tim Jenssen's avatarTim Jenssen <tim.jenssen@qt.io>
parent 9b40c1fc
...@@ -64,9 +64,9 @@ void CMakeLocatorFilter::prepareSearch(const QString &entry) ...@@ -64,9 +64,9 @@ void CMakeLocatorFilter::prepareSearch(const QString &entry)
CMakeProject *cmakeProject = qobject_cast<CMakeProject *>(p); CMakeProject *cmakeProject = qobject_cast<CMakeProject *>(p);
if (!cmakeProject) if (!cmakeProject)
continue; continue;
foreach (const CMakeBuildTarget &ct, cmakeProject->buildTargets()) { foreach (const QString &title, cmakeProject->buildTargetTitles()) {
if (ct.title.contains(entry)) { if (title.contains(entry)) {
Core::LocatorFilterEntry entry(this, ct.title, cmakeProject->projectFilePath().toString()); Core::LocatorFilterEntry entry(this, title, cmakeProject->projectFilePath().toString());
entry.extraInfo = FileUtils::shortNativePath(cmakeProject->projectFilePath()); entry.extraInfo = FileUtils::shortNativePath(cmakeProject->projectFilePath());
m_result.append(entry); m_result.append(entry);
} }
......
...@@ -88,7 +88,6 @@ public: ...@@ -88,7 +88,6 @@ public:
QStringList files(FilesMode fileMode) const final; QStringList files(FilesMode fileMode) const final;
QStringList buildTargetTitles(bool runnable = false) const; QStringList buildTargetTitles(bool runnable = false) const;
QList<CMakeBuildTarget> buildTargets() const;
bool hasBuildTarget(const QString &title) const; bool hasBuildTarget(const QString &title) const;
CMakeBuildTarget buildTargetForTitle(const QString &title); CMakeBuildTarget buildTargetForTitle(const QString &title);
...@@ -110,6 +109,8 @@ protected: ...@@ -110,6 +109,8 @@ protected:
bool setupTarget(ProjectExplorer::Target *t) final; bool setupTarget(ProjectExplorer::Target *t) final;
private: private:
QList<CMakeBuildTarget> buildTargets() const;
void handleActiveTargetChanged(); void handleActiveTargetChanged();
void handleActiveBuildConfigurationChanged(); void handleActiveBuildConfigurationChanged();
void handleParsingStarted(); void handleParsingStarted();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment