Commit d76ba21a authored by Tobias Hunger's avatar Tobias Hunger

QMake: Warn if build directory and source directory are not on the same level

We used to warn about this before, but users contributed patches that got
merged that removed these warnings for qmake versions where this bug is
fixed (QTCREATORBUG-10024).

Oswald says this to the topic:
"it's possible that *some* related problems were fixed (i remember for a fact
that i tried), but the fundamental underlying reason is inherent in
fileFixify(). fixing it basically means rewriting half of qmake, which simply
isn't going to happen at this point."

Task-number: QTCREATORBUG-16430
Change-Id: I78535273adacd40895e5bf203a2ea17dcc81716d
Reviewed-by: Tobias Hunger's avatarTobias Hunger <tobias.hunger@qt.io>
parent d7f24031
......@@ -1347,12 +1347,7 @@ QList<Task> BaseQtVersion::reportIssuesImpl(const QString &proFile, const QStrin
const QChar slash = QLatin1Char('/');
if (!sourcePath.endsWith(slash))
sourcePath.append(slash);
if ((tmpBuildDir.startsWith(sourcePath)) && (tmpBuildDir != sourcePath) && qtVersion() < QtVersionNumber(5, 2, 0)) {
const QString msg = QCoreApplication::translate("QmakeProjectManager::QtVersion",
"Qmake does not support build directories below the source directory.");
results.append(Task(Task::Warning, msg, FileName(), -1,
ProjectExplorer::Constants::TASK_CATEGORY_BUILDSYSTEM));
} else if (tmpBuildDir.count(slash) != sourcePath.count(slash) && qtVersion() < QtVersionNumber(4,8, 0)) {
if (tmpBuildDir.count(slash) != sourcePath.count(slash)) {
const QString msg = QCoreApplication::translate("QmakeProjectManager::QtVersion",
"The build directory needs to be at the same level as the source directory.");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment