Commit e31accb8 authored by Leandro Melo's avatar Leandro Melo Committed by Leandro T. C. Melo
Browse files

Revert "Completion: Apply perfect match whenever not invoked explicitly"

This reverts commit 4959f53d.

It seems that usability is better when upon a perfect match the completion
popup stays when triggered either explicitly or by an activation character.
After all, in general one should need to type something else (semicolon,
parenthesis, etc.) anyway for the case of an activation character.

This is also consistent with the behavior from previous releases.

Change-Id: I1d50230affb1d0642f8f8bfd5cbac69dc52e44bd
Reviewed-on: http://codereview.qt.nokia.com/536

Reviewed-by: default avatarThorbjørn Lindeijer <thorbjorn@lindeijer.nl>
parent 44818eb3
......@@ -425,7 +425,7 @@ bool GenericProposalWidget::updateAndCheck(const QString &prefix)
if (!prefix.isEmpty())
m_d->m_model->filter(prefix);
if (m_d->m_model->size() == 0
|| (m_d->m_reason != ExplicitlyInvoked && hasMatch(prefix, m_d->m_model))) {
|| (m_d->m_reason == IdleEditor && hasMatch(prefix, m_d->m_model))) {
abort();
return false;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment