Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Marco Bubke
flatpak-qt-creator
Commits
e58e9f59
Commit
e58e9f59
authored
Jan 11, 2010
by
Erik Verbruggen
Browse files
Changed ID setting to be done before type change when reading from a file.
parent
518bdd3b
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/plugins/qmldesigner/core/model/texttomodelmerger.cpp
View file @
e58e9f59
...
...
@@ -122,14 +122,11 @@ void TextToModelMerger::syncNode(ModelNode &modelNode, const QmlDomObject &domOb
{
m_rewriterView
->
positionStorage
()
->
setNodeOffset
(
modelNode
,
domObject
.
position
());
if
(
modelNode
.
type
()
!=
domObject
.
objectType
()
||
modelNode
.
majorVersion
()
!=
domObject
.
objectTypeMajorVersion
()
||
modelNode
.
minorVersion
()
!=
domObject
.
objectTypeMinorVersion
())
{
differenceHandler
.
typeDiffers
(
modelNode
,
domObject
);
}
{
const
QString
domObjectId
=
domObject
.
objectId
();
QString
domObjectId
=
domObject
.
objectId
();
const
QmlDomProperty
domIdProperty
=
domObject
.
property
(
"id"
);
if
(
domObjectId
.
isEmpty
()
&&
domIdProperty
.
value
().
isLiteral
())
domObjectId
=
domIdProperty
.
value
().
toLiteral
().
literal
();
if
(
domObjectId
.
isEmpty
())
{
if
(
!
modelNode
.
id
().
isEmpty
())
...
...
@@ -140,6 +137,12 @@ void TextToModelMerger::syncNode(ModelNode &modelNode, const QmlDomObject &domOb
}
}
if
(
modelNode
.
type
()
!=
domObject
.
objectType
()
||
modelNode
.
majorVersion
()
!=
domObject
.
objectTypeMajorVersion
()
||
modelNode
.
minorVersion
()
!=
domObject
.
objectTypeMinorVersion
())
{
differenceHandler
.
typeDiffers
(
modelNode
,
domObject
);
}
QSet
<
QString
>
modelPropertyNames
=
QSet
<
QString
>::
fromList
(
modelNode
.
propertyNames
());
foreach
(
const
QmlDomProperty
&
domProperty
,
domObject
.
properties
())
{
...
...
@@ -149,15 +152,8 @@ void TextToModelMerger::syncNode(ModelNode &modelNode, const QmlDomObject &domOb
continue
;
if
(
domPropertyName
==
QLatin1String
(
"id"
))
{
const
QmlDomValue
domValue
=
domProperty
.
value
();
if
(
domValue
.
isLiteral
())
{
const
QString
domId
=
domValue
.
toLiteral
().
literal
();
if
(
modelNode
.
id
()
!=
domId
)
differenceHandler
.
idsDiffer
(
modelNode
,
domId
);
}
else
{
qWarning
()
<<
"id property found which is not a literal"
;
}
// already done before
continue
;
}
else
if
(
domPropertyName
.
isEmpty
())
{
qWarning
()
<<
"QML DOM returned an empty property name"
;
continue
;
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment